diff mbox series

[v2] libio: Correctly link tst-popen-fork against libpthread

Message ID 20241025074951.1932806-1-arjun@redhat.com
State New
Headers show
Series [v2] libio: Correctly link tst-popen-fork against libpthread | expand

Commit Message

Arjun Shankar Oct. 25, 2024, 7:45 a.m. UTC 
tst-popen-fork failed to build for Hurd due to not being linked with
libpthread.  This commit fixes that.

Tested with build-many-glibcs.py for i686-gnu.
---
v1 here:
https://sourceware.org/pipermail/libc-alpha/2024-October/160928.html

Changes in v2: Removed unnecessary check for have-thread-library.

 libio/Makefile | 2 ++
 1 file changed, 2 insertions(+)

Comments

Florian Weimer Oct. 25, 2024, 8:31 a.m. UTC | #1 
* Arjun Shankar:

> tst-popen-fork failed to build for Hurd due to not being linked with
> libpthread.  This commit fixes that.
>
> Tested with build-many-glibcs.py for i686-gnu.
> ---
> v1 here:
> https://sourceware.org/pipermail/libc-alpha/2024-October/160928.html
>
> Changes in v2: Removed unnecessary check for have-thread-library.
>
>  libio/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/libio/Makefile b/libio/Makefile
> index 018c26d971..cd5a3afeeb 100644
> --- a/libio/Makefile
> +++ b/libio/Makefile
> @@ -144,6 +144,8 @@ tests = \
>    tst_wscanf \
>    # tests
>  
> +$(objpfx)tst-popen-fork: $(shared-thread-library)
> +
>  tests-internal = tst-vtables tst-vtables-interposed
>  
>  ifeq (yes,$(build-shared))

This version looks okay to me.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian
diff mbox series

Patch

diff --git a/libio/Makefile b/libio/Makefile
index 018c26d971..cd5a3afeeb 100644
--- a/libio/Makefile
+++ b/libio/Makefile
@@ -144,6 +144,8 @@  tests = \
   tst_wscanf \
   # tests
 
+$(objpfx)tst-popen-fork: $(shared-thread-library)
+
 tests-internal = tst-vtables tst-vtables-interposed
 
 ifeq (yes,$(build-shared))