| Message ID | 20240521122829.2344430-1-hjl.tools@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] Remove the clone3 symbol from libc.a [BZ #31770] | expand |
On 21/05/24 09:28, H.J. Lu wrote: > clone3 isn't exported from glibc and is hidden in libc.so. Fix BZ #31770 > by removing clone3 alias. > > Signed-off-by: H.J. Lu <hjl.tools@gmail.com> LGTM, thanks. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > --- > sysdeps/unix/sysv/linux/aarch64/clone3.S | 1 - > sysdeps/unix/sysv/linux/arc/clone3.S | 1 - > sysdeps/unix/sysv/linux/arm/clone3.S | 1 - > sysdeps/unix/sysv/linux/i386/clone3.S | 1 - > sysdeps/unix/sysv/linux/loongarch/clone3.S | 1 - > sysdeps/unix/sysv/linux/mips/clone3.S | 1 - > sysdeps/unix/sysv/linux/powerpc/powerpc64/clone3.S | 1 - > sysdeps/unix/sysv/linux/riscv/clone3.S | 1 - > sysdeps/unix/sysv/linux/s390/s390-32/clone3.S | 1 - > sysdeps/unix/sysv/linux/s390/s390-64/clone3.S | 1 - > sysdeps/unix/sysv/linux/x86_64/clone3.S | 1 - > 11 files changed, 11 deletions(-) > > diff --git a/sysdeps/unix/sysv/linux/aarch64/clone3.S b/sysdeps/unix/sysv/linux/aarch64/clone3.S > index 92d69a5430..e28aaa5083 100644 > --- a/sysdeps/unix/sysv/linux/aarch64/clone3.S > +++ b/sysdeps/unix/sysv/linux/aarch64/clone3.S > @@ -82,4 +82,3 @@ thread_start: > .size thread_start, .-thread_start > > libc_hidden_def (__clone3) > -weak_alias (__clone3, clone3) > diff --git a/sysdeps/unix/sysv/linux/arc/clone3.S b/sysdeps/unix/sysv/linux/arc/clone3.S > index d9a2dfff3e..38a27063fb 100644 > --- a/sysdeps/unix/sysv/linux/arc/clone3.S > +++ b/sysdeps/unix/sysv/linux/arc/clone3.S > @@ -87,4 +87,3 @@ thread_start_clone3: > .size thread_start_clone3, .-thread_start_clone3 > > libc_hidden_def (__clone3) > -weak_alias (__clone3, clone3) > diff --git a/sysdeps/unix/sysv/linux/arm/clone3.S b/sysdeps/unix/sysv/linux/arm/clone3.S > index e759de9730..094efc2f40 100644 > --- a/sysdeps/unix/sysv/linux/arm/clone3.S > +++ b/sysdeps/unix/sysv/linux/arm/clone3.S > @@ -77,4 +77,3 @@ PSEUDO_END (__clone3) > .fnend > > libc_hidden_def (__clone3) > -weak_alias (__clone3, clone3) > diff --git a/sysdeps/unix/sysv/linux/i386/clone3.S b/sysdeps/unix/sysv/linux/i386/clone3.S > index abb7356b1f..6803e59644 100644 > --- a/sysdeps/unix/sysv/linux/i386/clone3.S > +++ b/sysdeps/unix/sysv/linux/i386/clone3.S > @@ -120,4 +120,3 @@ L(thread_start): > PSEUDO_END (__clone3) > > libc_hidden_def (__clone3) > -weak_alias (__clone3, clone3) > diff --git a/sysdeps/unix/sysv/linux/loongarch/clone3.S b/sysdeps/unix/sysv/linux/loongarch/clone3.S > index 20eaf4adc2..dfffb1f3d6 100644 > --- a/sysdeps/unix/sysv/linux/loongarch/clone3.S > +++ b/sysdeps/unix/sysv/linux/loongarch/clone3.S > @@ -80,4 +80,3 @@ L (thread_start3): > END (__thread_start3) > > libc_hidden_def (__clone3) > -weak_alias (__clone3, clone3) > diff --git a/sysdeps/unix/sysv/linux/mips/clone3.S b/sysdeps/unix/sysv/linux/mips/clone3.S > index 481b8ae963..58925d6b41 100644 > --- a/sysdeps/unix/sysv/linux/mips/clone3.S > +++ b/sysdeps/unix/sysv/linux/mips/clone3.S > @@ -158,4 +158,3 @@ L(thread_start_clone3): > END(__thread_start_clone3) > > libc_hidden_def (__clone3) > -weak_alias (__clone3, clone3) > diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone3.S b/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone3.S > index 6fdb4a6073..900c354c9c 100644 > --- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone3.S > +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone3.S > @@ -154,4 +154,3 @@ L(parent): > PSEUDO_END (__clone3) > > libc_hidden_def (__clone3) > -weak_alias (__clone3, clone3) > diff --git a/sysdeps/unix/sysv/linux/riscv/clone3.S b/sysdeps/unix/sysv/linux/riscv/clone3.S > index 29264be054..c81ee2ab51 100644 > --- a/sysdeps/unix/sysv/linux/riscv/clone3.S > +++ b/sysdeps/unix/sysv/linux/riscv/clone3.S > @@ -76,4 +76,3 @@ L(thread_start): > END(__thread_start_clone3) > > libc_hidden_def (__clone3) > -weak_alias (__clone3, clone3) > diff --git a/sysdeps/unix/sysv/linux/s390/s390-32/clone3.S b/sysdeps/unix/sysv/linux/s390/s390-32/clone3.S > index d344c2cf36..1ea633aabb 100644 > --- a/sysdeps/unix/sysv/linux/s390/s390-32/clone3.S > +++ b/sysdeps/unix/sysv/linux/s390/s390-32/clone3.S > @@ -75,4 +75,3 @@ thread_start: > ASM_SIZE_DIRECTIVE (thread_start) > > libc_hidden_def (__clone3) > -weak_alias (__clone3, clone3) > diff --git a/sysdeps/unix/sysv/linux/s390/s390-64/clone3.S b/sysdeps/unix/sysv/linux/s390/s390-64/clone3.S > index ca382d903c..70ae7f1532 100644 > --- a/sysdeps/unix/sysv/linux/s390/s390-64/clone3.S > +++ b/sysdeps/unix/sysv/linux/s390/s390-64/clone3.S > @@ -75,4 +75,3 @@ thread_start: > ASM_SIZE_DIRECTIVE (thread_start) > > libc_hidden_def (__clone3) > -weak_alias (__clone3, clone3) > diff --git a/sysdeps/unix/sysv/linux/x86_64/clone3.S b/sysdeps/unix/sysv/linux/x86_64/clone3.S > index 5a2d42234e..4cc19e066c 100644 > --- a/sysdeps/unix/sysv/linux/x86_64/clone3.S > +++ b/sysdeps/unix/sysv/linux/x86_64/clone3.S > @@ -86,4 +86,3 @@ L(thread_start): > PSEUDO_END (__clone3) > > libc_hidden_def (__clone3) > -weak_alias (__clone3, clone3)
diff --git a/sysdeps/unix/sysv/linux/aarch64/clone3.S b/sysdeps/unix/sysv/linux/aarch64/clone3.S index 92d69a5430..e28aaa5083 100644 --- a/sysdeps/unix/sysv/linux/aarch64/clone3.S +++ b/sysdeps/unix/sysv/linux/aarch64/clone3.S @@ -82,4 +82,3 @@ thread_start: .size thread_start, .-thread_start libc_hidden_def (__clone3) -weak_alias (__clone3, clone3) diff --git a/sysdeps/unix/sysv/linux/arc/clone3.S b/sysdeps/unix/sysv/linux/arc/clone3.S index d9a2dfff3e..38a27063fb 100644 --- a/sysdeps/unix/sysv/linux/arc/clone3.S +++ b/sysdeps/unix/sysv/linux/arc/clone3.S @@ -87,4 +87,3 @@ thread_start_clone3: .size thread_start_clone3, .-thread_start_clone3 libc_hidden_def (__clone3) -weak_alias (__clone3, clone3) diff --git a/sysdeps/unix/sysv/linux/arm/clone3.S b/sysdeps/unix/sysv/linux/arm/clone3.S index e759de9730..094efc2f40 100644 --- a/sysdeps/unix/sysv/linux/arm/clone3.S +++ b/sysdeps/unix/sysv/linux/arm/clone3.S @@ -77,4 +77,3 @@ PSEUDO_END (__clone3) .fnend libc_hidden_def (__clone3) -weak_alias (__clone3, clone3) diff --git a/sysdeps/unix/sysv/linux/i386/clone3.S b/sysdeps/unix/sysv/linux/i386/clone3.S index abb7356b1f..6803e59644 100644 --- a/sysdeps/unix/sysv/linux/i386/clone3.S +++ b/sysdeps/unix/sysv/linux/i386/clone3.S @@ -120,4 +120,3 @@ L(thread_start): PSEUDO_END (__clone3) libc_hidden_def (__clone3) -weak_alias (__clone3, clone3) diff --git a/sysdeps/unix/sysv/linux/loongarch/clone3.S b/sysdeps/unix/sysv/linux/loongarch/clone3.S index 20eaf4adc2..dfffb1f3d6 100644 --- a/sysdeps/unix/sysv/linux/loongarch/clone3.S +++ b/sysdeps/unix/sysv/linux/loongarch/clone3.S @@ -80,4 +80,3 @@ L (thread_start3): END (__thread_start3) libc_hidden_def (__clone3) -weak_alias (__clone3, clone3) diff --git a/sysdeps/unix/sysv/linux/mips/clone3.S b/sysdeps/unix/sysv/linux/mips/clone3.S index 481b8ae963..58925d6b41 100644 --- a/sysdeps/unix/sysv/linux/mips/clone3.S +++ b/sysdeps/unix/sysv/linux/mips/clone3.S @@ -158,4 +158,3 @@ L(thread_start_clone3): END(__thread_start_clone3) libc_hidden_def (__clone3) -weak_alias (__clone3, clone3) diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone3.S b/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone3.S index 6fdb4a6073..900c354c9c 100644 --- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone3.S +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone3.S @@ -154,4 +154,3 @@ L(parent): PSEUDO_END (__clone3) libc_hidden_def (__clone3) -weak_alias (__clone3, clone3) diff --git a/sysdeps/unix/sysv/linux/riscv/clone3.S b/sysdeps/unix/sysv/linux/riscv/clone3.S index 29264be054..c81ee2ab51 100644 --- a/sysdeps/unix/sysv/linux/riscv/clone3.S +++ b/sysdeps/unix/sysv/linux/riscv/clone3.S @@ -76,4 +76,3 @@ L(thread_start): END(__thread_start_clone3) libc_hidden_def (__clone3) -weak_alias (__clone3, clone3) diff --git a/sysdeps/unix/sysv/linux/s390/s390-32/clone3.S b/sysdeps/unix/sysv/linux/s390/s390-32/clone3.S index d344c2cf36..1ea633aabb 100644 --- a/sysdeps/unix/sysv/linux/s390/s390-32/clone3.S +++ b/sysdeps/unix/sysv/linux/s390/s390-32/clone3.S @@ -75,4 +75,3 @@ thread_start: ASM_SIZE_DIRECTIVE (thread_start) libc_hidden_def (__clone3) -weak_alias (__clone3, clone3) diff --git a/sysdeps/unix/sysv/linux/s390/s390-64/clone3.S b/sysdeps/unix/sysv/linux/s390/s390-64/clone3.S index ca382d903c..70ae7f1532 100644 --- a/sysdeps/unix/sysv/linux/s390/s390-64/clone3.S +++ b/sysdeps/unix/sysv/linux/s390/s390-64/clone3.S @@ -75,4 +75,3 @@ thread_start: ASM_SIZE_DIRECTIVE (thread_start) libc_hidden_def (__clone3) -weak_alias (__clone3, clone3) diff --git a/sysdeps/unix/sysv/linux/x86_64/clone3.S b/sysdeps/unix/sysv/linux/x86_64/clone3.S index 5a2d42234e..4cc19e066c 100644 --- a/sysdeps/unix/sysv/linux/x86_64/clone3.S +++ b/sysdeps/unix/sysv/linux/x86_64/clone3.S @@ -86,4 +86,3 @@ L(thread_start): PSEUDO_END (__clone3) libc_hidden_def (__clone3) -weak_alias (__clone3, clone3)
clone3 isn't exported from glibc and is hidden in libc.so. Fix BZ #31770 by removing clone3 alias. Signed-off-by: H.J. Lu <hjl.tools@gmail.com> --- sysdeps/unix/sysv/linux/aarch64/clone3.S | 1 - sysdeps/unix/sysv/linux/arc/clone3.S | 1 - sysdeps/unix/sysv/linux/arm/clone3.S | 1 - sysdeps/unix/sysv/linux/i386/clone3.S | 1 - sysdeps/unix/sysv/linux/loongarch/clone3.S | 1 - sysdeps/unix/sysv/linux/mips/clone3.S | 1 - sysdeps/unix/sysv/linux/powerpc/powerpc64/clone3.S | 1 - sysdeps/unix/sysv/linux/riscv/clone3.S | 1 - sysdeps/unix/sysv/linux/s390/s390-32/clone3.S | 1 - sysdeps/unix/sysv/linux/s390/s390-64/clone3.S | 1 - sysdeps/unix/sysv/linux/x86_64/clone3.S | 1 - 11 files changed, 11 deletions(-)