From patchwork Thu Aug 24 08:50:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: dengjianbo X-Patchwork-Id: 1825187 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RWcHY55Xlz1yg8 for ; Thu, 24 Aug 2023 18:50:49 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB3C9385DC33 for ; Thu, 24 Aug 2023 08:50:47 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 0AF633858C2C for ; Thu, 24 Aug 2023 08:50:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0AF633858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [10.2.5.5]) by gateway (Coremail) with SMTP id _____8AxTevNGedk7XIbAA--.50754S3; Thu, 24 Aug 2023 16:50:21 +0800 (CST) Received: from 5.5.5 (unknown [10.2.5.5]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxriPMGedkoTBiAA--.1934S2; Thu, 24 Aug 2023 16:50:20 +0800 (CST) From: dengjianbo To: libc-alpha@sourceware.org Cc: adhemerval.zanella@linaro.org, xry111@xry111.site, caiyinyu@loongson.cn, xuchenghua@loongson.cn, huangpei@loongson.cn, dengjianbo Subject: [PATCH v2 1/3] LoongArch: Add ifunc support for strnlen{aligned, lsx, lasx} Date: Thu, 24 Aug 2023 16:50:17 +0800 Message-Id: <20230824085019.2608438-1-dengjianbo@loongson.cn> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-CM-TRANSID: AQAAf8CxriPMGedkoTBiAA--.1934S2 X-CM-SenderInfo: pghqwyxldqu0o6or00hjvr0hdfq/ X-Coremail-Antispam: 1Uk129KBj9fXoW3CryrZF1fuFWrJw18tFy5GFX_yoW8JFyUAo WfKFWDJrs2kr4UKw4UCrsrWasrWr1fCr12v3yjva95Jr18Kry5CryrCa4fK39rJrn5Wr4r Xa4fZ39xJF97GF1kl-sFpf9Il3svdjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8wcxFpf 9Il3svdxBIdaVrn0xqx4xG64xvF2IEw4CE5I8CrVC2j2Jv73VFW2AGmfu7bjvjm3AaLaJ3 UjIYCTnIWjp_UUUY17kC6x804xWl14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI 8IcIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xG Y2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14 v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E 14v26F4UJVW0owAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI 0UMc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280 aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JMxAIw28Icx kI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2Iq xVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42 IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY 6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aV CY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUzsqWUUUUU X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_SHORT, KAM_STOCKGEN, SCC_5_SHORT_WORD_LINES, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" Based on the glibc microbenchmark, strnlen-aligned implementation could reduce the runtime more than 10%, strnlen-lsx implementation could reduce the runtime about 50%-78%, strnlen-lasx implementation could reduce the runtime about 50%-88%. --- sysdeps/loongarch/lp64/multiarch/Makefile | 3 + .../lp64/multiarch/ifunc-impl-list.c | 8 ++ .../loongarch/lp64/multiarch/ifunc-strnlen.h | 41 +++++++ .../lp64/multiarch/strnlen-aligned.S | 102 ++++++++++++++++++ .../loongarch/lp64/multiarch/strnlen-lasx.S | 100 +++++++++++++++++ .../loongarch/lp64/multiarch/strnlen-lsx.S | 89 +++++++++++++++ sysdeps/loongarch/lp64/multiarch/strnlen.c | 39 +++++++ 7 files changed, 382 insertions(+) create mode 100644 sysdeps/loongarch/lp64/multiarch/ifunc-strnlen.h create mode 100644 sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S create mode 100644 sysdeps/loongarch/lp64/multiarch/strnlen-lasx.S create mode 100644 sysdeps/loongarch/lp64/multiarch/strnlen-lsx.S create mode 100644 sysdeps/loongarch/lp64/multiarch/strnlen.c diff --git a/sysdeps/loongarch/lp64/multiarch/Makefile b/sysdeps/loongarch/lp64/multiarch/Makefile index afa5104174..c4dd3143d1 100644 --- a/sysdeps/loongarch/lp64/multiarch/Makefile +++ b/sysdeps/loongarch/lp64/multiarch/Makefile @@ -3,6 +3,9 @@ sysdep_routines += \ strlen-aligned \ strlen-lsx \ strlen-lasx \ + strnlen-aligned \ + strnlen-lsx \ + strnlen-lasx \ strchr-aligned \ strchr-lsx \ strchr-lasx \ diff --git a/sysdeps/loongarch/lp64/multiarch/ifunc-impl-list.c b/sysdeps/loongarch/lp64/multiarch/ifunc-impl-list.c index 25eb96b061..7cec0b7724 100644 --- a/sysdeps/loongarch/lp64/multiarch/ifunc-impl-list.c +++ b/sysdeps/loongarch/lp64/multiarch/ifunc-impl-list.c @@ -38,6 +38,14 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array, IFUNC_IMPL_ADD (array, i, strlen, 1, __strlen_aligned) ) + IFUNC_IMPL (i, name, strnlen, +#if !defined __loongarch_soft_float + IFUNC_IMPL_ADD (array, i, strnlen, SUPPORT_LASX, __strnlen_lasx) + IFUNC_IMPL_ADD (array, i, strnlen, SUPPORT_LSX, __strnlen_lsx) +#endif + IFUNC_IMPL_ADD (array, i, strnlen, 1, __strnlen_aligned) + ) + IFUNC_IMPL (i, name, strchr, #if !defined __loongarch_soft_float IFUNC_IMPL_ADD (array, i, strchr, SUPPORT_LASX, __strchr_lasx) diff --git a/sysdeps/loongarch/lp64/multiarch/ifunc-strnlen.h b/sysdeps/loongarch/lp64/multiarch/ifunc-strnlen.h new file mode 100644 index 0000000000..5cf8981021 --- /dev/null +++ b/sysdeps/loongarch/lp64/multiarch/ifunc-strnlen.h @@ -0,0 +1,41 @@ +/* Common definition for strnlen ifunc selections. + All versions must be listed in ifunc-impl-list.c. + Copyright (C) 2023 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include + +#if !defined __loongarch_soft_float +extern __typeof (REDIRECT_NAME) OPTIMIZE (lasx) attribute_hidden; +extern __typeof (REDIRECT_NAME) OPTIMIZE (lsx) attribute_hidden; +#endif + +extern __typeof (REDIRECT_NAME) OPTIMIZE (aligned) attribute_hidden; + +static inline void * +IFUNC_SELECTOR (void) +{ +#if !defined __loongarch_soft_float + if (SUPPORT_LASX) + return OPTIMIZE (lasx); + else if (SUPPORT_LSX) + return OPTIMIZE (lsx); + else +#endif + return OPTIMIZE (aligned); +} diff --git a/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S b/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S new file mode 100644 index 0000000000..b900430a5d --- /dev/null +++ b/sysdeps/loongarch/lp64/multiarch/strnlen-aligned.S @@ -0,0 +1,102 @@ +/* Optimized strnlen implementation using basic Loongarch instructions. + Copyright (C) 2023 Free Software Foundation, Inc. + + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library. If not, see + . */ + +#include +#include +#include + +#if IS_IN (libc) +# define STRNLEN __strnlen_aligned +#else +# define STRNLEN __strnlen +#endif + +LEAF(STRNLEN, 6) + beqz a1, L(out) + lu12i.w a2, 0x01010 + andi t1, a0, 0x7 + move t4, a0 + + bstrins.d a0, zero, 2, 0 + ori a2, a2, 0x101 + li.w t0, -1 + ld.d t2, a0, 0 + + slli.d t3, t1, 3 + bstrins.d a2, a2, 63, 32 + li.w t5, 8 + slli.d a3, a2, 7 + + sub.w t1, t5, t1 + sll.d t0, t0, t3 + orn t2, t2, t0 + sub.d t0, t2, a2 + + + andn t3, a3, t2 + and t0, t0, t3 + bnez t0, L(count_pos) + sub.d t5, a1, t1 + + bgeu t1, a1, L(out) + addi.d a0, a0, 8 +L(loop): + ld.d t2, a0, 0 + sub.d t0, t2, a2 + + andn t1, a3, t2 + sltui t6, t5, 9 + and t0, t0, t1 + or t7, t0, t6 + + bnez t7, L(count_pos) + ld.d t2, a0, 8 + addi.d a0, a0, 16 + sub.d t0, t2, a2 + + + andn t1, a3, t2 + sltui t6, t5, 17 + and t0, t0, t1 + addi.d t5, t5, -16 + + or t7, t0, t6 + beqz t7, L(loop) + addi.d a0, a0, -8 +L(count_pos): + ctz.d t1, t0 + + sub.d a0, a0, t4 + srli.d t1, t1, 3 + add.d a0, t1, a0 + sltu t0, a0, a1 + + masknez t1, a1, t0 + maskeqz a0, a0, t0 + or a0, a0, t1 + jr ra + + +L(out): + move a0, a1 + jr ra +END(STRNLEN) + +weak_alias (STRNLEN, strnlen) +libc_hidden_builtin_def (STRNLEN) diff --git a/sysdeps/loongarch/lp64/multiarch/strnlen-lasx.S b/sysdeps/loongarch/lp64/multiarch/strnlen-lasx.S new file mode 100644 index 0000000000..2c03d3d9b4 --- /dev/null +++ b/sysdeps/loongarch/lp64/multiarch/strnlen-lasx.S @@ -0,0 +1,100 @@ +/* Optimized strnlen implementation using loongarch LASX instructions + Copyright (C) 2023 Free Software Foundation, Inc. + + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library. If not, see + . */ + +#include +#include +#include + +#if IS_IN (libc) && !defined __loongarch_soft_float + +# define STRNLEN __strnlen_lasx + +LEAF(STRNLEN, 6) + beqz a1, L(ret0) + andi t1, a0, 0x3f + li.d t3, 65 + sub.d a2, a0, t1 + + xvld xr0, a2, 0 + xvld xr1, a2, 32 + sub.d t1, t3, t1 + move a3, a0 + + sltu t1, a1, t1 + xvmsknz.b xr0, xr0 + xvmsknz.b xr1, xr1 + xvpickve.w xr2, xr0, 4 + + xvpickve.w xr3, xr1, 4 + vilvl.h vr0, vr2, vr0 + vilvl.h vr1, vr3, vr1 + vilvl.w vr0, vr1, vr0 + + + movfr2gr.d t0, fa0 + sra.d t0, t0, a0 + orn t1, t1, t0 + bnez t1, L(end) + + add.d a4, a0, a1 + move a0, a2 + addi.d a4, a4, -1 + bstrins.d a4, zero, 5, 0 + +L(loop): + xvld xr0, a0, 64 + xvld xr1, a0, 96 + addi.d a0, a0, 64 + beq a0, a4, L(out) + + xvmin.bu xr2, xr0, xr1 + xvsetanyeqz.b fcc0, xr2 + bceqz fcc0, L(loop) +L(out): + xvmsknz.b xr0, xr0 + + + xvmsknz.b xr1, xr1 + xvpickve.w xr2, xr0, 4 + xvpickve.w xr3, xr1, 4 + vilvl.h vr0, vr2, vr0 + + vilvl.h vr1, vr3, vr1 + vilvl.w vr0, vr1, vr0 + movfr2gr.d t0, fa0 +L(end): + sub.d a0, a0, a3 + + cto.d t0, t0 + add.d a0, a0, t0 + sltu t1, a0, a1 + masknez t0, a1, t1 + + maskeqz t1, a0, t1 + or a0, t0, t1 + jr ra +L(ret0): + move a0, zero + + + jr ra +END(STRNLEN) + +libc_hidden_def (STRNLEN) +#endif diff --git a/sysdeps/loongarch/lp64/multiarch/strnlen-lsx.S b/sysdeps/loongarch/lp64/multiarch/strnlen-lsx.S new file mode 100644 index 0000000000..b769a89584 --- /dev/null +++ b/sysdeps/loongarch/lp64/multiarch/strnlen-lsx.S @@ -0,0 +1,89 @@ +/* Optimized strnlen implementation using loongarch LSX instructions + Copyright (C) 2023 Free Software Foundation, Inc. + + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library. If not, see + . */ + +#include +#include +#include + +#if IS_IN (libc) && !defined __loongarch_soft_float + +# define STRNLEN __strnlen_lsx + +LEAF(STRNLEN, 6) + beqz a1, L(ret0) + andi t1, a0, 0x1f + li.d t3, 33 + sub.d a2, a0, t1 + + vld vr0, a2, 0 + vld vr1, a2, 16 + sub.d t1, t3, t1 + move a3, a0 + + sltu t1, a1, t1 + vmsknz.b vr0, vr0 + vmsknz.b vr1, vr1 + vilvl.h vr0, vr1, vr0 + + movfr2gr.s t0, fa0 + sra.w t0, t0, a0 + orn t1, t1, t0 + bnez t1, L(end) + + + add.d a4, a0, a1 + move a0, a2 + addi.d a4, a4, -1 + bstrins.d a4, zero, 4, 0 + +L(loop): + vld vr0, a0, 32 + vld vr1, a0, 48 + addi.d a0, a0, 32 + beq a0, a4, L(out) + + vmin.bu vr2, vr0, vr1 + vsetanyeqz.b fcc0, vr2 + bceqz fcc0, L(loop) +L(out): + vmsknz.b vr0, vr0 + + vmsknz.b vr1, vr1 + vilvl.h vr0, vr1, vr0 + movfr2gr.s t0, fa0 +L(end): + sub.d a0, a0, a3 + + + cto.w t0, t0 + add.d a0, a0, t0 + sltu t1, a0, a1 + masknez t0, a1, t1 + + maskeqz t1, a0, t1 + or a0, t0, t1 + jr ra +L(ret0): + move a0, zero + + jr ra +END(STRNLEN) + +libc_hidden_builtin_def (STRNLEN) +#endif diff --git a/sysdeps/loongarch/lp64/multiarch/strnlen.c b/sysdeps/loongarch/lp64/multiarch/strnlen.c new file mode 100644 index 0000000000..38b7a25a7a --- /dev/null +++ b/sysdeps/loongarch/lp64/multiarch/strnlen.c @@ -0,0 +1,39 @@ +/* Multiple versions of strnlen. + All versions must be listed in ifunc-impl-list.c. + Copyright (C) 2023 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +/* Define multiple versions only for the definition in libc. */ +#if IS_IN (libc) +# define strnlen __redirect_strnlen +# define __strnlen __redirect___strnlen +# include +# undef __strnlen +# undef strnlen + +# define SYMBOL_NAME strnlen +# include "ifunc-strnlen.h" + +libc_ifunc_redirected (__redirect_strnlen, __strnlen, IFUNC_SELECTOR ()); +weak_alias (__strnlen, strnlen); +# ifdef SHARED +__hidden_ver1 (__strnlen, __GI___strnlen, __redirect___strnlen) + __attribute__((visibility ("hidden"))) __attribute_copy__ (strnlen); +__hidden_ver1 (strnlen, __GI_strnlen, __redirect_strnlen) + __attribute__((weak, visibility ("hidden"))) __attribute_copy__ (strnlen); +# endif +#endif