From patchwork Thu Jun 29 18:41:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 1801592 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=mAQgg4um; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QsS4z20wMz1yhT for ; Fri, 30 Jun 2023 04:43:15 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2542C3857C66 for ; Thu, 29 Jun 2023 18:43:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2542C3857C66 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1688064193; bh=NLyvrxDYrJ6rjAl7pBcIGAPMLVTSmMod1UfJffr6Ruk=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=mAQgg4umzukcq9vFVuIqNowqNTCbouqPnHgaNOEwlGLCEKtwj+9k39yyT2rMg+zam fI14MTYRnGO5rFvtRAiIFLLNVPA60gMorIfQOXxOJ2McbwUsdJpVVeGntBxCY0He+k IeoAalTptENT/D7FouyJo5FKWpwAQ1gvn9SEpjgY= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from butterfly.birch.relay.mailchannels.net (butterfly.birch.relay.mailchannels.net [23.83.209.27]) by sourceware.org (Postfix) with ESMTPS id 5E6223858C74 for ; Thu, 29 Jun 2023 18:42:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5E6223858C74 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id F0FE26C16FB; Thu, 29 Jun 2023 18:42:06 +0000 (UTC) Received: from pdx1-sub0-mail-a286.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 54E5B6C1562 for ; Thu, 29 Jun 2023 18:42:06 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1688064126; a=rsa-sha256; cv=none; b=ZymRHjNo92DzsSyHVUzM+iXzQOwUvNQOTQOmmDOCKM/pKUFgXq42V4nf2QY4CisGWl1Ffq 4tK4NNfdo1lpipFJVuZwoHmqUWzreqzVVDma4tftIyEp9S7YDEZuX27tCy89xFM3Eyd9Nd 9vwBZ9pcikkgVJuK0BzSeCdNLsSO6RQy5qD4jYBzG3cq5Udl7BIaUMzoVlZWFjb4L7+gKs TPoUXOlNyXUo2dcuHmifqoo9iPoo5iyyRcaPEESTeH1/VuxM4/2pF5s1MXXq/iZlunDJkX L28dZaUyeEWxm+xUcKrUsCwg3S+CqOfpwsjoORhzwfXkRmca/jjhLZuP0uFAkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1688064126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NLyvrxDYrJ6rjAl7pBcIGAPMLVTSmMod1UfJffr6Ruk=; b=g/KXmrWFxJVRw4seBBeYux6gyxkIigt1d0+KIMCanXRRmw0SMmwrGoABKtrOQdAM/XgID5 7tqZgF52eWZLJnPBJRLmruR9i6pXKHdSyc9GjvGlTpnKt/gxyj5bYt69jWEK7Mre/Ysz/j aGveDvu97io12gytcCkhCLl6bmCwGXCvChOyAEn0xS5fkpZzgaR57VSs271UDcl9O49hWU ZD+UusxPyZaMjei7vgORCV7HHaul1g0RNcJQN5bZNt3N3jtrSJv3/FxIDvdrQrisgY+aJd pEjFNykRFADthPfcICY6CtYfyR5FK66boKRGxKCagOuJgJyhO+brrb8Woi45KA== ARC-Authentication-Results: i=1; rspamd-9fcc56855-lfnmh; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MC-Copy: stored-urls X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-White-Befitting: 1a4a8f6e34bda5c9_1688064126564_2802489546 X-MC-Loop-Signature: 1688064126564:172623747 X-MC-Ingress-Time: 1688064126563 Received: from pdx1-sub0-mail-a286.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.116.217.230 (trex/6.9.1); Thu, 29 Jun 2023 18:42:06 +0000 Received: from fedora.redhat.com (bras-vprn-toroon4834w-lp130-09-174-91-45-44.dsl.bell.ca [174.91.45.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a286.dreamhost.com (Postfix) with ESMTPSA id 4QsS3f0FP8znD for ; Thu, 29 Jun 2023 11:42:05 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH 4/4] configure: Disable building libcrypt by default Date: Thu, 29 Jun 2023 14:41:47 -0400 Message-ID: <20230629184156.2789945-5-siddhesh@sourceware.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230629184156.2789945-1-siddhesh@sourceware.org> References: <20230629184156.2789945-1-siddhesh@sourceware.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1172.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Siddhesh Poyarekar via Libc-alpha From: Siddhesh Poyarekar Reply-To: Siddhesh Poyarekar Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" We mentioned eventual dropping of libcrypt in the 2.28 NEWS. Actually put that plan in motion by first disabling building libcrypt by default. In the near future we need to drop it completely but ISTM that Gentoo still uses it to fix some perl compatibility issues. Signed-off-by: Siddhesh Poyarekar --- INSTALL | 12 ++++++------ NEWS | 5 +++++ configure | 6 +++--- configure.ac | 6 +++--- manual/install.texi | 13 +++++++------ 5 files changed, 24 insertions(+), 18 deletions(-) diff --git a/INSTALL b/INSTALL index 88ffe7748f..263e8ce75a 100644 --- a/INSTALL +++ b/INSTALL @@ -229,12 +229,12 @@ if ‘CFLAGS’ is specified it must enable optimization. For example: By default for x86_64, the GNU C Library is built with the vector math library. Use this option to disable the vector math library. -‘--disable-crypt’ - Do not install the passphrase-hashing library ‘libcrypt’ or the - header file ‘crypt.h’. ‘unistd.h’ will still declare the function - ‘crypt’. Using this option does not change the set of programs - that may need to be linked with ‘-lcrypt’; it only means that the - GNU C Library will not provide that library. +‘--enable-crypt’ + Install the passphrase-hashing library ‘libcrypt’ and the header + file ‘crypt.h’. ‘unistd.h’ will declare the function ‘crypt’ + regardless of this option. Using this option does not change the + set of programs that may need to be linked with ‘-lcrypt’; it only + means that the GNU C Library will not provide that library. This option is for hackers and distributions experimenting with independently-maintained implementations of libcrypt. It may diff --git a/NEWS b/NEWS index 264fad5d86..9d82c5ba62 100644 --- a/NEWS +++ b/NEWS @@ -55,6 +55,11 @@ Major new features: * Lazy binding is now disabled by default and can be overridden with the --disable-bind-now configure flag. +* libcrypt is no longer built by default, one may use the --enable-crypt + option to build libcrypt. It is recommended that applications port + away from the GNU C Library implementation of libcrypt since it will + likely be removed in a future release. + Deprecated and removed features, and other changes affecting compatibility: * In the Linux kernel for the hppa/parisc architecture some of the diff --git a/configure b/configure index 6d4b05df18..4d924c4c21 100755 --- a/configure +++ b/configure @@ -1480,8 +1480,8 @@ Optional Features: architectures --enable-memory-tagging enable memory tagging if supported by the architecture [default=no] - --disable-crypt do not build nor install the passphrase hashing - library, libcrypt + --enable-crypt build and install the passphrase hashing library, + libcrypt --enable-nss-crypt enable libcrypt to use nss --enable-systemtap enable systemtap static probe points [default=no] --disable-build-nscd disable building and installing the nscd daemon @@ -4569,7 +4569,7 @@ if test ${enable_crypt+y} then : enableval=$enable_crypt; build_crypt=$enableval else $as_nop - build_crypt=yes + build_crypt=no fi diff --git a/configure.ac b/configure.ac index 6fc72df700..8d9ab7d0b6 100644 --- a/configure.ac +++ b/configure.ac @@ -316,10 +316,10 @@ fi AC_SUBST(memory_tagging) AC_ARG_ENABLE([crypt], - AS_HELP_STRING([--disable-crypt], - [do not build nor install the passphrase hashing library, libcrypt]), + AS_HELP_STRING([--enable-crypt], + [build and install the passphrase hashing library, libcrypt]), [build_crypt=$enableval], - [build_crypt=yes]) + [build_crypt=no]) AC_SUBST(build_crypt) AC_ARG_ENABLE([nss-crypt], diff --git a/manual/install.texi b/manual/install.texi index ae43dc51ac..db7a0346b2 100644 --- a/manual/install.texi +++ b/manual/install.texi @@ -256,12 +256,13 @@ configure with @option{--disable-werror}. By default for x86_64, @theglibc{} is built with the vector math library. Use this option to disable the vector math library. -@item --disable-crypt -Do not install the passphrase-hashing library @file{libcrypt} or the -header file @file{crypt.h}. @file{unistd.h} will still declare the -function @code{crypt}. Using this option does not change the set of -programs that may need to be linked with @option{-lcrypt}; it only -means that @theglibc{} will not provide that library. +@item --enable-crypt +Install the passphrase-hashing library @file{libcrypt} and the +header file @file{crypt.h}. @file{unistd.h} will declare the +function @code{crypt} regardless of this option. Using this option does +not change the set of programs that may need to be linked with +@option{-lcrypt}; it only means that @theglibc{} will not provide that +library. This option is for hackers and distributions experimenting with independently-maintained implementations of libcrypt. It may become