From patchwork Fri Jun 9 11:58:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Coufal X-Patchwork-Id: 1792932 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=KoHaihLU; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Qd03M5l3Kz20WP for ; Fri, 9 Jun 2023 21:58:39 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CAB243857009 for ; Fri, 9 Jun 2023 11:58:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CAB243857009 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1686311917; bh=gYdxEvWHtsTVOTeKGo85bD+XCPAzOOrfnMKbx+aSZno=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=KoHaihLUDQhKep8uT9XgsddrRi8+QFZcrOt/P7Xth+ekaWN8U8UOq10Kj+edbqhIE EvnJnwfLT2XjY7NvszN0wHPoQhqvho/QIyeELsNjFVvRBXN+sjq7X2f7bHlFLqiRc8 nms3286hV6aoKfcyvMO4lj213Nl4iGKJNVtFe6dI= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2A3D93856962 for ; Fri, 9 Jun 2023 11:58:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A3D93856962 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-466-4BAtociGNiKdWjJKCzUkYA-1; Fri, 09 Jun 2023 07:58:08 -0400 X-MC-Unique: 4BAtociGNiKdWjJKCzUkYA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8A3BE1C060CE for ; Fri, 9 Jun 2023 11:58:08 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.224.209]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 08B0B515541; Fri, 9 Jun 2023 11:58:07 +0000 (UTC) To: libc-alpha@sourceware.org Cc: Martin Coufal Subject: [PATCH] Remove unused DATEMSK file for tst-getdate Date: Fri, 9 Jun 2023 13:58:04 +0200 Message-Id: <20230609115804.116702-1-mcoufal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Martin Coufal via Libc-alpha From: Martin Coufal Reply-To: Martin Coufal Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" tst-getdate used to rely on an in-tree datemsk file that was subsequently replaced by a file created during test execution. This commit removes the unused file and corresponding env-var and uses a more appropriate name for the temp file. Reviewed-by: Carlos O'Donell --- time/Makefile | 1 - time/datemsk | 2 -- time/tst-getdate.c | 2 +- 3 files changed, 1 insertion(+), 4 deletions(-) delete mode 100644 time/datemsk diff --git a/time/Makefile b/time/Makefile index 92bc3db315..1d2e667cad 100644 --- a/time/Makefile +++ b/time/Makefile @@ -104,7 +104,6 @@ CFLAGS-mktime.c += $(config-cflags-wno-ignored-attributes) # Don't warn about Y2k problem in strftime format string. CFLAGS-test_time.c += -Wno-format -tst-getdate-ENV= DATEMSK=datemsk TZDIR=${common-objpfx}timezone/testdata test_time-ARGS= EST5EDT CST tst-tzname-ENV = TZDIR=${common-objpfx}timezone/testdata diff --git a/time/datemsk b/time/datemsk deleted file mode 100644 index 3dc4d417fe..0000000000 --- a/time/datemsk +++ /dev/null @@ -1,2 +0,0 @@ -%H:%M:%S %F -%d-%m-%Y %T diff --git a/time/tst-getdate.c b/time/tst-getdate.c index cf97e220f7..4c9ed28d58 100644 --- a/time/tst-getdate.c +++ b/time/tst-getdate.c @@ -98,7 +98,7 @@ static const char datemskstr[] = static void do_prepare (int argc, char **argv) { - int fd = create_temp_file ("tst-chk1.", &datemsk); + int fd = create_temp_file ("tst-getdate.", &datemsk); xwrite (fd, datemskstr, sizeof (datemskstr) - 1); setenv ("DATEMSK", datemsk, 1);