| Message ID | 20230601155919.296550-1-adhemerval.zanella@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | stdlib: Tune down fork arc4random tests | expand |
On 6/1/23 11:59, Adhemerval Zanella via Libc-alpha wrote: > There is no fork detection on current arc4random implementation, so > use lower subprocess on fork tests. The tests now run on 0.1s > instead of 8s on a Ryzen9 5900X. Agreed. LGTM. Reviewed-by: Carlos O'Donell <carlos@redhat.com> > Checked on x86_64-linux-gnu. > --- > stdlib/tst-arc4random-fork.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/stdlib/tst-arc4random-fork.c b/stdlib/tst-arc4random-fork.c > index a69ec3968f..65d5893f5e 100644 > --- a/stdlib/tst-arc4random-fork.c > +++ b/stdlib/tst-arc4random-fork.c > @@ -30,14 +30,10 @@ > #include <unistd.h> > > /* Perform multiple runs. The subsequent runs start with an > - already-initialized random number generator. (The number 1500 was > - seen to reproduce failures reliable in case of a race condition in > - the fork detection code.) */ > -enum { runs = 1500 }; > - > -/* One hundred processes in total. This should be high enough to > - expose any issues, but low enough not to tax the overall system too > - much. */ > + already-initialized random number generator. */ > +enum { runs = 10 }; > + > +/* Total number of spawned processes on each run. */ > enum { subprocesses = 49 }; OK. > > /* The total number of processes. */
On Thu, 2023-06-01 at 12:59 -0300, Adhemerval Zanella via Libc-alpha wrote: > There is no fork detection on current arc4random implementation, so > use lower subprocess on fork tests. The tests now run on 0.1s > instead of 8s on a Ryzen9 5900X. > > Checked on x86_64-linux-gnu. This also fixed the last (timeout) issue on the glibc-fedora-arm64 builder: https://builder.sourceware.org/buildbot/#/builders/glibc-fedora-arm64 Finally all green \o/ 4635 PASS 38 UNSUPPORTED 16 XFAIL Thanks, Mark
diff --git a/stdlib/tst-arc4random-fork.c b/stdlib/tst-arc4random-fork.c index a69ec3968f..65d5893f5e 100644 --- a/stdlib/tst-arc4random-fork.c +++ b/stdlib/tst-arc4random-fork.c @@ -30,14 +30,10 @@ #include <unistd.h> /* Perform multiple runs. The subsequent runs start with an - already-initialized random number generator. (The number 1500 was - seen to reproduce failures reliable in case of a race condition in - the fork detection code.) */ -enum { runs = 1500 }; - -/* One hundred processes in total. This should be high enough to - expose any issues, but low enough not to tax the overall system too - much. */ + already-initialized random number generator. */ +enum { runs = 10 }; + +/* Total number of spawned processes on each run. */ enum { subprocesses = 49 }; /* The total number of processes. */