From patchwork Fri Apr 14 19:36:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Bugaev X-Patchwork-Id: 1769175 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=swHbFYQx; dkim-atps=neutral Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Pymvt6h6xz1yXv for ; Sat, 15 Apr 2023 05:38:34 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E2CE03856969 for ; Fri, 14 Apr 2023 19:38:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E2CE03856969 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1681501112; bh=7SxeYFb+BoMfau5ehctR7QSthQ7j4PwQVvkBRLbtbgA=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=swHbFYQxCpJu737N2smpZ4iwzFLyTlUPNbquvDstoRN9V/sEVjtSmO2HqynhkdIsE HdLSAJzt6iB3R8zUu5BGKDnWV+OyA2BpMC68A/Z0ReiYrj1zkR82qwTwqsCQzDvqZB cUvL/fozBp7Xgs+Jq1igKmXGmqid0pU+mtZj/uXg= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by sourceware.org (Postfix) with ESMTPS id ED63A385842D for ; Fri, 14 Apr 2023 19:37:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED63A385842D Received: by mail-lj1-x22e.google.com with SMTP id h8so4148130ljf.3 for ; Fri, 14 Apr 2023 12:37:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681501062; x=1684093062; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7SxeYFb+BoMfau5ehctR7QSthQ7j4PwQVvkBRLbtbgA=; b=QVIRWGlxYRz59ufau/qj63XZCHRsAo3xyasZuZD/qaZFGpzFmd1GNshG1JgJUOiH3I pqOatLX5vaFKAkxBD8yTsQkweweyXAJH24F4NrmxLyZCbCTvOdXk2hplImRolCG0q4mA 45XjW7OSB96+XWm8Ry4rH88wA5XS3eJsHsVkqa/ugi5z6sXesfcx+oxOLQjeHMpineXn IaP9qhlNwSq6yPnED3QnF+qfL9RW3O6ZIZsokQdVgvngdJoDnsrhl14HuxDegx06RCB7 5J28jOLPTfvefPfDuSwQPuc5DwsFI4Xf74K8LE/j8BXX7miG5WY6Pvv11BB+YpAJg1uA PzRA== X-Gm-Message-State: AAQBX9euZdGddqekRp885MtpGpvfYQYhKAXtd01Ylrm0nTqq3YNHS85s PdK9XPjd6B6Zv2Fc0zDUkwJwBlj4zXZ58w== X-Google-Smtp-Source: AKy350bKIs7qoQoGkdiOHNBrVI6XWrMRyBI/Q9FLOx7+M3TPQdtrGAxoZkIyN84u4Y6Ppu099+j8DA== X-Received: by 2002:a2e:9ccb:0:b0:293:4c17:9998 with SMTP id g11-20020a2e9ccb000000b002934c179998mr2423032ljj.11.1681501062240; Fri, 14 Apr 2023 12:37:42 -0700 (PDT) Received: from localhost.localdomain ([2a02:2168:b344:a600:4435:f106:1598:d2b0]) by smtp.gmail.com with ESMTPSA id v8-20020a2e9608000000b002a8a5afb87csm735730ljh.20.2023.04.14.12.37.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Apr 2023 12:37:41 -0700 (PDT) To: libc-alpha@sourceware.org, bug-hurd@gnu.org Cc: Samuel Thibault , Sergey Bugaev Subject: [PATCH 4/5] hurd: Simplify _S_catch_exception_raise Date: Fri, 14 Apr 2023 22:36:59 +0300 Message-Id: <20230414193700.542116-4-bugaevc@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230414193700.542116-1-bugaevc@gmail.com> References: <20230414193700.542116-1-bugaevc@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Sergey Bugaev via Libc-alpha From: Sergey Bugaev Reply-To: Sergey Bugaev Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" _hurd_thread_sigstate () already handles finding an existing sigstate before allocating a new one, so just use that. Bonus: this will only lock the _hurd_siglock once. Signed-off-by: Sergey Bugaev --- hurd/catch-exc.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hurd/catch-exc.c b/hurd/catch-exc.c index 5ee2233a..d375bf67 100644 --- a/hurd/catch-exc.c +++ b/hurd/catch-exc.c @@ -58,13 +58,7 @@ _S_catch_exception_raise (mach_port_t port, _hurd_exception2signal (&d, &signo); /* Find the sigstate structure for the faulting thread. */ - __mutex_lock (&_hurd_siglock); - for (ss = _hurd_sigstates; ss != NULL; ss = ss->next) - if (ss->thread == thread) - break; - __mutex_unlock (&_hurd_siglock); - if (ss == NULL) - ss = _hurd_thread_sigstate (thread); /* Allocate a fresh one. */ + ss = _hurd_thread_sigstate (thread); if (__spin_lock_locked (&ss->lock)) {