| Message ID | 20230411221533.317235-1-samuel.thibault@ens-lyon.org |
|---|---|
| State | New |
| Headers | show |
| Series | aio: Fix freeing memory | expand |
On 11/04/23 19:15, Samuel Thibault wrote: > The content of the pool array is initialized only until pool_size, > pointers between pool_size and pool_max_size were not initialized by the > realloc call in get_elem so they should not be freed. > > This fixes aio tests crashing at their termination on GNU/Hurd. LGTM, thanks. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > --- > rt/aio_misc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rt/aio_misc.c b/rt/aio_misc.c > index 49ec0aa293..4b850b1ab6 100644 > --- a/rt/aio_misc.c > +++ b/rt/aio_misc.c > @@ -702,7 +702,7 @@ __aio_freemem (void) > { > size_t row; > > - for (row = 0; row < pool_max_size; ++row) > + for (row = 0; row < pool_size; ++row) > free (pool[row]); > > free (pool);
Adhemerval Zanella Netto, le mer. 12 avril 2023 09:39:00 -0300, a ecrit: > On 11/04/23 19:15, Samuel Thibault wrote: > > The content of the pool array is initialized only until pool_size, > > pointers between pool_size and pool_max_size were not initialized by the > > realloc call in get_elem so they should not be freed. > > > > This fixes aio tests crashing at their termination on GNU/Hurd. > > LGTM, thanks. > > Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> Pushed, thanks! Ah, only then I realize that I should have added your review tag, sorry! Samuel
diff --git a/rt/aio_misc.c b/rt/aio_misc.c index 49ec0aa293..4b850b1ab6 100644 --- a/rt/aio_misc.c +++ b/rt/aio_misc.c @@ -702,7 +702,7 @@ __aio_freemem (void) { size_t row; - for (row = 0; row < pool_max_size; ++row) + for (row = 0; row < pool_size; ++row) free (pool[row]); free (pool);