From patchwork Sun Feb 12 11:10:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Bugaev X-Patchwork-Id: 1741022 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=mS/J+maC; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PF4bc1w0Yz23hX for ; Sun, 12 Feb 2023 22:13:48 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3E57C3881D1A for ; Sun, 12 Feb 2023 11:13:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3E57C3881D1A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1676200426; bh=IGwtJsb1s4/DHhXvmuYmeFW8npbTdn3I1r4dOk3ONlU=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=mS/J+maCdIdnVx84VeNWPF4BzHwKSHTrigRqaBw8RMF2lVUgG+o3hiBlf4F17BBUm W7/70mtITV/BZngZA/3i61rQMyflaIlrLWze7F4I0G9ZBljJe+7WnLDBJAbOeGfJPB YFkL5UvzniClXjJ7gP6Ffwd9TZfG5dTEtFEQIPSg= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 7875A3858005 for ; Sun, 12 Feb 2023 11:11:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7875A3858005 Received: by mail-ed1-x532.google.com with SMTP id a10so9392521edu.9 for ; Sun, 12 Feb 2023 03:11:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IGwtJsb1s4/DHhXvmuYmeFW8npbTdn3I1r4dOk3ONlU=; b=H7vTGfzgJkesqfPzazsY+8E4f3bYfFQaEdBbDzrQIGd/2KfLXU3J+DjjSiOdL9ZwN6 4nyGZY8lT8XnPfe2uZ2OK4sUqWqoY/zMNqCb83z1pFs1lbdZxODhIPJ3FY2mriIWT0Kr khk2RB2ctIzSvMCQYr+1Qjb01T76oP+xK+iAw6TtOA57CQd7bN5ROovczuL/ZRWxw69h WF4BowDDUUQ+i2raWApidJ33ZZeFHYqM9NnXUXvn1nOW8rvADpwTw1uF56Zi9GW3wTbS GmGyG1zHUSYjMRUpwWOPGAnDkeT16w7KxzUI9KGPhDSheRb3BGqX2XI0V5POsqT//uhU 91rA== X-Gm-Message-State: AO0yUKWf8zd3l9s7wPtiubYxAnPXKqr5QJKEw7PZAGuBjZVJ9AmCWUFd OqXw7V30IbUl+vJViln4pjzsUUVKXBW2+Q== X-Google-Smtp-Source: AK7set91L1XfKHMWS+WCYyCuPgZNnRNLSc9x27ovj5Bgn0PcVNuYj10aLU7OwzngmYSEJt8WFtS3EA== X-Received: by 2002:a50:c05a:0:b0:49e:1f0e:e209 with SMTP id u26-20020a50c05a000000b0049e1f0ee209mr4096017edd.10.1676200281368; Sun, 12 Feb 2023 03:11:21 -0800 (PST) Received: from surface-pro-6.. ([2a00:1370:818c:4a57:2186:c463:9ced:e6fe]) by smtp.gmail.com with ESMTPSA id c61-20020a509fc3000000b004acbe0b36d2sm1266910edf.6.2023.02.12.03.11.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Feb 2023 03:11:21 -0800 (PST) To: bug-hurd@gnu.org, libc-alpha@sourceware.org Cc: =?utf-8?q?Fl=C3=A1vio_Cruz?= , Sergey Bugaev Subject: [RFC PATCH mig 8/12] Set max type alignment to sizeof(long) Date: Sun, 12 Feb 2023 14:10:39 +0300 Message-Id: <20230212111044.610942-9-bugaevc@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230212111044.610942-1-bugaevc@gmail.com> References: <20230212111044.610942-1-bugaevc@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Sergey Bugaev via Libc-alpha From: Sergey Bugaev Reply-To: Sergey Bugaev Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" ...not sizeof(int). This appears to be required on x86_64. PLEASE NOTE: There is now a patch from Flavio Cruz ("Make MIG work for pure 64 bit kernel and userland") that appears to tackle this same issue (and more). Most likely this simplistic patch should be dropped in favor of the one from Flavio. --- type.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/type.c b/type.c index b104c66..7765200 100644 --- a/type.c +++ b/type.c @@ -542,7 +542,7 @@ itLongDecl(u_int inname, const_string_t instr, u_int outname, it->itOutName = outname; it->itOutNameStr = outstr; it->itSize = size; - it->itAlignment = MIN(word_size, size / 8); + it->itAlignment = MIN(sizeof_long, size / 8); if (inname == MACH_MSG_TYPE_STRING_C) { it->itStruct = false;