From patchwork Thu Oct 20 02:13:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Noah Goldstein X-Patchwork-Id: 1692235 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=xoL8CLN2; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MtB5f2cPWz23kh for ; Thu, 20 Oct 2022 13:15:34 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5BFA3385E017 for ; Thu, 20 Oct 2022 02:15:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5BFA3385E017 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666232132; bh=amT6xlClalMmm83/+RxxajzINyHYZU0G9ejhALeOe0M=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=xoL8CLN29V4gw2cL8pxNq9Xqc/IFZG7AeB1GqWO54rebW0E+sM5HBsOjfC6SA3XDv BgxpuVuCYLHsIsbyCXNE/5zbNrnimD3GUwrte1k5uSvxavRSaEKPM/eOrDhcCYycQ4 7L69Ay4U1z4wPeGudjQev3mlMaKBYnTsKjI699I4= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com [IPv6:2001:4860:4864:20::2b]) by sourceware.org (Postfix) with ESMTPS id 55B7F3857376 for ; Thu, 20 Oct 2022 02:14:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 55B7F3857376 Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-1322fa1cf6fso22945684fac.6 for ; Wed, 19 Oct 2022 19:14:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=amT6xlClalMmm83/+RxxajzINyHYZU0G9ejhALeOe0M=; b=F3ij0uJ79ceQCaAG5t24gLHMUz+LQmYpZ2oCh8wLMF/TNdGzh03gsPiFhM81rCjwYO 3B0Rp7alZz5ZREc76lpJ1FWuNXrVm+EoiwAOkmDj5Ch6H2UNT1a3/ogkXnKu+8V9RXaT bZchusPiZFlf/ySLEXcKp7RKkPXaX50P7/FMkqDBER4/xhVHswKMTMy6sqD1J24juC2u 62r+omGBTDAxZaRzZqJMYL7tfuzHOBNENyTiKdN8+DXC5vyaJpupKL3q5EgE1hf10okd p5FpvasFRoI0wHG2u0tDGERk2hmLjrnhNFBgVWTfAgPy1ig2s6Ax+GcaLn99AdkRbYan bavg== X-Gm-Message-State: ACrzQf3rsQ5ChQdtfTJpu6nqDFmUaZKfbECX/12c2e65rKi4Y+eKMoTE C34rEDXzXeIhCabbRBKstbwPAMWFTfBjfA== X-Google-Smtp-Source: AMsMyM7BbQdG6Qc6l1cIaGfGRmMdGZRy8ib5F0eWj614a/kbB1KHnZncvpylb1Q9odI95rGMRtn9SA== X-Received: by 2002:a05:6870:c150:b0:13a:f5b4:55dc with SMTP id g16-20020a056870c15000b0013af5b455dcmr108524oad.295.1666232062195; Wed, 19 Oct 2022 19:14:22 -0700 (PDT) Received: from noah-tgl.lan (2603-8080-1301-76c6-bfae-083c-6dae-542c.res6.spectrum.com. [2603:8080:1301:76c6:bfae:83c:6dae:542c]) by smtp.gmail.com with ESMTPSA id q10-20020a056830440a00b00661a5ef58a0sm7843243otv.23.2022.10.19.19.14.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 19:14:21 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH v1 3/4] x86: Use `testb` for case-locale check in str{n}casecmp-sse42 Date: Wed, 19 Oct 2022 19:13:37 -0700 Message-Id: <20221020021338.3394281-3-goldstein.w.n@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221020021338.3394281-1-goldstein.w.n@gmail.com> References: <20221020021338.3394281-1-goldstein.w.n@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Noah Goldstein via Libc-alpha From: Noah Goldstein Reply-To: Noah Goldstein Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" `testb` saves a bit of code size is the imm-operand can be encoded 1-bytes. Tested on x86-64. --- sysdeps/x86_64/multiarch/strcmp-sse4_2.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sysdeps/x86_64/multiarch/strcmp-sse4_2.S b/sysdeps/x86_64/multiarch/strcmp-sse4_2.S index dc6fc90e14..6b540ff894 100644 --- a/sysdeps/x86_64/multiarch/strcmp-sse4_2.S +++ b/sysdeps/x86_64/multiarch/strcmp-sse4_2.S @@ -119,7 +119,7 @@ STRCMP: # else mov (%rdx), %RAX_LP # endif - testl $1, LOCALE_DATA_VALUES+_NL_CTYPE_NONASCII_CASE*SIZEOF_VALUES(%rax) + testb $1, LOCALE_DATA_VALUES+_NL_CTYPE_NONASCII_CASE*SIZEOF_VALUES(%rax) jne __strcasecmp_l_nonascii # endif # ifdef USE_AS_STRNCASECMP_L @@ -130,7 +130,7 @@ STRCMP: # else mov (%rcx), %RAX_LP # endif - testl $1, LOCALE_DATA_VALUES+_NL_CTYPE_NONASCII_CASE*SIZEOF_VALUES(%rax) + testb $1, LOCALE_DATA_VALUES+_NL_CTYPE_NONASCII_CASE*SIZEOF_VALUES(%rax) jne __strncasecmp_l_nonascii # endif