From patchwork Thu Jun 30 01:56:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Noah Goldstein X-Patchwork-Id: 1650432 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=Ch2/iglC; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LYLzd2ybMz9s07 for ; Thu, 30 Jun 2022 11:56:45 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B41DD386F425 for ; Thu, 30 Jun 2022 01:56:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B41DD386F425 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1656554202; bh=9FKiM4dEEUli6egim7GTIVJjnyQ0eo1ZyWLtH+pSTXI=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Ch2/iglCHgrgG9/2OJE4oDgYnz6pW1RH6qSkwrqF9trCkYnJ4rY8yFGlW7sE4tI7y vRmV++Kwd/pAkU/aUFUCQ+icGwMiFvdRH9h10pkOgkdR8yDbRtFm1qfivCh9yue9x4 LUntM0pdDpzZL3F18tHZqvFN0hkF3+056Npl99YE= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by sourceware.org (Postfix) with ESMTPS id 7E0A53846409 for ; Thu, 30 Jun 2022 01:56:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E0A53846409 Received: by mail-pj1-x102c.google.com with SMTP id dw10-20020a17090b094a00b001ed00a16eb4so1279399pjb.2 for ; Wed, 29 Jun 2022 18:56:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9FKiM4dEEUli6egim7GTIVJjnyQ0eo1ZyWLtH+pSTXI=; b=sgVhCYEd2MKr0xwl4n8kFUdNNointbnkN1LSRrXkMn+/hqAxaOg+0oVZQ+LnGBIe/B CmpEO1iGy1NsusaxDK37oA1qXIJKhA4XwuXdwfnXUbQmD2hGqs754j97CCcE4PJYnAgR 3qKzpZaWMoeGLG9ZYJlLFnKsTP4mCYu9HrlXsjYNdODCo+/+a6MzKDJGGLVg6iFhzboO DdEPG5+5sH3wGL3nieDgFu8NF2V25FVJwucpw4A9RaRH61FlaLgpjzGI3FXMRJ02Fs6y D6Ny6XOoHaTrOrccp2rXjZV+I4K7tItuS0l7XhdLDwJxmJpzwOta4yO/fy7OvhMl4kFl RENg== X-Gm-Message-State: AJIora/flOZAEOaRbeTFqiZOBrQRBPC3zQ4FnWW+urS/zuLOOSi6KJnh c1tBxNQah0OiFG5nb2RxP9L+CS9Ix7o= X-Google-Smtp-Source: AGRyM1tgcZqG9uPIGMbd4ZVoriQhL5fH20zdUUzju4bXJosyaw79K/iD88ZD69M/iidiRZjZVUr6WA== X-Received: by 2002:a17:902:db08:b0:16a:4b7e:af5f with SMTP id m8-20020a170902db0800b0016a4b7eaf5fmr13122918plx.143.1656554187517; Wed, 29 Jun 2022 18:56:27 -0700 (PDT) Received: from noah-tgl.. ([2600:1010:b00a:11cb:54c6:67b8:c3a4:f835]) by smtp.gmail.com with ESMTPSA id h15-20020a170902680f00b00161e50e2245sm11991259plk.178.2022.06.29.18.56.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 18:56:26 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH v1] x86: Add missing IS_IN (libc) check to strncmp-sse4_2.S Date: Wed, 29 Jun 2022 18:56:18 -0700 Message-Id: <20220630015618.3586787-3-goldstein.w.n@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220630015618.3586787-1-goldstein.w.n@gmail.com> References: <20220630015618.3586787-1-goldstein.w.n@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Noah Goldstein via Libc-alpha From: Noah Goldstein Reply-To: Noah Goldstein Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" Was missing to for the multiarch build rtld-strncmp-sse4_2.os was being built and exporting symbols: build/glibc/string/rtld-strncmp-sse4_2.os: 0000000000000000 T __strncmp_sse42 Introduced in: commit 11ffcacb64a939c10cfc713746b8ec88837f5c4a Author: H.J. Lu Date: Wed Jun 21 12:10:50 2017 -0700 x86-64: Implement strcmp family IFUNC selectors in C --- sysdeps/x86_64/multiarch/strncmp-sse4_2.S | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sysdeps/x86_64/multiarch/strncmp-sse4_2.S b/sysdeps/x86_64/multiarch/strncmp-sse4_2.S index 9773e5fc09..310a6dbe77 100644 --- a/sysdeps/x86_64/multiarch/strncmp-sse4_2.S +++ b/sysdeps/x86_64/multiarch/strncmp-sse4_2.S @@ -16,6 +16,8 @@ License along with the GNU C Library; if not, see . */ -#define STRCMP_SSE42 __strncmp_sse42 -#define USE_AS_STRNCMP -#include "strcmp-sse42.S" +#if IS_IN (libc) +# define STRCMP_SSE42 __strncmp_sse42 +# define USE_AS_STRNCMP +# include "strcmp-sse42.S" +#endif