diff mbox series

[2/2] localedata: Do not generate output if warnings were present.

Message ID 20220205025700.3728228-3-carlos@redhat.com
State New
Headers show
Series Improve LC_MONETARY handling. | expand

Commit Message

Carlos O'Donell Feb. 5, 2022, 2:57 a.m. UTC 
With LC_MONETARY parsing fixed we can now generate locales
without forcing output with '-c'.

Removing '-c' from localedef invocation is the equivalent of
using -Werror for localedef.  The glibc locale sources should
always be clean and free from warnings.

We remove '-c' from both test locale generation and the targets
used for installing locales e.g. install-locale-archive, and
install-locale-files.

Tested on x86_64 and i686 without regressions.
Tested with install-locale-archive target.
Tested with install-locale-files target.
---
 localedata/Makefile      |  3 +--
 localedata/gen-locale.sh | 10 ++++++++--
 2 files changed, 9 insertions(+), 4 deletions(-)

Comments

Andreas Schwab Feb. 17, 2022, 2:52 p.m. UTC | #1 
On Feb 04 2022, Carlos O'Donell via Libc-alpha wrote:

> With LC_MONETARY parsing fixed we can now generate locales
> without forcing output with '-c'.
>
> Removing '-c' from localedef invocation is the equivalent of
> using -Werror for localedef.  The glibc locale sources should
> always be clean and free from warnings.
>
> We remove '-c' from both test locale generation and the targets
> used for installing locales e.g. install-locale-archive, and
> install-locale-files.
>
> Tested on x86_64 and i686 without regressions.
> Tested with install-locale-archive target.
> Tested with install-locale-files target.

Ok.
diff mbox series

Patch

diff --git a/localedata/Makefile b/localedata/Makefile
index 9ae2e5c161..45acfde237 100644
--- a/localedata/Makefile
+++ b/localedata/Makefile
@@ -468,11 +468,10 @@  define build-one-locale
 endef
 
 $(INSTALL-SUPPORTED-LOCALE-ARCHIVE): install-locales-dir
-	@flags="-c"; \
 	$(build-one-locale)
 
 $(INSTALL-SUPPORTED-LOCALE-FILES): install-locales-dir
-	@flags="-c --no-archive --no-hard-links"; \
+	@flags="--no-archive --no-hard-links"; \
 	$(build-one-locale)
 
 tst-setlocale-ENV = LC_ALL=ja_JP.EUC-JP
diff --git a/localedata/gen-locale.sh b/localedata/gen-locale.sh
index 7fce35f212..8053c816a6 100644
--- a/localedata/gen-locale.sh
+++ b/localedata/gen-locale.sh
@@ -54,8 +54,14 @@  modifier=`echo $locfile|sed 's|[^.]*[.]\([^@ ]*\)\(@[^ ]*\)\?/LC_CTYPE|\2|'`
 
 echo "Generating locale $locale.$charmap: this might take a while..."
 
-# Run quietly and force output.
-flags="--quiet -c"
+# Do not force output with '-c', all locales should compile without
+# warning or errors.  There is likewise no need to run quietly with
+# '--quiet' since all locales should compile without additional
+# diagnostics.  If there are messages printed then we want to see
+# them, fix them, and the associated error or warning.  During
+# development it may be beneficialy to put '--quiet -c' here to allow
+# you to develop in-progress locales.
+flags=""
 
 # For SJIS the charmap is SHIFT_JIS. We just want the locale to have
 # a slightly nicer name instead of using "*.SHIFT_SJIS", but that