diff mbox series

Fix elf/tst-audit25a with default bind now toolchains

Message ID 20220202140834.2619244-1-szabolcs.nagy@arm.com
State New
Headers show
Series Fix elf/tst-audit25a with default bind now toolchains | expand

Commit Message

Szabolcs Nagy Feb. 2, 2022, 2:08 p.m. UTC 
This test relies on lazy binding for the executable so request that
explicitly in case the toolchain defaults to bind now.
---
 elf/Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

Florian Weimer Feb. 2, 2022, 2:20 p.m. UTC | #1 
* Szabolcs Nagy via Libc-alpha:

> This test relies on lazy binding for the executable so request that
> explicitly in case the toolchain defaults to bind now.
> ---
>  elf/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/elf/Makefile b/elf/Makefile
> index e380b26d8a..5bdf0a383d 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -2227,6 +2227,7 @@ $(objpfx)tst-audit25a: $(objpfx)tst-audit25mod1.so \
>  		       $(objpfx)tst-audit25mod2.so \
>  		       $(objpfx)tst-audit25mod3.so \
>  		       $(objpfx)tst-audit25mod4.so
> +LDFLAGS-tst-audit25a = -Wl,-z,lazy
>  $(objpfx)tst-audit25mod1.so: $(objpfx)tst-audit25mod3.so
>  LDFLAGS-tst-audit25mod1.so = -Wl,-z,now
>  $(objpfx)tst-audit25mod2.so: $(objpfx)tst-audit25mod4.so

Looks okay.  Probably needs RM approval.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian
Carlos O'Donell Feb. 2, 2022, 3:09 p.m. UTC | #2 
On 2/2/22 09:20, Florian Weimer wrote:
> * Szabolcs Nagy via Libc-alpha:
> 
>> This test relies on lazy binding for the executable so request that
>> explicitly in case the toolchain defaults to bind now.
>> ---
>>  elf/Makefile | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/elf/Makefile b/elf/Makefile
>> index e380b26d8a..5bdf0a383d 100644
>> --- a/elf/Makefile
>> +++ b/elf/Makefile
>> @@ -2227,6 +2227,7 @@ $(objpfx)tst-audit25a: $(objpfx)tst-audit25mod1.so \
>>  		       $(objpfx)tst-audit25mod2.so \
>>  		       $(objpfx)tst-audit25mod3.so \
>>  		       $(objpfx)tst-audit25mod4.so
>> +LDFLAGS-tst-audit25a = -Wl,-z,lazy
>>  $(objpfx)tst-audit25mod1.so: $(objpfx)tst-audit25mod3.so
>>  LDFLAGS-tst-audit25mod1.so = -Wl,-z,now
>>  $(objpfx)tst-audit25mod2.so: $(objpfx)tst-audit25mod4.so
> 
> Looks okay.  Probably needs RM approval.
> 
> Reviewed-by: Florian Weimer <fweimer@redhat.com>

ACK for 2.35. Please push.
diff mbox series

Patch

diff --git a/elf/Makefile b/elf/Makefile
index e380b26d8a..5bdf0a383d 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -2227,6 +2227,7 @@  $(objpfx)tst-audit25a: $(objpfx)tst-audit25mod1.so \
 		       $(objpfx)tst-audit25mod2.so \
 		       $(objpfx)tst-audit25mod3.so \
 		       $(objpfx)tst-audit25mod4.so
+LDFLAGS-tst-audit25a = -Wl,-z,lazy
 $(objpfx)tst-audit25mod1.so: $(objpfx)tst-audit25mod3.so
 LDFLAGS-tst-audit25mod1.so = -Wl,-z,now
 $(objpfx)tst-audit25mod2.so: $(objpfx)tst-audit25mod4.so