diff mbox series

tests: Remove NULL check for an array

Message ID 20201111172913.890166-1-siddhesh@sourceware.org
State New
Headers show
Series tests: Remove NULL check for an array | expand

Commit Message

Siddhesh Poyarekar Nov. 11, 2020, 5:29 p.m. UTC 
The NULL check for an array on stack is pointless since it will always
be false, so drop it.
---

This is fairly obvious, so I'll commit it in a day if nobody objects.

Siddhesh

 stdio-common/scanf14.c | 2 --
 stdio-common/scanf15.c | 2 --
 stdio-common/scanf16.c | 2 --
 stdio-common/scanf17.c | 2 --
 4 files changed, 8 deletions(-)

Comments

Siddhesh Poyarekar Nov. 12, 2020, 8:01 a.m. UTC | #1 
On 11/11/20 10:59 PM, Siddhesh Poyarekar via Libc-alpha wrote:
> The NULL check for an array on stack is pointless since it will always
> be false, so drop it.
> ---
> 
> This is fairly obvious, so I'll commit it in a day if nobody objects.

Committed now.

Siddhesh
diff mbox series

Patch

diff --git a/stdio-common/scanf14.c b/stdio-common/scanf14.c
index f92838edd2..4c2feea7ba 100644
--- a/stdio-common/scanf14.c
+++ b/stdio-common/scanf14.c
@@ -86,8 +86,6 @@  main (void)
 
   char fname[strlen (tmpdir) + sizeof "/tst-scanf14.XXXXXX"];
   sprintf (fname, "%s/tst-scanf14.XXXXXX", tmpdir);
-  if (fname == NULL)
-    FAIL ();
 
   /* Create a temporary file.   */
   int fd = mkstemp (fname);
diff --git a/stdio-common/scanf15.c b/stdio-common/scanf15.c
index a937815b14..6e4980c2e1 100644
--- a/stdio-common/scanf15.c
+++ b/stdio-common/scanf15.c
@@ -69,8 +69,6 @@  main (void)
 
   char fname[strlen (tmpdir) + sizeof "/tst-scanf15.XXXXXX"];
   sprintf (fname, "%s/tst-scanf15.XXXXXX", tmpdir);
-  if (fname == NULL)
-    FAIL ();
 
   /* Create a temporary file.   */
   int fd = mkstemp (fname);
diff --git a/stdio-common/scanf16.c b/stdio-common/scanf16.c
index b4ba3e6fe3..073a77efbe 100644
--- a/stdio-common/scanf16.c
+++ b/stdio-common/scanf16.c
@@ -117,8 +117,6 @@  main (void)
 
   char fname[strlen (tmpdir) + sizeof "/tst-scanf16.XXXXXX"];
   sprintf (fname, "%s/tst-scanf16.XXXXXX", tmpdir);
-  if (fname == NULL)
-    FAIL ();
 
   /* Create a temporary file.   */
   int fd = mkstemp (fname);
diff --git a/stdio-common/scanf17.c b/stdio-common/scanf17.c
index 428f22e45c..3224573733 100644
--- a/stdio-common/scanf17.c
+++ b/stdio-common/scanf17.c
@@ -100,8 +100,6 @@  main (void)
 
   char fname[strlen (tmpdir) + sizeof "/tst-scanf17.XXXXXX"];
   sprintf (fname, "%s/tst-scanf17.XXXXXX", tmpdir);
-  if (fname == NULL)
-    FAIL ();
 
   /* Create a temporary file.   */
   int fd = mkstemp (fname);