From patchwork Mon Jul 22 20:45:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tulio Magno Quites Machado Filho X-Patchwork-Id: 1135268 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-103886-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="kidKfCwo"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45sttH4tYBz9s7T for ; Tue, 23 Jul 2019 06:45:59 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=srPSDn6an7tn/ElwLiXNtNZwHoeGC+J rQMyXylv7l7nb6KF/Q9SM1WY9MHq+rs2hYBlS6ilK93sArbsUeJXU/NdGQUeI0Rp 7FhTYs7i6wV4v4b9iDZCH/5zT0UJ41zJbgiD21RPJkj65rBHKWBIByml0pDc3KM9 xj7LGJIBgfwA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=zVFzAVIhTZ4FRBtsP9njLmJhBNQ=; b=kidKf Cwo6I6z/hiQmrBOaKwdHjmPLEbAcDENOgJ0a3zsHjfpUZzMIXsLK045YCUn1kF96 wLwpgzIEYU4MR4WFSViWMninjFeQEGkyNmjyarZ13vwVgM5Wy8e19aqAffn9u2x1 5HoEqi0JPH3PIarILfr8aic1u2h4BD1B7RtHTg= Received: (qmail 59069 invoked by alias); 22 Jul 2019 20:45:53 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 58774 invoked by uid 89); 22 Jul 2019 20:45:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-27.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.1 spammy=installation X-HELO: mx0a-001b2d01.pphosted.com From: Tulio Magno Quites Machado Filho To: Florian Weimer , DJ Delorie , libc-alpha@sourceware.org Subject: [PATCH] test-container: Install with $(all-subdirs) [BZ #24794] Date: Mon, 22 Jul 2019 17:45:33 -0300 Message-Id: <20190722204533.21535-1-tuliom@linux.ibm.com> In-Reply-To: <87k1cekzr9.fsf@oldenburg2.str.redhat.com> References: <87k1cekzr9.fsf@oldenburg2.str.redhat.com> Whenever a sub-make is created, it inherits the variable subdirs from its parent. This is also true when make check is called with a restricted list of subdirs. In this scenario, make install is executed "partially" and testroot.pristine ends up with an incomplete installation. 2019-07-22 Tulio Magno Quites Machado Filho [BZ #24794] * Makefile (testroot.pristine/install.stamp): Pass subdirs='$(all-subdirs)' to make install. --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index a4ed747cef..9fbf705200 100644 --- a/Makefile +++ b/Makefile @@ -401,7 +401,8 @@ ifeq ($(run-built-tests),yes) $(test-wrapper) cp $$dso $(objpfx)testroot.pristine$$dso ;\ done endif - $(MAKE) install DESTDIR=$(objpfx)testroot.pristine + $(MAKE) install DESTDIR=$(objpfx)testroot.pristine \ + subdirs='$(all-subdirs)' touch $(objpfx)testroot.pristine/install.stamp tests-special-notdir = $(patsubst $(objpfx)%, %, $(tests-special))