| Message ID | 20180807235606.26019-1-samuel.thibault@ens-lyon.org |
|---|---|
| State | New |
| Headers | show |
| Series | [hurd,commited] hurd: Add missing symbols for proper libc_get/setspecific | expand |
Hello, The issue fixed here could pose subtle problems with libdl, so I have backported the commit to the stable branch. Samuel Samuel Thibault, le mer. 08 août 2018 01:56:06 +0200, a ecrit: > * htl/Versions (__pthread_getspecific, __pthread_setspecific): Add > symbols. > --- > ChangeLog | 5 +++++ > htl/Versions | 2 ++ > 2 files changed, 7 insertions(+) > > diff --git a/ChangeLog b/ChangeLog > index 7e1a5b081f..556669a4aa 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2018-08-08 Samuel Thibault <samuel.thibault@ens-lyon.org> > + > + * htl/Versions (__pthread_getspecific, __pthread_setspecific): Add > + symbols. > + > 2018-08-07 Siddhesh Poyarekar <siddhesh@sourceware.org> > > * benchtests/bench-string.h (buf1_size, buf2_size): New > diff --git a/htl/Versions b/htl/Versions > index 6a63a1b8a1..c5a616da10 100644 > --- a/htl/Versions > +++ b/htl/Versions > @@ -150,6 +150,8 @@ libpthread { > __cthread_keycreate; > __cthread_getspecific; > __cthread_setspecific; > + __pthread_getspecific; > + __pthread_setspecific; > __pthread_getattr_np; > __pthread_attr_getstack; > } > -- > 2.18.0 >
On 08/08/2018 01:56 AM, Samuel Thibault wrote: > * htl/Versions (__pthread_getspecific, __pthread_setspecific): Add > symbols. > --- > ChangeLog | 5 +++++ > htl/Versions | 2 ++ > 2 files changed, 7 insertions(+) > > diff --git a/ChangeLog b/ChangeLog > index 7e1a5b081f..556669a4aa 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2018-08-08 Samuel Thibault <samuel.thibault@ens-lyon.org> > + > + * htl/Versions (__pthread_getspecific, __pthread_setspecific): Add > + symbols. > + > 2018-08-07 Siddhesh Poyarekar <siddhesh@sourceware.org> > > * benchtests/bench-string.h (buf1_size, buf2_size): New > diff --git a/htl/Versions b/htl/Versions > index 6a63a1b8a1..c5a616da10 100644 > --- a/htl/Versions > +++ b/htl/Versions > @@ -150,6 +150,8 @@ libpthread { > __cthread_keycreate; > __cthread_getspecific; > __cthread_setspecific; > + __pthread_getspecific; > + __pthread_setspecific; > __pthread_getattr_np; > __pthread_attr_getstack; > } I believe this caused elf/check-localplt to fail with: Extra PLT reference: libpthread.so: __pthread_getspecific Extra PLT reference: libpthread.so: __pthread_setspecific (Seen with binutils 2.27.) Thanks, Florian
Florian Weimer, le mer. 08 août 2018 16:56:28 +0200, a ecrit: > I believe this caused elf/check-localplt to fail with: > > Extra PLT reference: libpthread.so: __pthread_getspecific > Extra PLT reference: libpthread.so: __pthread_setspecific Ah, right, my test environment wasn't catching these. Thanks, Samuel
diff --git a/ChangeLog b/ChangeLog index 7e1a5b081f..556669a4aa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2018-08-08 Samuel Thibault <samuel.thibault@ens-lyon.org> + + * htl/Versions (__pthread_getspecific, __pthread_setspecific): Add + symbols. + 2018-08-07 Siddhesh Poyarekar <siddhesh@sourceware.org> * benchtests/bench-string.h (buf1_size, buf2_size): New diff --git a/htl/Versions b/htl/Versions index 6a63a1b8a1..c5a616da10 100644 --- a/htl/Versions +++ b/htl/Versions @@ -150,6 +150,8 @@ libpthread { __cthread_keycreate; __cthread_getspecific; __cthread_setspecific; + __pthread_getspecific; + __pthread_setspecific; __pthread_getattr_np; __pthread_attr_getstack; }