diff mbox series

[hurd,commited] hurd: fix conformity test for sys/un.h

Message ID 20180417235806.13479-1-samuel.thibault@ens-lyon.org
State New
Headers show
Series [hurd,commited] hurd: fix conformity test for sys/un.h | expand

Commit Message

Samuel Thibault April 17, 2018, 11:58 p.m. UTC 
sun_len is used by BSD systems, and conformant.

	* conform/data/sys/un.h-data (struct sockaddr_un): Allow sun_len
	member.
---
 ChangeLog                  | 5 +++++
 conform/data/sys/un.h-data | 1 +
 2 files changed, 6 insertions(+)

Comments

Joseph Myers April 18, 2018, 11:15 a.m. UTC | #1 
On Wed, 18 Apr 2018, Samuel Thibault wrote:

> sun_len is used by BSD systems, and conformant.
> 
> 	* conform/data/sys/un.h-data (struct sockaddr_un): Allow sun_len
> 	member.

This is not correct.  optional-* is used when the relevant standards have 
a specification for a symbol, but do not require it to be defined.  In 
this case, the standards do not have a specification for sun_len - they 
have a permission to define arbitrary sun_* symbols, for which "allow 
sun_*" is the appropriate representation.
diff mbox series

Patch

diff --git a/ChangeLog b/ChangeLog
index 381a2ea2b7..cde575fbb1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@ 
+2018-04-18  Samuel Thibault  <samuel.thibault@ens-lyon.org>
+
+	* conform/data/sys/un.h-data (struct sockaddr_un): Allow sun_len
+	member.
+
 2018-04-16  Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 
 	* sysdeps/arm/armv6t2/memchr.S (memchr): Remove ARM code path.
diff --git a/conform/data/sys/un.h-data b/conform/data/sys/un.h-data
index 1068440042..4e00742b9e 100644
--- a/conform/data/sys/un.h-data
+++ b/conform/data/sys/un.h-data
@@ -1,6 +1,7 @@ 
 #if !defined ISO && !defined ISO99 && !defined ISO11 && !defined POSIX && !defined XPG4
 type {struct sockaddr_un}
 
+optional-element {struct sockaddr_un} {unsigned char} sun_len
 element {struct sockaddr_un} sa_family_t sun_family
 element {struct sockaddr_un} char sun_path []