From patchwork Sun Feb 18 02:00:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 874839 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-90342-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="QFEqZ/qW"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zkVTz1vHyz9sWJ for ; Sun, 18 Feb 2018 13:01:11 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id; q=dns; s= default; b=WtGPQXsrdj+HTct29s70DXmSuAnU9Qmptmd867T4+4byOHWyc0f9Y pAB1nonY5XtAfVs+j5TcrpRSRF6eVdsCAPKbfctXSe0+b8XMXEmakJe2Y2+3lQVX zeNgZ2ckMj42AOxy2caxAwGO2c2ZqU6D5l7Qi4adbGLXdwYvWV2fvg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id; s=default; bh=08A9LKSW+MZHGfnhQGIwgYBhDwA=; b=QFEqZ/qWlmqgyfrufYoqJJcwp9WE S23sxKsAtu8J0pMheS5ItTqU+KYaOK2aUBCnJzpLyQr8RTMyzJ7mhJoJ5Lksjy6a m3z0tZLddqZuOEXmdKTPTHaTbiZotPqyufEZArOLM4n+6KGjjoEOwV7XHmIMSBZX Vk0q82k1VGlDhok= Received: (qmail 84044 invoked by alias); 18 Feb 2018 02:01:04 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 70893 invoked by uid 89); 18 Feb 2018 02:00:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, SPF_HELO_PASS, SPF_NEUTRAL autolearn=ham version=3.3.2 spammy= X-HELO: hera.aquilenet.fr From: Samuel Thibault To: libc-alpha@sourceware.org Cc: Samuel Thibault Subject: [PATCH] Move NPTL-specific code to NPTL-specific header Date: Sun, 18 Feb 2018 03:00:50 +0100 Message-Id: <20180218020050.26334-1-samuel.thibault@ens-lyon.org> * sysdeps/pthread/timer_routines.c: Include instead of (thread_attr_compare): Move function to... * sysdeps/nptl/timer_routines.h: ... new header. --- ChangeLog | 4 ++++ sysdeps/nptl/timer_routines.h | 51 ++++++++++++++++++++++++++++++++++++++++ sysdeps/pthread/timer_routines.c | 27 +-------------------- 3 files changed, 56 insertions(+), 26 deletions(-) create mode 100644 sysdeps/nptl/timer_routines.h diff --git a/ChangeLog b/ChangeLog index 4e8411f9bf..158d4f2474 100644 --- a/ChangeLog +++ b/ChangeLog @@ -7,6 +7,10 @@ (__ptsname_r): Move implementation to... (__ptsname_internal): ... new function. Add filling the STP structure. + * sysdeps/pthread/timer_routines.c: Include instead + of + (thread_attr_compare): Move function to... + * sysdeps/nptl/timer_routines.h: ... new header. 2018-02-17 John David Anglin diff --git a/sysdeps/nptl/timer_routines.h b/sysdeps/nptl/timer_routines.h new file mode 100644 index 0000000000..9931015684 --- /dev/null +++ b/sysdeps/nptl/timer_routines.h @@ -0,0 +1,51 @@ +/* Helper code for POSIX timer implementation on NPTL. + Copyright (C) 2000-2018 Free Software Foundation, Inc. + This file is part of the GNU C Library. + Contributed by Kaz Kylheku . + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public License as + published by the Free Software Foundation; either version 2.1 of the + License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; see the file COPYING.LIB. If + not, see . */ + +#ifndef _TIMER_ROUTINES_H +#define _TIMER_ROUTINES_H 1 + +#include +#include + +/* Compare two pthread_attr_t thread attributes for exact equality. + Returns 1 if they are equal, otherwise zero if they are not equal + or contain illegal values. This version is NPTL-specific for + performance reason. One could use the access functions to get the + values of all the fields of the attribute structure. */ +static inline int +thread_attr_compare (const pthread_attr_t *left, const pthread_attr_t *right) +{ + struct pthread_attr *ileft = (struct pthread_attr *) left; + struct pthread_attr *iright = (struct pthread_attr *) right; + + return (ileft->flags == iright->flags + && ileft->schedpolicy == iright->schedpolicy + && (ileft->schedparam.sched_priority + == iright->schedparam.sched_priority) + && ileft->guardsize == iright->guardsize + && ileft->stackaddr == iright->stackaddr + && ileft->stacksize == iright->stacksize + && ((ileft->cpuset == NULL && iright->cpuset == NULL) + || (ileft->cpuset != NULL && iright->cpuset != NULL + && ileft->cpusetsize == iright->cpusetsize + && memcmp (ileft->cpuset, iright->cpuset, + ileft->cpusetsize) == 0))); +} + +#endif /* timer_routines.h */ diff --git a/sysdeps/pthread/timer_routines.c b/sysdeps/pthread/timer_routines.c index f059beb4c5..84861b9557 100644 --- a/sysdeps/pthread/timer_routines.c +++ b/sysdeps/pthread/timer_routines.c @@ -29,7 +29,7 @@ #include #include "posix-timer.h" -#include +#include /* Number of threads used. */ @@ -482,31 +482,6 @@ __timer_thread_wakeup (struct thread_node *thread) } -/* Compare two pthread_attr_t thread attributes for exact equality. - Returns 1 if they are equal, otherwise zero if they are not equal - or contain illegal values. This version is NPTL-specific for - performance reason. One could use the access functions to get the - values of all the fields of the attribute structure. */ -static int -thread_attr_compare (const pthread_attr_t *left, const pthread_attr_t *right) -{ - struct pthread_attr *ileft = (struct pthread_attr *) left; - struct pthread_attr *iright = (struct pthread_attr *) right; - - return (ileft->flags == iright->flags - && ileft->schedpolicy == iright->schedpolicy - && (ileft->schedparam.sched_priority - == iright->schedparam.sched_priority) - && ileft->guardsize == iright->guardsize - && ileft->stackaddr == iright->stackaddr - && ileft->stacksize == iright->stacksize - && ((ileft->cpuset == NULL && iright->cpuset == NULL) - || (ileft->cpuset != NULL && iright->cpuset != NULL - && ileft->cpusetsize == iright->cpusetsize - && memcmp (ileft->cpuset, iright->cpuset, - ileft->cpusetsize) == 0))); -} - /* Search the list of active threads and find one which has matching attributes. Global mutex lock must be held by caller. */