From patchwork Sat Apr 2 10:57:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 605402 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qcZvv4YlXz9sRZ for ; Sat, 2 Apr 2016 21:57:31 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b=MdMq2RgB; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id :mime-version:content-type; q=dns; s=default; b=a9EFnTrQ4HIhOdSt RjoqlNEGu+cVcYTQRsgaPA/7Om0OF6EmGfyy6D6eKHxtrAlB2EVSzYDOPBtwduQM WbJ69CMyah3g5HOVkVhB664em54o0iXQiS6AzG0GAUShxbuPW7cnZZew0TU6QDfb uDsF5+SmK6cjlsqfvQqQuhQJ8fo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id :mime-version:content-type; s=default; bh=6stE3zejCADpz62aVUF7Nx 2xqMQ=; b=MdMq2RgBwCk9G5VKH+K8onJQMZxOCvgJbkLMGGXnWDP0PcHmVyoeaF xKr47cLoPfALiHxQm0SctC7BaBSLqgj11UWKT85tiQXas8fyrdriUxcBpYDdPTah vfsxkugF8rNGLItIS6PC5UgMWZO1Me25hdmIK+02B/OL0HQ2C6gBg= Received: (qmail 14770 invoked by alias); 2 Apr 2016 10:57:22 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 14754 invoked by uid 89); 2 Apr 2016 10:57:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sonata.ens-lyon.org Date: Sat, 2 Apr 2016 12:57:16 +0200 From: Samuel Thibault To: GNU C Library Cc: bug-hurd@gnu.org Subject: [PATCH] getauxval: fix crash on systems without HAVE_AUX_VECTOR Message-ID: <20160402105716.GA10998@var.jdll.illyse.net> Mail-Followup-To: GNU C Library , bug-hurd@gnu.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Systems without HAVE_AUX_VECTOR have GLRO(dl_auxv) == NULL, and getauxval would thus crash. * misc/getauxval.c (__getauxval): Check for GLRO(dl_auxv) != NULL before looping through the list. diff --git a/misc/getauxval.c b/misc/getauxval.c index e48f40f..7ba0598 100644 --- a/misc/getauxval.c +++ b/misc/getauxval.c @@ -30,9 +30,10 @@ __getauxval (unsigned long int type) else if (type == AT_HWCAP2) return GLRO(dl_hwcap2); - for (p = GLRO(dl_auxv); p->a_type != AT_NULL; p++) - if (p->a_type == type) - return p->a_un.a_val; + if (GLRO(dl_auxv) != NULL) + for (p = GLRO(dl_auxv); p->a_type != AT_NULL; p++) + if (p->a_type == type) + return p->a_un.a_val; __set_errno (ENOENT); return 0;