From patchwork Fri Aug 14 10:33:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 507340 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 878761401E7 for ; Fri, 14 Aug 2015 20:33:44 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b=vryTbBl/; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id :mime-version:content-type; q=dns; s=default; b=wTObtwcjXk1yHm5B QkC6bYpdNQfaYn2CQ1a0o7g3aGdORxoQ1ghgK7HVtyvrt61kTHti5NcvFYXuV768 Kwr8afPZO6Ry3g79xkhyco7JmSVWFVJT4jlxl5To6QZgTVgqfi/9fQfPDUrC1hNH x92ydblbgNTGShTxMaz/OaUom1Y= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id :mime-version:content-type; s=default; bh=SoRq7VuRvXX9JtJnLRVogN YuTIs=; b=vryTbBl/zL8JT9GEIzBbA/rEOmojuIbXbWa6iEpJslI9kZioRoEDcI iwtUh4bf9lMqBRUTQHgeVr4p8052EkbY5cydffAhF629groFITBxrYYwGrUKUAga VYzCoayrsyMYSRSaVoh88BQgypNRg4Z6nrkKj5BOUNHBBiY73+21g= Received: (qmail 65155 invoked by alias); 14 Aug 2015 10:33:38 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 65145 invoked by uid 89); 14 Aug 2015 10:33:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL, BAYES_40, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Date: Fri, 14 Aug 2015 16:03:30 +0530 From: Siddhesh Poyarekar To: libc-alpha@sourceware.org Cc: hjl.tools@gmail.com Subject: [PATCH] Remove incorrect register mov in floorf on x86_64 Message-ID: <20150814103330.GA15748@spoyarek.pnq.redhat.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) The change in 0b5395f052ee09cd7e3d219af4e805c38058afb5 replaced calls to __get_cpu_features@plt followed by a mov from rax to rdx, with a single macro LOAD_RTLD_GLOBAL_RO_RDX. It is pretty clear that there was a typo in s_floorf due to which the (now incorrect) mov was not removed. This patch removes that mov. Siddhesh * sysdeps/x86_64/fpu/multiarch/s_floorf.S (__floorf): Remove unnecessary movq. --- sysdeps/x86_64/fpu/multiarch/s_floorf.S | 1 - 1 file changed, 1 deletion(-) diff --git a/sysdeps/x86_64/fpu/multiarch/s_floorf.S b/sysdeps/x86_64/fpu/multiarch/s_floorf.S index f60f662..9d67847 100644 --- a/sysdeps/x86_64/fpu/multiarch/s_floorf.S +++ b/sysdeps/x86_64/fpu/multiarch/s_floorf.S @@ -23,7 +23,6 @@ ENTRY(__floorf) .type __floorf, @gnu_indirect_function LOAD_RTLD_GLOBAL_RO_RDX - movq %rax, %rdx leaq __floorf_sse41(%rip), %rax HAS_CPU_FEATURE (SSE4_1) jnz 2f