From patchwork Thu Jan 22 08:05:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 431696 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 79EAA140216 for ; Thu, 22 Jan 2015 19:06:15 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id :mime-version:content-type:content-transfer-encoding; q=dns; s= default; b=vK681P0Cooiw4TCnDRS3/of3EYqZbA0Q7GRVwEV6VA1DOAAkeQO/R yq+SPD8SXWIwRNd9gkGC5xDFfb6NAl07bTzLoYp/i9l1TGYmRDj0vsVjVn2eeoLV stC/0h1ucFHrTxrbndNU1EKEl1k7VRIzUf1FLZ7lw1+nEebyOVgV7w= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id :mime-version:content-type:content-transfer-encoding; s=default; bh=5mOiOWsKxROW0XETDqxcsUlI+QM=; b=jTVQwGlLsMPdg5DxebvEZx0HByoR WzHBCMBFL+CJ5fBVowVnEnhueJqOHz1FjlvCyWwAdsiMYXdf2/95zL7Jl/+6wAV6 i2ckkpVjPxB0wx345XFlz8OOl8Rt57SDpcUQQZMD/1c5wtR+wqypUu7VAPdm+18p Y/GmMjTHWWMTcN4= Received: (qmail 29070 invoked by alias); 22 Jan 2015 08:06:07 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 29044 invoked by uid 89); 22 Jan 2015 08:06:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Date: Thu, 22 Jan 2015 13:35:57 +0530 From: Siddhesh Poyarekar To: libc-alpha@sourceware.org Cc: carlos@redhat.com Subject: [PATCH] Export __vdso_clock_gettime as GLIBC_PRIVATE Message-ID: <20150122133557.515f55dd@redhat.com> MIME-Version: 1.0 Hi, We added vDSO support for time functions on i386 recently, but the __vdso_clock_gettime symbol was kept as an internal symbol. This is fine for glibc as is, but it breaks Fedora builds since rtkaio now needs access to __vdso_clock_gettime. I could maintain a patch in Fedora that exports this symbol as GLIBC_PRIVATE, but I reckon that it might be more consistent to put it upstream since all of the architectures that have vDSO time support export the symbol in GLIBC_PRIVATE already. Tested on i386 to verify that the build completes successfully. OK to commit? Siddhesh * sysdeps/unix/sysv/linux/i386/Versions (GLIBC_PRIVATE): Add __vdso_clock_gettime. diff --git a/sysdeps/unix/sysv/linux/i386/Versions b/sysdeps/unix/sysv/linux/i386/Versions index f3544ac..f18cbf3 100644 --- a/sysdeps/unix/sysv/linux/i386/Versions +++ b/sysdeps/unix/sysv/linux/i386/Versions @@ -47,5 +47,6 @@ libc { } GLIBC_PRIVATE { __modify_ldt; + __vdso_clock_gettime; } }