From patchwork Thu Nov 20 01:33:41 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roland McGrath X-Patchwork-Id: 412554 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5CFE61400E2 for ; Thu, 20 Nov 2014 12:33:51 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:content-type :content-transfer-encoding:from:to:subject:message-id:date; q= dns; s=default; b=Z4PDMCbHbYIGZ3TWd1h2Fhlh2DcFzWbHDP/JD8esdd3RJC 3zKU5Fd8F+7KaySl5mt+DkDh0XcGkx0QVy3/KIHOqWq//chsQ3Pa+TUK/J2GFQsx 8fzKHHOEmgoieaamV/YEmlQrpEMw5txQwY+Xq/fp2Zd3MsPt+LW1EEg01SnR8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:content-type :content-transfer-encoding:from:to:subject:message-id:date; s= default; bh=+1S0F0hyR/RhGFQT4Z5Tw5Hfews=; b=l/hdUV582BhESyV9tNxg ZZ8Tl5r9rbOXEs/bX2QMMSuY/c1MUhsuWwL8ZeehGz+qqumAkPXzcnAZr0XDlFUE c1qiHCY3tSIA8NEe9tOVxQTeW1CW1Qde3/F11MVllivPKHEeAI/t8PMkl82TF6ko tBgtOmUX0oUVe7JR/6jmGHY= Received: (qmail 26012 invoked by alias); 20 Nov 2014 01:33:45 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 25969 invoked by uid 89); 20 Nov 2014 01:33:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: topped-with-meat.com MIME-Version: 1.0 From: Roland McGrath To: "GNU C. Library" Subject: [COMMITTED PATCH] Test that pthread_create diagnoses invalid scheduling parameters. Message-Id: <20141120013341.AAEF42C3B18@topped-with-meat.com> Date: Wed, 19 Nov 2014 17:33:41 -0800 (PST) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=SvUDtp+0 c=1 sm=1 tr=0 a=WkljmVdYkabdwxfqvArNOQ==:117 a=14OXPxybAAAA:8 a=kj9zAlcOel0A:10 a=hOe2yjtxAAAA:8 a=mDV3o1hIAAAA:8 a=3NRXSgqGtZsrnnBHAuEA:9 a=CjuIK1q_8ugA:10 Tested x86_64-linux-gnu. Thanks, Roland 2014-11-19 Roland McGrath * nptl/tst-bad-schedattr.c: New file. * nptl/Makefile (tests): Add it. --- a/nptl/Makefile +++ b/nptl/Makefile @@ -270,7 +270,8 @@ tests = tst-typesizes \ tst-vfork1 tst-vfork2 tst-vfork1x tst-vfork2x \ tst-getpid1 tst-getpid2 tst-getpid3 \ tst-setuid3 \ - tst-initializers1 $(patsubst %,tst-initializers1-%,c89 gnu89 c99 gnu99) + tst-initializers1 $(addprefix tst-initializers1-,c89 gnu89 c99 gnu99) \ + tst-bad-schedattr xtests = tst-setuid1 tst-setuid1-static tst-setuid2 \ tst-mutexpp1 tst-mutexpp6 tst-mutexpp10 test-srcs = tst-oddstacklimit --- /dev/null +++ b/nptl/tst-bad-schedattr.c @@ -0,0 +1,97 @@ +/* Test that pthread_create diagnoses invalid scheduling parameters. + Copyright (C) 2014 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#include +#include +#include +#include + + +static void * +thread_function (void *arg) +{ + abort (); +} + + +static int +do_test (void) +{ +#if !defined SCHED_FIFO || !defined SCHED_OTHER + puts ("SCHED_FIFO or SCHED_OTHER not available at compile time"); + return 0; /* 77 */ +#else + + int err; + +#define TRY(func, arglist) \ + if ((err = func arglist) != 0) \ + { \ + printf ("%s: %s\n", #func, strerror (err)); \ + return 2; \ + } + + int fifo_max = sched_get_priority_max (SCHED_FIFO); + if (fifo_max == -1) + { + assert (errno == ENOTSUP || errno == ENOSYS); + puts ("SCHED_FIFO not supported, cannot test"); + return 0; /* 77 */ + } + + int other_max = sched_get_priority_max (SCHED_OTHER); + if (other_max == -1) + { + assert (errno == ENOTSUP || errno == ENOSYS); + puts ("SCHED_OTHER not supported, cannot test"); + return 0; /* 77 */ + } + + assert (fifo_max > other_max); + + pthread_attr_t attr; + TRY (pthread_attr_init, (&attr)); + TRY (pthread_attr_setinheritsched, (&attr, PTHREAD_EXPLICIT_SCHED)); + TRY (pthread_attr_setschedpolicy, (&attr, SCHED_FIFO)); + + /* This value is chosen so as to be valid for SCHED_FIFO but invalid for + SCHED_OTHER. */ + struct sched_param param = { .sched_priority = other_max + 1 }; + TRY (pthread_attr_setschedparam, (&attr, ¶m)); + + TRY (pthread_attr_setschedpolicy, (&attr, SCHED_OTHER)); + + /* Now ATTR has a sched_param that is invalid for its policy. */ + pthread_t th; + err = pthread_create (&th, &attr, &thread_function, NULL); + if (err != EINVAL) + { + printf ("pthread_create returned %d (%s), expected %d (EINVAL: %s)\n", + err, strerror (err), EINVAL, strerror (EINVAL)); + return 1; + } + + return 0; +#endif +} + + +#define TEST_FUNCTION do_test () +#include "../test-skeleton.c"