Message ID | 20140912111316.GA28404@spoyarek.pnq.redhat.com |
---|---|
State | New |
Headers | show |
That looks OK. But we should consider as a cleanup removing all the #ifdef's from getconf.c entirely. All configurations use the same bits/confname.h, so there is no actual variation being tested here. I'm not sure that POSIX actually allows us any leeway to omit any of the _SC_* or _PC_* symbols. But even if it does, I can't really see a reason why we'd want to let the GNU API vary that way.
diff --git a/posix/getconf.c b/posix/getconf.c index db6acc4..c2c0d3f 100644 --- a/posix/getconf.c +++ b/posix/getconf.c @@ -1004,6 +1004,13 @@ static const struct conf vars[] = { "RAW_SOCKETS", _SC_RAW_SOCKETS, SYSCONF }, #endif +#ifdef _SC_IPV6 + { "_POSIX_IPV6", _SC_IPV6, SYSCONF }, +#endif +#ifdef _SC_RAW_SOCKETS + { "_POSIX_RAW_SOCKETS", _SC_RAW_SOCKETS, SYSCONF }, +#endif + { NULL, 0, SYSCONF } };