Message ID | 20140321155328.GA12661@spoyarek.pnq.redhat.com |
---|---|
State | New |
Headers | show |
Ping! On Fri, Mar 21, 2014 at 09:23:28PM +0530, Siddhesh Poyarekar wrote: > Hi, > > The modf benchmark can now use the framework since the introduction of > output arguments. OK to commit? > > Siddhesh > > * benchtests/bench-modf.c: Remove. > * benchtests/modf-inputs: New inputs file. > > --- > benchtests/bench-modf.c | 44 -------------------------------------------- > benchtests/modf-inputs | 4 ++++ > 2 files changed, 4 insertions(+), 44 deletions(-) > delete mode 100644 benchtests/bench-modf.c > create mode 100644 benchtests/modf-inputs > > diff --git a/benchtests/bench-modf.c b/benchtests/bench-modf.c > deleted file mode 100644 > index 407360c..0000000 > --- a/benchtests/bench-modf.c > +++ /dev/null > @@ -1,44 +0,0 @@ > -/* Copyright (C) 2013-2014 Free Software Foundation, Inc. > - This file is part of the GNU C Library. > - > - The GNU C Library is free software; you can redistribute it and/or > - modify it under the terms of the GNU Lesser General Public > - License as published by the Free Software Foundation; either > - version 2.1 of the License, or (at your option) any later version. > - > - The GNU C Library is distributed in the hope that it will be useful, > - but WITHOUT ANY WARRANTY; without even the implied warranty of > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - Lesser General Public License for more details. > - > - You should have received a copy of the GNU Lesser General Public > - License along with the GNU C Library; if not, see > - <http://www.gnu.org/licenses/>. */ > - > -extern double modf (double, double *); > - > -#define CALL_BENCH_FUNC(j, i) modf (in[j].arg0, &i); > - > -struct args > -{ > - volatile double arg0; > -} in[] = > -{ > - { 42.42 }, > - { -42.42 } > -}; > - > -#define NUM_VARIANTS 1 > -#define NUM_SAMPLES(v) (sizeof (in) / sizeof (struct args)) > - > -static volatile double ret = 0.0; > -#define BENCH_FUNC(v, j) \ > -({ \ > - double iptr; \ > - ret = CALL_BENCH_FUNC (j, iptr); \ > -}) > - > -#define FUNCNAME "modf" > -#define VARIANT(v) FUNCNAME "()" > - > -#include "bench-skeleton.c" > diff --git a/benchtests/modf-inputs b/benchtests/modf-inputs > new file mode 100644 > index 0000000..4fcc99b > --- /dev/null > +++ b/benchtests/modf-inputs > @@ -0,0 +1,4 @@ > +## includes: math.h > +## args: double:<double *> > +42.0 > +-42.0 > -- > 1.8.3.1 >
On 27 March 2014 14:24, Siddhesh Poyarekar <siddhesh@redhat.com> wrote: > Ping! > > On Fri, Mar 21, 2014 at 09:23:28PM +0530, Siddhesh Poyarekar wrote: >> Hi, >> >> The modf benchmark can now use the framework since the introduction of >> output arguments. OK to commit? >> >> Siddhesh >> >> * benchtests/bench-modf.c: Remove. >> * benchtests/modf-inputs: New inputs file. This looks ok to me.
diff --git a/benchtests/bench-modf.c b/benchtests/bench-modf.c deleted file mode 100644 index 407360c..0000000 --- a/benchtests/bench-modf.c +++ /dev/null @@ -1,44 +0,0 @@ -/* Copyright (C) 2013-2014 Free Software Foundation, Inc. - This file is part of the GNU C Library. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library; if not, see - <http://www.gnu.org/licenses/>. */ - -extern double modf (double, double *); - -#define CALL_BENCH_FUNC(j, i) modf (in[j].arg0, &i); - -struct args -{ - volatile double arg0; -} in[] = -{ - { 42.42 }, - { -42.42 } -}; - -#define NUM_VARIANTS 1 -#define NUM_SAMPLES(v) (sizeof (in) / sizeof (struct args)) - -static volatile double ret = 0.0; -#define BENCH_FUNC(v, j) \ -({ \ - double iptr; \ - ret = CALL_BENCH_FUNC (j, iptr); \ -}) - -#define FUNCNAME "modf" -#define VARIANT(v) FUNCNAME "()" - -#include "bench-skeleton.c" diff --git a/benchtests/modf-inputs b/benchtests/modf-inputs new file mode 100644 index 0000000..4fcc99b --- /dev/null +++ b/benchtests/modf-inputs @@ -0,0 +1,4 @@ +## includes: math.h +## args: double:<double *> +42.0 +-42.0