From patchwork Thu Nov 30 11:26:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 842962 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-87664-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="iOzDV5PD"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ynZqc6DzBz9s84 for ; Thu, 30 Nov 2017 22:26:52 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; q=dns; s= default; b=DV7vnmB9JPtI56N+TnFv717v2WDwBWtKSGCv0eKmA6PbJ7zWk7pgV 2HFXUU6rb/lxQfk6SeH9w5i3r7yFgWrYwfC7haU8L45NyoEzPZKMAEuUhFNmENeX YvAfA+W8PzBRkOm87kv2ssbbsweDSg64T6ZPkQLPqRMa/G6f4JvWiA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; s=default; bh=hYfXO4/iTOK3c9xSeliyr4wwyF8=; b=iOzDV5PDg6RIpXpfejKo0BHadZhI 3z6gSuBr+VzQpc71vP+PFWs/rHpEXpbiiZrFAwbAgfqTrX4iKf7aup+FcqrVVzN0 CL0ABMKLGcp/2VoB6t9u3/Nb1EB9VU3HeEYqGkzJVqnPsaCQkmLvbAgyB2L/K90w mYBkTNLbVE5nhYk= Received: (qmail 76409 invoked by alias); 30 Nov 2017 11:26:47 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 76395 invoked by uid 89); 30 Nov 2017 11:26:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD, RCVD_IN_DNSWL_NONE, SPF_NEUTRAL autolearn=ham version=3.3.2 spammy= X-HELO: homiemail-a52.g.dreamhost.com From: Siddhesh Poyarekar To: libc-alpha@sourceware.org Subject: [PATCH] aarch64: Avoid hidden symbols for memcpy/memmove into static binaries Date: Thu, 30 Nov 2017 16:56:36 +0530 Message-Id: <1512041196-14726-1-git-send-email-siddhesh@sourceware.org> The __GI_* symbol aliases for __memcpy_generic are unnecessary since they're never used. Add them only for libc.so to avoid PLT. * sysdeps/aarch64/multiarch/memcpy_generic.S (__GI_memcpy): Define only for libc.so. --- sysdeps/aarch64/multiarch/memcpy_generic.S | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sysdeps/aarch64/multiarch/memcpy_generic.S b/sysdeps/aarch64/multiarch/memcpy_generic.S index 041a779..edb2e52 100644 --- a/sysdeps/aarch64/multiarch/memcpy_generic.S +++ b/sysdeps/aarch64/multiarch/memcpy_generic.S @@ -33,9 +33,11 @@ # undef libc_hidden_builtin_def # define libc_hidden_builtin_def(name) +# ifdef SHARED /* It doesn't make sense to send libc-internal memcpy calls through a PLT. */ .globl __GI_memcpy; __GI_memcpy = __memcpy_generic .globl __GI_memmove; __GI_memmove = __memmove_generic +# endif #endif