diff mbox

[1/1] Added yesstr and nostr to zh_HK locale

Message ID 1499429750-24690-1-git-send-email-akhilesh.k@samsung.com
State New
Headers show

Commit Message

Akhilesh Kumar July 7, 2017, 12:15 p.m. UTC 
During Locale verification i observed that
yesstr and nostr  are missing for Chinese language locale [LC_MESSAGES]
for HK
[BZ #21733]
       locales/zh_HK (LC_MESSAGES): add yesstr and nostr

signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
---
 localedata/locales/zh_HK | 2 ++
 1 files changed, 2 insertions(+)

Comments

Mike FABIAN July 7, 2017, 1:46 p.m. UTC | #1 
Akhilesh Kumar <akhilesh.k@samsung.com> wrote:

> During Locale verification i observed that
> yesstr and nostr  are missing for Chinese language locale [LC_MESSAGES]
> for HK
> [BZ #21733]
>        locales/zh_HK (LC_MESSAGES): add yesstr and nostr
>
> signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> ---
>  localedata/locales/zh_HK | 2 ++
>  1 files changed, 2 insertions(+)
>
> diff --git a/localedata/locales/zh_HK b/localedata/locales/zh_HK
> index cc85c15..c800c73 100644
> --- a/localedata/locales/zh_HK
> +++ b/localedata/locales/zh_HK
> @@ -151,6 +151,8 @@ END LC_TIME
>  LC_MESSAGES
>  yesexpr "<U005E><U005B><U002B><U0031><U0079><U0059><U662F><U005D>"
>  noexpr  "<U005E><U005B><U002D><U0030><U006E><U004E><U4E0D><U5426><U005D>"
> +yesstr  "<U662F>"
> +nostr   "<U4E0D><U662F>"
>  END LC_MESSAGES

CLDR has this in zh_Hant_HK.xml:

	<posix>
		<messages>
			<yesstr>是</yesstr>
			<nostr>否</nostr>
		</messages>
	</posix>

Maybe we should prefer that?
Akhilesh Kumar July 10, 2017, 3:49 a.m. UTC | #2 
> Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>  
> > During Locale verification i observed that
> > yesstr and nostr  are missing for Chinese language locale [LC_MESSAGES]
> > for HK
> > [BZ #21733]
>>        locales/zh_HK (LC_MESSAGES): add yesstr and nostr
> >
> > signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> > ---
> >  localedata/locales/zh_HK | 2 ++
>>  1 files changed, 2 insertions(+)
> >
> > diff --git a/localedata/locales/zh_HK b/localedata/locales/zh_HK
> > index cc85c15..c800c73 100644
> > --- a/localedata/locales/zh_HK
> > +++ b/localedata/locales/zh_HK
> > @@ -151,6 +151,8 @@ END LC_TIME
> >  LC_MESSAGES
> >  yesexpr "<U005E><U005B><U002B><U0031><U0079><U0059><U662F><U005D>"
> >  noexpr  "<U005E><U005B><U002D><U0030><U006E><U004E><U4E0D><U5426><U005D>"
> > +yesstr  "<U662F>"
> > +nostr   "<U4E0D><U662F>"
>  END LC_MESSAGES
 
> CLDR has this in zh_Hant_HK.xml:
>  
>         <posix>
>                 <messages>
>                         <yesstr>是</yesstr>

>                         <nostr>否</nostr>

>                </messages>

>         </posix>

>  

> Maybe we should prefer that?

>  

>-- 

> Mike FABIAN <mfabian@redhat.com>

>  


Mike Thanks for comments
 
please find updated v2 patch for zh_HK
https://sourceware.org/ml/libc-alpha/2017-07/msg00362.html

Reference 
https://gitlab.cs.man.ac.uk/tornike.keburia/ss_demo/blob/3119dc87b277f1cd50b995ab659d7fafb877487b/framework/thirdparty/Zend/Locale/Data/zh_Hant_HK.xml
diff mbox

Patch

diff --git a/localedata/locales/zh_HK b/localedata/locales/zh_HK
index cc85c15..c800c73 100644
--- a/localedata/locales/zh_HK
+++ b/localedata/locales/zh_HK
@@ -151,6 +151,8 @@  END LC_TIME
 LC_MESSAGES
 yesexpr "<U005E><U005B><U002B><U0031><U0079><U0059><U662F><U005D>"
 noexpr  "<U005E><U005B><U002D><U0030><U006E><U004E><U4E0D><U5426><U005D>"
+yesstr  "<U662F>"
+nostr   "<U4E0D><U662F>"
 END LC_MESSAGES