From patchwork Mon May 22 19:47:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 765571 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wWq2J6N5Xz9s7g for ; Tue, 23 May 2017 05:47:52 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="tA4P5GsO"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; q=dns; s= default; b=l05o+uozX9+hHnc2UJMuxzARiEHo3U89FHixKXENIY88D6+LjMKU7 OE45L+hXppNJHvwP4+0MPSQiGhO87oO2YHsaHUsQY1Xt1SpamKCR3G1owX71wrEN TgwlVT4HSKggsz5hEEmdyU7EIZ8g3HqRDxQOGBGHBt0EK8vr0gOOuQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; s=default; bh=zbtdMKHGiC8xfrN2mQNIoivOezU=; b=tA4P5GsOmo3WBQE9bsBdhgtWfH+0 XMRDfe6JkU7p7jPzJsJn/Lebs6xAWis/lMVrb6/WfWuk6xS/aEs0WdfDdS7Ze04Q qGaKnKNjmUX9JqAECfhisEp4TH12/fwejXMdQ8v47Ro1drQNWsYsn6ua828Ty1/H CaoEWjzdNOXoync= Received: (qmail 48033 invoked by alias); 22 May 2017 19:47:43 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 48011 invoked by uid 89); 22 May 2017 19:47:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_NEUTRAL autolearn=ham version=3.3.2 spammy=Hx-languages-length:1421, him, xxx, twitter X-HELO: homiemail-a92.g.dreamhost.com From: Siddhesh Poyarekar To: libc-alpha@sourceware.org Subject: [COMMITTED] Remove useless comment from sysdeps/sparc/sparc32/dl-machine.h Date: Tue, 23 May 2017 01:17:33 +0530 Message-Id: <1495482453-6499-1-git-send-email-siddhesh@sourceware.org> David Miller has not been shot yet AFAIK (yes, I googled for any news that may seem relevant and I poked him on twitter some days ago) so either nobody uses SPARC or the code is correct or nobody read the instructions in the comment to shoot him. In all of those cases the comment is clearly not useful, so getting rid of it. --- ChangeLog | 5 +++++ sysdeps/sparc/sparc32/dl-machine.h | 2 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index ce060eb..4ce26de 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2017-05-22 Siddhesh Poyarekar + + * sysdeps/sparc/sparc32/dl-machine.h (elf_machine_matches_host): + Remove invalid comment. + 2017-05-21 Zack Weinberg * signal/Makefile (headers): Add bits/types/sigval_t.h. diff --git a/sysdeps/sparc/sparc32/dl-machine.h b/sysdeps/sparc/sparc32/dl-machine.h index cf7272f..e17ac8e 100644 --- a/sysdeps/sparc/sparc32/dl-machine.h +++ b/sysdeps/sparc/sparc32/dl-machine.h @@ -36,8 +36,6 @@ elf_machine_matches_host (const Elf32_Ehdr *ehdr) return 1; else if (ehdr->e_machine == EM_SPARC32PLUS) { - /* XXX The following is wrong! Dave Miller rejected to implement it - correctly. If this causes problems shoot *him*! */ #ifdef SHARED return GLRO(dl_hwcap) & GLRO(dl_hwcap_mask) & HWCAP_SPARC_V9; #else