diff mbox

[COMMITTED] Remove useless comment from sysdeps/sparc/sparc32/dl-machine.h

Message ID 1495482453-6499-1-git-send-email-siddhesh@sourceware.org
State New
Headers show

Commit Message

Siddhesh Poyarekar May 22, 2017, 7:47 p.m. UTC 
David Miller has not been shot yet AFAIK (yes, I googled for any news
that may seem relevant and I poked him on twitter some days ago) so
either nobody uses SPARC or the code is correct or nobody read the
instructions in the comment to shoot him.  In all of those cases the
comment is clearly not useful, so getting rid of it.
---
 ChangeLog                          | 5 +++++
 sysdeps/sparc/sparc32/dl-machine.h | 2 --
 2 files changed, 5 insertions(+), 2 deletions(-)

Comments

David Miller May 22, 2017, 8:18 p.m. UTC | #1 
From: Siddhesh Poyarekar <siddhesh@sourceware.org>
Date: Tue, 23 May 2017 01:17:33 +0530

> David Miller has not been shot yet AFAIK (yes, I googled for any news
> that may seem relevant and I poked him on twitter some days ago) so
> either nobody uses SPARC or the code is correct or nobody read the
> instructions in the comment to shoot him.  In all of those cases the
> comment is clearly not useful, so getting rid of it.

This looks fine :)
diff mbox

Patch

diff --git a/ChangeLog b/ChangeLog
index ce060eb..4ce26de 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@ 
+2017-05-22  Siddhesh Poyarekar  <siddhesh@sourceware.org>
+
+	* sysdeps/sparc/sparc32/dl-machine.h (elf_machine_matches_host):
+	Remove invalid comment.
+
 2017-05-21  Zack Weinberg  <zackw@panix.com>
 
 	* signal/Makefile (headers): Add bits/types/sigval_t.h.
diff --git a/sysdeps/sparc/sparc32/dl-machine.h b/sysdeps/sparc/sparc32/dl-machine.h
index cf7272f..e17ac8e 100644
--- a/sysdeps/sparc/sparc32/dl-machine.h
+++ b/sysdeps/sparc/sparc32/dl-machine.h
@@ -36,8 +36,6 @@  elf_machine_matches_host (const Elf32_Ehdr *ehdr)
     return 1;
   else if (ehdr->e_machine == EM_SPARC32PLUS)
     {
-      /* XXX The following is wrong!  Dave Miller rejected to implement it
-	 correctly.  If this causes problems shoot *him*!  */
 #ifdef SHARED
       return GLRO(dl_hwcap) & GLRO(dl_hwcap_mask) & HWCAP_SPARC_V9;
 #else