From patchwork Thu May 18 20:21:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 764177 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wTN0B68Y1z9s1h for ; Fri, 19 May 2017 06:22:34 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="tuCPXYKC"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; q=dns; s= default; b=WdTKniW7LkV4ciWi7XF/IQO17bvp9y1zhUgkZrtGirycUrjybgTCG 4RvO4649xfh24xmtYTjEzfzHY6SkC6qPXhhTOvQ8hdtQhyIoYWu3bmiFcykGGWSL We3KUaeQ8U221AoVso19mpfIZLTBgtbJzGxDclMw2ihM0oivq+9/R8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; s=default; bh=Kc8fzT70xbyhBnHs40Dke1+oDBY=; b=tuCPXYKClXCz1pqHHgqokeu1Arjw Rkr0Svdi6O+i8hVZF3bTVqS9Rx4anwsCbZfms1wKdBUVC/+hQpiqoPAaiJoXa91E OuqewVwUQzG26Ay+e6UMtP0MV14Yak6bY4pyvqjnARamny3XrwlqyX3VW+L9vru3 8d7Vjejvz1wRr80= Received: (qmail 83301 invoked by alias); 18 May 2017 20:22:23 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 83283 invoked by uid 89); 18 May 2017 20:22:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_NEUTRAL autolearn=ham version=3.3.2 spammy= X-HELO: homiemail-a68.g.dreamhost.com From: Siddhesh Poyarekar To: libc-alpha@sourceware.org Subject: [COMMITTED] Reduce value of LD_HWCAP_MASK for tst-env-setuid test case Date: Fri, 19 May 2017 01:51:39 +0530 Message-Id: <1495138899-5509-1-git-send-email-siddhesh@sourceware.org> It was discovered that the dynamic linker allocates a massive amount of memory that increases with the value of LD_HWCAP_MASK. Due to this, setting its value to 0xffffffff in the environment of tst-env-setuid would cause it to fail in some environments where overcommit was disabled or severely constrained because malloc would fail. Since this test is only concerned with the value of LD_HWCAP_MASK envvar being conserved (or not, for setxid binaries), lower its value to avoid spurious failures. The allocation bug is reported as #21502. Siddhesh --- ChangeLog | 5 +++++ elf/Makefile | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index f0227d4..06ef578 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2017-05-18 Siddhesh Poyarekar + + * elf/Makefile (tst-env-setuid-ENV): Reduce value of + LD_HWCAP_MASK. + 2017-05-18 Rical Jasan * manual/conf.texi: Convert @tables of annotated @items to diff --git a/elf/Makefile b/elf/Makefile index 2fd6bf7..201b328 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -1407,6 +1407,6 @@ $(objpfx)tst-nodelete-dlclose.out: $(objpfx)tst-nodelete-dlclose-dso.so \ $(objpfx)tst-nodelete-dlclose-plugin.so tst-env-setuid-ENV = MALLOC_CHECK_=2 MALLOC_MMAP_THRESHOLD_=4096 \ - LD_HWCAP_MASK=0xffffffff + LD_HWCAP_MASK=0x1 tst-env-setuid-tunables-ENV = \ GLIBC_TUNABLES=glibc.malloc.check=2:glibc.malloc.mmap_threshold=4096