From patchwork Wed May 13 06:39:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 471700 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id E8E6B140A99 for ; Wed, 13 May 2015 16:39:57 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sourceware.org header.i=@sourceware.org header.b=f5v4acFn; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; q=dns; s= default; b=D+Hnxu0iCcUKT5A3tCqFOnW/bWh1PCbvSiqWKZylNNCD7+I56CCTt 2/k54bikxOiJqPhJwFe7DiSeuufYNVdW/FR/qNp4HeRc8Zd1aWeukfxBBmEUyr9A 85u35VBRWMxoEny8iYSI+nTMvPBOMR4CRCIL5VwBvvEoCBWLW9qCig= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; s=default; bh=Qmk4k7hxE+/4GMZ9cyErP1Z+uOE=; b=f5v4acFne7FLQAzkJEe6ap8bkkZV tKjYLv0wjIpiJcRl+zUvrj0LDQI0dixURaUKBfxdaAp7Il+IYVgC6nnPZWEisgOu 1DCoun4Idz9b2LBUCwUCy/jXW0rY4PRvearCIR4hnVKPwCSwGDUqFZzBX/2zy9MD iePAREVPQz1p6Cs= Received: (qmail 71364 invoked by alias); 13 May 2015 06:39:50 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 71352 invoked by uid 89); 13 May 2015 06:39:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com From: "Siddhesh Poyarekar" To: libc-alpha@sourceware.org Subject: [PATCH] Succeed if make check does not report any errors Date: Wed, 13 May 2015 12:09:31 +0530 Message-Id: <1431499171-30140-1-git-send-email-siddhesh@redhat.com> The conditional that evaluates if there are any FAILed test cases currently always fails, since we ensure it fails if we find any unexpected results in tests.sum and it would obviously fail if it does not find failed results in tests.sum. This patch fixes this by simply inverting the result of the egrep, i.e. succeed if egrep fails (to find failed results) and fail if it succeeds. Tested with 'make subdirs=localedata check' and 'make subdirs=locale check' where all tests succeed and with 'make subdirs=elf check' where a couple of tests fail for me. * Makefile (summarize-tests): Fix return value on success. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 7edf517..658ccfa 100644 --- a/Makefile +++ b/Makefile @@ -320,7 +320,7 @@ define summarize-tests @egrep -v '^(PASS|XFAIL):' $(objpfx)$1 || true @echo "Summary of test results$2:" @sed 's/:.*//' < $(objpfx)$1 | sort | uniq -c -@egrep -q -v '^(X?PASS|XFAIL|UNSUPPORTED):' $(objpfx)$1 && false +@! egrep -q -v '^(X?PASS|XFAIL|UNSUPPORTED):' $(objpfx)$1 endef tests-special-notdir = $(patsubst $(objpfx)%, %, $(tests-special))