From patchwork Fri Sep 4 15:05:40 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wilco X-Patchwork-Id: 514602 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id AAAEA140771 for ; Sat, 5 Sep 2015 01:06:03 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b=O/3RGPoc; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=default; b=GEQ a1xqLmKrJ3B+PqpZYXDB4q9iMXIHSHvlZhdLyDBSJrpLio+mM1c7KZSX/RlxV0w5 ce69beDfAiypNGpdAEEMr+gE542urdfWaec5D0TxQ1ZnC7afzbocC0yx8m2r75O2 rVbm5pmhzavatEW69PIvq5SGnWEihp2K/+YTCItQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type:content-transfer-encoding; s=default; bh=orMh0Hnic 8any0KPvIfBxbdd9H4=; b=O/3RGPocG/86GE+Dr+aIoffWeo8KhPNICJ2DHxtUq 80p2Zq0ZFnX6CwPhxQtLfROSz+dSdjQfeKDlK7QS4FWhwgyEEepHQt5xWv0PY2C0 d+fyQOqc13DjCaDZKb2r06vUg5hO/fN+aP7R0xtwNJM6KK2cnxKsBiUFQqeHuAew gg= Received: (qmail 102341 invoked by alias); 4 Sep 2015 15:05:56 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 102328 invoked by uid 89); 4 Sep 2015 15:05:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com From: "Wilco Dijkstra" To: "'GNU C Library'" Subject: [PATCH] Use builtins in signbit implementation Date: Fri, 4 Sep 2015 16:05:40 +0100 Message-ID: <001401d0e723$29cdf720$7d69e560$@com> MIME-Version: 1.0 X-MC-Unique: Td-dSTuNRHOM2HOom_CUNg-1 Use the GCC builtin functions for the non-inlined signbit implementations. This excludes the 128ibm format as I'm not sure whether the builtins work for that case. OK for commit? ChangeLog: 2015-09-04 Wilco Dijkstra * sysdeps/ieee754/dbl-64/s_signbit.c (__signbit): Use __builtin_signbit. * sysdeps/ieee754/flt-32/s_signbitf.c (__signbitf): Use __builtin_signbitf. * sysdeps/ieee754/ldbl-128/s_signbitl.c (__signbitl): Use __builtin_signbitl. * sysdeps/ieee754/ldbl-96/s_signbitl.c (__signbitl): Likewise. --- sysdeps/ieee754/dbl-64/s_signbit.c | 6 +----- sysdeps/ieee754/flt-32/s_signbitf.c | 6 +----- sysdeps/ieee754/ldbl-128/s_signbitl.c | 6 +----- sysdeps/ieee754/ldbl-96/s_signbitl.c | 6 +----- 4 files changed, 4 insertions(+), 20 deletions(-) diff --git a/sysdeps/ieee754/dbl-64/s_signbit.c b/sysdeps/ieee754/dbl-64/s_signbit.c index 764f11a..41fca00 100644 --- a/sysdeps/ieee754/dbl-64/s_signbit.c +++ b/sysdeps/ieee754/dbl-64/s_signbit.c @@ -19,13 +19,9 @@ #include -#include int __signbit (double x) { - int32_t hx; - - GET_HIGH_WORD (hx, x); - return hx & 0x80000000; + return __builtin_signbit (x); } diff --git a/sysdeps/ieee754/flt-32/s_signbitf.c b/sysdeps/ieee754/flt-32/s_signbitf.c index 169820e..7be7b6e 100644 --- a/sysdeps/ieee754/flt-32/s_signbitf.c +++ b/sysdeps/ieee754/flt-32/s_signbitf.c @@ -19,13 +19,9 @@ #include -#include int __signbitf (float x) { - int32_t hx; - - GET_FLOAT_WORD (hx, x); - return hx & 0x80000000; + return __builtin_signbitf (x); } diff --git a/sysdeps/ieee754/ldbl-128/s_signbitl.c b/sysdeps/ieee754/ldbl-128/s_signbitl.c index acfe859..cc5f16e 100644 --- a/sysdeps/ieee754/ldbl-128/s_signbitl.c +++ b/sysdeps/ieee754/ldbl-128/s_signbitl.c @@ -19,13 +19,9 @@ #include -#include int __signbitl (long double x) { - int64_t e; - - GET_LDOUBLE_MSW64 (e, x); - return e < 0; + return __builtin_signbitl (x); } diff --git a/sysdeps/ieee754/ldbl-96/s_signbitl.c b/sysdeps/ieee754/ldbl-96/s_signbitl.c index bbe72a6..cc5f16e 100644 --- a/sysdeps/ieee754/ldbl-96/s_signbitl.c +++ b/sysdeps/ieee754/ldbl-96/s_signbitl.c @@ -19,13 +19,9 @@ #include -#include int __signbitl (long double x) { - int32_t e; - - GET_LDOUBLE_EXP (e, x); - return e & 0x8000; + return __builtin_signbitl (x); }