From patchwork Fri Aug 30 19:51:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 1979199 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fnl5F5q3; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WwTLz0hjXz1yfn for ; Sat, 31 Aug 2024 05:52:11 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7FEB3385020E for ; Fri, 30 Aug 2024 19:52:08 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 7FC37385E011 for ; Fri, 30 Aug 2024 19:51:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7FC37385E011 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7FC37385E011 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1725047508; cv=none; b=IiH2Cus0MKALh0pEf6Jke4TDUfJRkRXGlAokSxZnDvQq5hA1cLmz6L4tIDP4BTx6mOF85BZqueJyQUZNe9muxZ9w7uaafnRD13GT7YXjB5v2HI5jQXAmy7K74F7AGj6VTD2ykwIO42PtXiH8xfeRViD+ioL4GPZbkoDBMVhFdB0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1725047508; c=relaxed/simple; bh=OhkVI/WkhCZ807ALGfwXXmAYxDM8q41F03fVwO2nG4M=; h=DKIM-Signature:From:To:Subject:Message-ID:Date:MIME-Version; b=tK4O5XZUs5W2POVBzUMDyK017MAAtXG9s+GlUxBgsjz045cZG+UV1tnPFGvu9NJ33nuq60WKyR2/inhZYnTezk21fapHGSRDWiWimERhw/FyY6i2MzMaUnNtSKbRVtTB4wrOLmXBi4x3Yq5dCNM+DTPMKoYTqNUgBpDl6UjsoHM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725047505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=XOAzQLY1SSIgE/ZJsdpp0IU707UjtWHNMXNsmZ7NsxU=; b=fnl5F5q3AjRKHuPBGrdUobxIs/598tC1EtGrAGxIMasUynLbWwzyjY5otBmxbjCV22EatO r/73dVKvTq2uxXA5demju8i53JCjuI+KH/mDMl/dK30OM77N7JnQH2vPqfjRHix8YytFiJ oADqpoLjhSq9XboCiY+IYQjqQR4WqVw= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-tXtuVIHqMBCls31gNHszew-1; Fri, 30 Aug 2024 15:51:44 -0400 X-MC-Unique: tXtuVIHqMBCls31gNHszew-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E1CD31956048 for ; Fri, 30 Aug 2024 19:51:42 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.7]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E74DF3001FE8 for ; Fri, 30 Aug 2024 19:51:41 +0000 (UTC) From: Florian Weimer To: libc-alpha@sourceware.org Subject: [PATCH v4 00/13] FUSE-based testing for file system functions Message-ID: X-From-Line: 45939a6bcc66e746a672a92a72e12e46b772490b Mon Sep 17 00:00:00 2001 Date: Fri, 30 Aug 2024 21:51:38 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org This revision addresses a reliability problems (failure during unmount) on older kernels. It adds a facility for generating directory streams, and uses that to test various historic readdir and readdir_r bugs. This revealed a bunch of other problems, which had to be fixed to get clean test results for dirent/tst-readdir-long in particular. The abstraction allows testing various readdir variants (we have six of them on some architectures) in a single test, with a simple for loop, instead of using skeleton files. The new header is more along traditional lines and provides x* wrappers. Thanks, Florian Florian Weimer (13): Bundle userspace header from Linux 6.10 support: Add Linux: readdir_r needs to report getdents failures (bug 32124) support: Add support: Add FUSE-based file system test framework to support/ misc: FUSE-based tests for mkstemp io: Add FUSE-based test for fchmod io: Add tst-lstat-nofollow, tst-lstat-nofollow-time64 dirent: Add tst-closedir-leaks Linux: Use readdir64_r for compat __old_readdir64_r (bug 32128) dirent: Add tst-readdir-long dirent: Add tst-rewinddir Linux: readdir64_r should not skip d_ino == 0 entries (bug 32126) dirent/Makefile | 23 + dirent/tst-closedir-leaks.c | 76 ++ dirent/tst-readdir-long.c | 231 ++++ dirent/tst-readdir-zero-inode.c | 134 ++ dirent/tst-rewinddir.c | 207 +++ io/Makefile | 3 + io/tst-fchmod-fuse.c | 114 ++ io/tst-lstat-nofollow-time64.c | 1 + io/tst-lstat-nofollow.c | 98 ++ misc/Makefile | 6 + misc/tst-mkstemp-fuse-parallel.c | 208 +++ misc/tst-mkstemp-fuse.c | 195 +++ support/Makefile | 10 + support/bundled/README | 5 + support/bundled/linux/COPYING | 20 + .../LICENSES/exceptions/Linux-syscall-note | 24 + .../bundled/linux/LICENSES/preferred/GPL-2.0 | 359 +++++ .../bundled/linux/include/uapi/linux/fuse.h | 1189 +++++++++++++++++ support/fuse.h | 215 +++ support/readdir.h | 79 ++ support/support_fuse.c | 705 ++++++++++ support/support_readdir.c | 287 ++++ support/support_readdir_check.c | 30 + support/support_readdir_r_check.c | 35 + support/tst-support_fuse.c | 348 +++++ support/tst-support_readdir.c | 71 + support/tst-xdirent.c | 76 ++ support/xclosedir.c | 28 + support/xdirent.h | 86 ++ support/xfdopendir.c | 30 + support/xopendir.c | 30 + sysdeps/unix/sysv/linux/getdents64.c | 97 -- sysdeps/unix/sysv/linux/olddirent.h | 2 - sysdeps/unix/sysv/linux/readdir64.c | 90 +- sysdeps/unix/sysv/linux/readdir64_r.c | 127 +- sysdeps/unix/sysv/linux/readdir_r.c | 11 +- 36 files changed, 5016 insertions(+), 234 deletions(-) create mode 100644 dirent/tst-closedir-leaks.c create mode 100644 dirent/tst-readdir-long.c create mode 100644 dirent/tst-readdir-zero-inode.c create mode 100644 dirent/tst-rewinddir.c create mode 100644 io/tst-fchmod-fuse.c create mode 100644 io/tst-lstat-nofollow-time64.c create mode 100644 io/tst-lstat-nofollow.c create mode 100644 misc/tst-mkstemp-fuse-parallel.c create mode 100644 misc/tst-mkstemp-fuse.c create mode 100644 support/bundled/README create mode 100644 support/bundled/linux/COPYING create mode 100644 support/bundled/linux/LICENSES/exceptions/Linux-syscall-note create mode 100644 support/bundled/linux/LICENSES/preferred/GPL-2.0 create mode 100644 support/bundled/linux/include/uapi/linux/fuse.h create mode 100644 support/fuse.h create mode 100644 support/readdir.h create mode 100644 support/support_fuse.c create mode 100644 support/support_readdir.c create mode 100644 support/support_readdir_check.c create mode 100644 support/support_readdir_r_check.c create mode 100644 support/tst-support_fuse.c create mode 100644 support/tst-support_readdir.c create mode 100644 support/tst-xdirent.c create mode 100644 support/xclosedir.c create mode 100644 support/xdirent.h create mode 100644 support/xfdopendir.c create mode 100644 support/xopendir.c base-commit: 424d97be50488beb6196c0ff0bc3dfeb87b4281c