mbox series

[v3,0/2] malloc: add multi-threaded tests for aligned_alloc/calloc/malloc

Message ID cover.1721142537.git.mmartinv@redhat.com
Headers show
Series malloc: add multi-threaded tests for aligned_alloc/calloc/malloc | expand

Message

Miguel Martín July 16, 2024, 3:14 p.m. UTC 
Improve aligned_alloc/calloc/malloc test coverage by adding
multi-threaded tests with random memory allocations and with/without
cross-thread memory deallocations.

Modify the existing DSO used for random memory allocations to avoid
getting global locks in the allocation process.

The new tests are added to tests-exclude-mcheck as they don't seem
to play well with mcheck and I have not been able to find any problem
with the tests themselves. Happy to fix anything and/or file an issue
in mcheck for further investigation.

Changes from v2:
- Rephrased some sentences and fixed some typos.
- Removed unneeded checks.
- Changed the distribution of sizes in random memory allocations. 

Miguel Martín (2):
  malloc: avoid global locks in tst-aligned_alloc-lib.c
  malloc: add multi-threaded tests for aligned_alloc/calloc/malloc

 malloc/Makefile                               |   8 +
 .../tst-aligned-alloc-random-thread-cross.c   |  19 +++
 malloc/tst-aligned-alloc-random-thread.c      | 145 ++++++++++++++++++
 malloc/tst-aligned_alloc-lib.c                |  39 ++---
 4 files changed, 192 insertions(+), 19 deletions(-)
 create mode 100644 malloc/tst-aligned-alloc-random-thread-cross.c
 create mode 100644 malloc/tst-aligned-alloc-random-thread.c

Comments

Arjun Shankar July 17, 2024, 10:33 p.m. UTC | #1 
Hi Andreas,

I've reviewed these two patches that add a new malloc test. Is it okay
to push them during the freeze?

Cheers,
Arjun

On Tue, Jul 16, 2024 at 5:16 PM Miguel Martín <mmartinv@redhat.com> wrote:
>
> Improve aligned_alloc/calloc/malloc test coverage by adding
> multi-threaded tests with random memory allocations and with/without
> cross-thread memory deallocations.
>
> Modify the existing DSO used for random memory allocations to avoid
> getting global locks in the allocation process.
>
> The new tests are added to tests-exclude-mcheck as they don't seem
> to play well with mcheck and I have not been able to find any problem
> with the tests themselves. Happy to fix anything and/or file an issue
> in mcheck for further investigation.
>
> Changes from v2:
> - Rephrased some sentences and fixed some typos.
> - Removed unneeded checks.
> - Changed the distribution of sizes in random memory allocations.
>
> Miguel Martín (2):
>   malloc: avoid global locks in tst-aligned_alloc-lib.c
>   malloc: add multi-threaded tests for aligned_alloc/calloc/malloc
>
>  malloc/Makefile                               |   8 +
>  .../tst-aligned-alloc-random-thread-cross.c   |  19 +++
>  malloc/tst-aligned-alloc-random-thread.c      | 145 ++++++++++++++++++
>  malloc/tst-aligned_alloc-lib.c                |  39 ++---
>  4 files changed, 192 insertions(+), 19 deletions(-)
>  create mode 100644 malloc/tst-aligned-alloc-random-thread-cross.c
>  create mode 100644 malloc/tst-aligned-alloc-random-thread.c
>
> --
> Miguel Martín
> mmartinv@redhat.com
>
Andreas K. Huettel July 18, 2024, 7:12 a.m. UTC | #2 
Hi Arjun, 

let's do it after the release, it's very last minute now (even though test
additions are in principle harmless).

I intend to start with the checklist tomorrow, so tentatively I'd say that
master should be open again by tuesday if nothing goes wrong.

Best,
Andreas


Am Donnerstag, 18. Juli 2024, 00:33:07 CEST schrieb Arjun Shankar:
> Hi Andreas,
> 
> I've reviewed these two patches that add a new malloc test. Is it okay
> to push them during the freeze?
> 
> Cheers,
> Arjun
> 
> On Tue, Jul 16, 2024 at 5:16 PM Miguel Martín <mmartinv@redhat.com> wrote:
> >
> > Improve aligned_alloc/calloc/malloc test coverage by adding
> > multi-threaded tests with random memory allocations and with/without
> > cross-thread memory deallocations.
> >
> > Modify the existing DSO used for random memory allocations to avoid
> > getting global locks in the allocation process.
> >
> > The new tests are added to tests-exclude-mcheck as they don't seem
> > to play well with mcheck and I have not been able to find any problem
> > with the tests themselves. Happy to fix anything and/or file an issue
> > in mcheck for further investigation.
> >
> > Changes from v2:
> > - Rephrased some sentences and fixed some typos.
> > - Removed unneeded checks.
> > - Changed the distribution of sizes in random memory allocations.
> >
> > Miguel Martín (2):
> >   malloc: avoid global locks in tst-aligned_alloc-lib.c
> >   malloc: add multi-threaded tests for aligned_alloc/calloc/malloc
> >
> >  malloc/Makefile                               |   8 +
> >  .../tst-aligned-alloc-random-thread-cross.c   |  19 +++
> >  malloc/tst-aligned-alloc-random-thread.c      | 145 ++++++++++++++++++
> >  malloc/tst-aligned_alloc-lib.c                |  39 ++---
> >  4 files changed, 192 insertions(+), 19 deletions(-)
> >  create mode 100644 malloc/tst-aligned-alloc-random-thread-cross.c
> >  create mode 100644 malloc/tst-aligned-alloc-random-thread.c
> >
> > --
> > Miguel Martín
> > mmartinv@redhat.com
> >
> 
> 
>