mbox series

[0/2] nptl: Fix issues with tst-sem11 and tst-sem12 tests

Message ID alpine.DEB.2.21.2407111329350.38148@angie.orcam.me.uk
Headers show
Series nptl: Fix issues with tst-sem11 and tst-sem12 tests | expand

Message

Maciej W. Rozycki July 11, 2024, 1:17 p.m. UTC 
Hi,

 In the course of verifying changes for the BZ #27650 test case, posted 
separately, I have come across a couple of tests hanging forever that 
cause `mips-linux-gnu' (o32 ABI) testing to never complete unless the 
offending tests are killed by hand.

 This mini patch series addresses this issue for the tst-sem11 and 
tst-sem12 tests, by converting them to use the test driver.  As there's 
also an issue with a missing copyright notice with these tests this is 
addressed with 1/2, followed by the actual code fix in 2/2.  It is perhaps 
worth noting that these tests were committed along with tst-sem10, which 
hasn't suffered from either of these issues ever since the beginning.

 This has been verified with the `powerpc64le-linux-gnu' (IBM POWER9) 
native target and then the same host and the `riscv64-linux-gnu' (SiFive 
FU740) and `mips-linux-gnu' (o32 ABI) (MIPS 74Kf) targets.  The tests 
still hang with the latter target, but they are killed automatically by 
the test driver and therefore fail gracefully.

 NB these tests also fail with the `alpha-linux-gnu' (DEC 21064A, EV45) 
target, but in this case they both segfault instead, so the failure is 
harmless to the remaining testing.

 I'll commit 1/2 as obviously correct unless I hear objections in the next 
couple of days.  OK for 2/2 (either now or past the freeze period)?

  Maciej

Comments

Andreas K. Huettel July 11, 2024, 1:40 p.m. UTC | #1 
OK for 2.40 with someone's R-B (but lgtm)

Am Donnerstag, 11. Juli 2024, 15:17:09 CEST schrieb Maciej W. Rozycki:
> Hi,
> 
>  In the course of verifying changes for the BZ #27650 test case, posted 
> separately, I have come across a couple of tests hanging forever that 
> cause `mips-linux-gnu' (o32 ABI) testing to never complete unless the 
> offending tests are killed by hand.
> 
>  This mini patch series addresses this issue for the tst-sem11 and 
> tst-sem12 tests, by converting them to use the test driver.  As there's 
> also an issue with a missing copyright notice with these tests this is 
> addressed with 1/2, followed by the actual code fix in 2/2.  It is perhaps 
> worth noting that these tests were committed along with tst-sem10, which 
> hasn't suffered from either of these issues ever since the beginning.
> 
>  This has been verified with the `powerpc64le-linux-gnu' (IBM POWER9) 
> native target and then the same host and the `riscv64-linux-gnu' (SiFive 
> FU740) and `mips-linux-gnu' (o32 ABI) (MIPS 74Kf) targets.  The tests 
> still hang with the latter target, but they are killed automatically by 
> the test driver and therefore fail gracefully.
> 
>  NB these tests also fail with the `alpha-linux-gnu' (DEC 21064A, EV45) 
> target, but in this case they both segfault instead, so the failure is 
> harmless to the remaining testing.
> 
>  I'll commit 1/2 as obviously correct unless I hear objections in the next 
> couple of days.  OK for 2/2 (either now or past the freeze period)?
> 
>   Maciej
>