mbox series

[v2,0/6] gconv configuration parsing cleanups

Message ID 20210622051202.4155709-1-siddhesh@sourceware.org
Headers show
Series gconv configuration parsing cleanups | expand

Message

Siddhesh Poyarekar June 22, 2021, 5:11 a.m. UTC 
This patchset consolidates the file parsing in gconv_conf and
iconvconfig into a single file gconv_parseconfdir.  Also, add a NEWS
item to mention gconv-modules.d since it is a user visible change.

Changes from v1:

- Updated 4/6 to fix dirlen increment and add unused attribute.

Siddhesh Poyarekar (6):
  iconv: Remove alloca use in gconv-modules configuration parsing
  gconv_conf: Remove unused variables
  gconv_conf: Split out configuration file processing
  iconvconfig: Use common gconv module parsing function
  Handle DT_UNKNOWN in gconv-modules.d
  Add NEWS item for gconv-modules.d change

 NEWS                       |   8 ++
 iconv/gconv_conf.c         | 142 ++-----------------------------
 iconv/gconv_parseconfdir.h | 168 +++++++++++++++++++++++++++++++++++++
 iconv/iconvconfig.c        | 123 +++------------------------
 4 files changed, 197 insertions(+), 244 deletions(-)
 create mode 100644 iconv/gconv_parseconfdir.h

Comments

Andreas Schwab June 24, 2021, 8:46 a.m. UTC | #1 
I'm now getting an assertion failure on all big-endian platforms.

https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc:testsuite/p/ppc
https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc:testsuite/p/ppc64
https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc:testsuite/s/s390x

msgfmt: gconv_builtin.c:70: __gconv_get_builtin_trans: Assertion `cnt < sizeof (map) / sizeof (map[0])' failed.

Andreas.
Siddhesh Poyarekar June 24, 2021, 9:18 a.m. UTC | #2 
On 6/24/21 2:16 PM, Andreas Schwab wrote:
> I'm now getting an assertion failure on all big-endian platforms.
> 
> https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc:testsuite/p/ppc
> https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc:testsuite/p/ppc64
> https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc:testsuite/s/s390x
> 
> msgfmt: gconv_builtin.c:70: __gconv_get_builtin_trans: Assertion `cnt < sizeof (map) / sizeof (map[0])' failed.

I'll take a look.  Were you able to figure out which of the tests threw 
this assertion?

Thanks,
Siddhesh
Andreas Schwab June 24, 2021, 9:23 a.m. UTC | #3 
On Jun 24 2021, Siddhesh Poyarekar wrote:

> I'll take a look.  Were you able to figure out which of the tests threw
> this assertion?

It's msgfmt.

Andreas.
Siddhesh Poyarekar June 24, 2021, 3:33 p.m. UTC | #4 
On 6/24/21 2:53 PM, Andreas Schwab wrote:
> On Jun 24 2021, Siddhesh Poyarekar wrote:
> 
>> I'll take a look.  Were you able to figure out which of the tests threw
>> this assertion?
> 
> It's msgfmt.


Ahh, so it's failing in the installed glibc, i.e. you mean the installed 
glibc has these patches already?  I'll see if I can reproduce this in 
Fedora.

Siddhesh
Andreas Schwab June 24, 2021, 3:46 p.m. UTC | #5 
On Jun 24 2021, Siddhesh Poyarekar wrote:

> Ahh, so it's failing in the installed glibc, i.e. you mean the installed
> glibc has these patches already?

Yes, the testsuite build is run with the just built glibc in the build
environment.  I couldn't reproduce the error with the testrun.sh script.

Andreas.
Siddhesh Poyarekar June 24, 2021, 3:57 p.m. UTC | #6 
On 6/24/21 9:16 PM, Andreas Schwab wrote:
> On Jun 24 2021, Siddhesh Poyarekar wrote:
> 
>> Ahh, so it's failing in the installed glibc, i.e. you mean the installed
>> glibc has these patches already?
> 
> Yes, the testsuite build is run with the just built glibc in the build
> environment.  I couldn't reproduce the error with the testrun.sh script.


Me neither, even with bare elf/ld.so so that it picks the system 
gconv_path.  I've got a build going now, so I'll see what I can find.

Siddhesh