From patchwork Sun Mar 24 12:21:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konstantin Kharlamov X-Patchwork-Id: 1063128 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-100856-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=yandex.ru Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="M7K6ezpH"; dkim=pass (1024-bit key; unprotected) header.d=yandex.ru header.i=@yandex.ru header.b="T763ccyb"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44RxN11bW1z9sSV for ; Sun, 24 Mar 2019 23:21:52 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-transfer-encoding; q=dns; s=default; b=pR7Q7vHItM9g5/Yk 22ai75pU/k5g2fdyjm6YCvBnR8a4vYv+mGUFygKdNziJjHLcnV34N90RmR+KFBW+ XSTkbELmRzJmjYLR637svxzdZiINFRMMheSFOQn/DnkspR+bI7fJC/DOC0AtrIFq YlLjE+C0eub9OSe2Wa8F9zH1l3c= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-transfer-encoding; s=default; bh=1PvhJOFxf7ZOoHJssbOcj5 +Pt9E=; b=M7K6ezpHpLuh5lK1kkBWIxv9jf2fhqxfKq6sB98RskM/J4PYrM/rwt LP7ift62QRyWt/Sm5CT2NBycvsCLKEaSrH4byOYCq6pSPjD2hpO/Xh1Iqx5obalY bdiFHhugpTCmVPGHNY/UQyoYCttq6aGguKaKw57eKfQDVPiOPknd8= Received: (qmail 3740 invoked by alias); 24 Mar 2019 12:21:36 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 3720 invoked by uid 89); 24 Mar 2019 12:21:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.6 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_2, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1056, H*MI:yandex, H*F:D*ru, HContent-Transfer-Encoding:8bit X-HELO: forward102p.mail.yandex.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1553430090; bh=JVsl2E/HnjBPAjGGfEnhaVq6Ql22mIy1g3IICDSApoQ=; h=Subject:To:From:Date:Message-Id; b=T763ccybSW6I3xvsSR775UZqNc1VCE2fUYQvkDFXpwqaEfrp6R9zkiU7cgkJkdAR7 Et05wBvBpy6I7tcKpXl0jD8I76JfgFfUSNcQKjiZKvyouQm3RZINsWowP/M5WvWUrr Jl7cCKyLDvPUr1SbOeI+rtndzwfcpftZ/dDrnOYs= Authentication-Results: mxback6g.mail.yandex.net; dkim=pass header.i=@yandex.ru From: Konstantin Kharlamov To: libc-alpha@sourceware.org Subject: [PATCH 0/5] Minor LGTM fixes Date: Sun, 24 Mar 2019 15:21:16 +0300 Message-Id: <20190324122121.6430-1-Hi-Angel@yandex.ru> MIME-Version: 1.0 This series addresses some of LGTM warnings. Source: https://lgtm.com/projects/g/bminor/glibc/alerts/?mode=tree&ruleFocus=7900090 There is still a lot more to be addressed, but I'm just doing a sweep over interesting to me projects and will probably come back to the rest of warnings once this series is merged. I don't have write access to the repository. Konstantin Kharlamov (5): support: don't pass to set_search_path a big struct by value support: don't pass to resolv_test_start a big struct by value nss/grp: don't pass src by value to copy_grp resolv: don't pass struct ns_mst by value python scripts: don't use "==" to compare to None grp/grp-merge.c | 24 +++++++++++------------ grp/grp-merge.h | 2 +- math/gen-tgmath-tests.py | 6 +++--- nptl/nptl-printers.py | 2 +- nss/getXXbyYY_r.c | 6 +++--- resolv/arpa/nameser.h | 2 +- resolv/ns_parse.c | 4 ++-- support/resolv_test.c | 41 ++++++++++++++++++++-------------------- support/resolv_test.h | 2 +- 9 files changed, 44 insertions(+), 45 deletions(-)