mbox series

[v6,0/2] Y2038 support - __time64_t and __tz_convert

Message ID 20180706174854.546-1-albert.aribaud@3adev.fr
Headers show
Series Y2038 support - __time64_t and __tz_convert | expand

Message

Albert ARIBAUD (3ADEV) July 6, 2018, 5:48 p.m. UTC 
The first patch introduces __TIMESIZE (which is the bit size of time_t
at glibc build time, and equals __WORDSIZE except for x32 where __WORDSIZE
is 32 but __TIMESIZE is 64) and __time64_t, the 64-bit counterpart of time_t,
to be used in 64-bit-time implementations of public APIs related to time.
Note that __time64_t replaces internal_time_t previously introduced.

The second patch makes __tz_convert compatible with 64-bit time. This
implies creating 64-bit-time versions of its callers and turning their
original versions into wrappers if they were 32-bit-time.

These patches are functionally tested as part of the whole Y2038 patch
series using the ad hoc framework at https://github.com/3adev/y2038 which
runs tests using times below, at and beyond the Y2038 limit.

These patches were also run through build-many-glibcs.py to ensure that
existing glibc configurations are not broken. The minimal configuration
set is x86_64-linux-gnu, aarch64-linux-gnu, powerpc-linux-gnu, and
arm-linux-gnueabi.

Albert ARIBAUD (3ADEV) (2):
  Y2038: Add 64-bit time for all architectures
  Y2038: make __tz_convert compatible with 64-bit-time

 bits/timesize.h                              | 23 ++++++++++
 bits/timesizes.h                             | 37 +++++++++++++++
 include/time.h                               | 47 +++++++++++++++-----
 posix/bits/types.h                           |  8 ++++
 stdlib/Makefile                              |  2 +-
 sysdeps/unix/sysv/linux/x86/bits/timesize.h  | 26 +++++++++++
 sysdeps/unix/sysv/linux/x86/bits/timesizes.h | 40 +++++++++++++++++
 time/ctime.c                                 | 17 ++++++-
 time/ctime_r.c                               | 19 ++++++--
 time/gmtime.c                                | 39 +++++++++++++---
 time/localtime.c                             | 36 +++++++++++++--
 time/offtime.c                               | 12 ++---
 time/tzfile.c                                | 32 ++++++-------
 time/tzset.c                                 | 30 +++++--------
 14 files changed, 299 insertions(+), 69 deletions(-)
 create mode 100644 bits/timesize.h
 create mode 100644 bits/timesizes.h
 create mode 100644 sysdeps/unix/sysv/linux/x86/bits/timesize.h
 create mode 100644 sysdeps/unix/sysv/linux/x86/bits/timesizes.h

Comments

Paul Eggert July 7, 2018, 8:48 p.m. UTC | #1 
These patches look good to me; thanks.