diff mbox

Fix 64-bit Solaris 2/x86 IE TLS code sequence (PR target/43309)

Message ID yddy66wen6g.fsf@manam.CeBiTec.Uni-Bielefeld.DE
State New
Headers show

Commit Message

Rainer Orth Jan. 7, 2011, 3:41 p.m. UTC 
Uros Bizjak <ubizjak@gmail.com> writes:

>> Ok for mainline now and the obvious backport (replacing define_c_enum
>> with define_constants) for the 4.4 and 4.5 branches after testing?
>
>>       PR target/43309
>>       * config/i386/i386.c (legitimize_tls_address)
>>       <TLS_MODEL_INITIAL_EXEC>: Handle TARGET_64BIT && TARGET_SUN_TLS.
>>       * config/i386/i386.md (UNSPEC_TLS_IE_SUN): Declare.
>>       (tls_initial_exec_64_sun): New pattern.
>
> Yes, this is OK everywhere.

The change mentioned above was sufficient for the 4.5 backport, for the
4.4 branch I needed to backport another patch that provides
TARGET_SUN_TLS.

Bootstrapped without regressions on i386-pc-solaris2.10 with Sun as
(where Sun as TLS support has been implemented) on the 4.5 branch, and
on i386-pc-solaris2.10 with gas (no Sun as TLS support) on the 4.4
branch.

Here's the patch I commited to the 4.4 branch; the 4.5 backport is just
a subset.

Thanks.
	Rainer


2011-01-07  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	Backport from mainline:
	2011-01-06  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	PR target/43309
	* config/i386/i386.c (legitimize_tls_address)
	<TLS_MODEL_INITIAL_EXEC>: Handle TARGET_64BIT && TARGET_SUN_TLS.
	* config/i386/i386.md (UNSPEC_TLS_IE_SUN): Declare.
	(tls_initial_exec_64_sun): New pattern.

	2010-03-24  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* config/i386/i386.c (override_options): Don't accept
	-mtls-dialect=sun any longer.
	* config/i386/i386.h (TARGET_SUN_TLS): Define as 0.
	* config/i386/i386.md (*tls_global_dynamic_32_sun): Remove.
	(*tls_local_dynamic_base_32_sun): Likewise.
	* config/i386/sol2.h (TARGET_SUN_TLS): Redefine.

Comments

Uros Bizjak Jan. 7, 2011, 5:44 p.m. UTC | #1 
On Fri, Jan 7, 2011 at 4:41 PM, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:

> 2011-01-07  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>
>        Backport from mainline:
>        2011-01-06  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>
>        PR target/43309
>        * config/i386/i386.c (legitimize_tls_address)
>        <TLS_MODEL_INITIAL_EXEC>: Handle TARGET_64BIT && TARGET_SUN_TLS.
>        * config/i386/i386.md (UNSPEC_TLS_IE_SUN): Declare.
>        (tls_initial_exec_64_sun): New pattern.
>
>        2010-03-24  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>
>        * config/i386/i386.c (override_options): Don't accept
>        -mtls-dialect=sun any longer.
>        * config/i386/i386.h (TARGET_SUN_TLS): Define as 0.
>        * config/i386/i386.md (*tls_global_dynamic_32_sun): Remove.
>        (*tls_local_dynamic_base_32_sun): Likewise.
>        * config/i386/sol2.h (TARGET_SUN_TLS): Redefine.

OK.

Thanks,
Uros.
diff mbox

Patch

diff -r 6f55ec0912e2 gcc/config/i386/i386.c
--- a/gcc/config/i386/i386.c	Thu Jan 06 21:03:28 2011 +0100
+++ b/gcc/config/i386/i386.c	Fri Jan 07 16:24:27 2011 +0100
@@ -2999,8 +2999,6 @@ 
 	ix86_tls_dialect = TLS_DIALECT_GNU;
       else if (strcmp (ix86_tls_dialect_string, "gnu2") == 0)
 	ix86_tls_dialect = TLS_DIALECT_GNU2;
-      else if (strcmp (ix86_tls_dialect_string, "sun") == 0)
-	ix86_tls_dialect = TLS_DIALECT_SUN;
       else
 	error ("bad value (%s) for %stls-dialect=%s %s",
 	       ix86_tls_dialect_string, prefix, suffix, sw);
@@ -9869,6 +9867,17 @@ 
     case TLS_MODEL_INITIAL_EXEC:
       if (TARGET_64BIT)
 	{
+	  if (TARGET_SUN_TLS)
+	    {
+	      /* The Sun linker took the AMD64 TLS spec literally
+		 and can only handle %rax as destination of the
+		 initial executable code sequence.  */
+
+	      dest = gen_reg_rtx (Pmode);
+	      emit_insn (gen_tls_initial_exec_64_sun (dest, x));
+	      return dest;
+	    }
+
 	  pic = NULL;
 	  type = UNSPEC_GOTNTPOFF;
 	}
diff -r 6f55ec0912e2 gcc/config/i386/i386.h
--- a/gcc/config/i386/i386.h	Thu Jan 06 21:03:28 2011 +0100
+++ b/gcc/config/i386/i386.h	Fri Jan 07 16:24:27 2011 +0100
@@ -1,6 +1,6 @@ 
 /* Definitions of target machine for GCC for IA-32.
    Copyright (C) 1988, 1992, 1994, 1995, 1996, 1997, 1998, 1999, 2000,
-   2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009
+   2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010
    Free Software Foundation, Inc.
 
 This file is part of GCC.
@@ -422,7 +422,7 @@ 
 #define TARGET_GNU_TLS		(ix86_tls_dialect == TLS_DIALECT_GNU)
 #define TARGET_GNU2_TLS		(ix86_tls_dialect == TLS_DIALECT_GNU2)
 #define TARGET_ANY_GNU_TLS	(TARGET_GNU_TLS || TARGET_GNU2_TLS)
-#define TARGET_SUN_TLS		(ix86_tls_dialect == TLS_DIALECT_SUN)
+#define TARGET_SUN_TLS		0
 
 extern int ix86_isa_flags;
 
diff -r 6f55ec0912e2 gcc/config/i386/i386.md
--- a/gcc/config/i386/i386.md	Thu Jan 06 21:03:28 2011 +0100
+++ b/gcc/config/i386/i386.md	Fri Jan 07 16:24:27 2011 +0100
@@ -1,6 +1,6 @@ 
 ;; GCC machine description for IA-32 and x86-64.
 ;; Copyright (C) 1988, 1994, 1995, 1996, 1997, 1998, 1999, 2000,
-;; 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009
+;; 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010
 ;; Free Software Foundation, Inc.
 ;; Mostly by William Schelter.
 ;; x86_64 support added by Jan Hubicka
@@ -75,6 +75,7 @@ 
    (UNSPEC_TLS_GD		21)
    (UNSPEC_TLS_LD_BASE		22)
    (UNSPEC_TLSDESC		23)
+   (UNSPEC_TLS_IE_SUN		24)
 
    ; Other random patterns
    (UNSPEC_EH_RETURN		29)
@@ -15889,21 +15890,6 @@ 
   [(set_attr "type" "multi")
    (set_attr "length" "12")])
 
-(define_insn "*tls_global_dynamic_32_sun"
-  [(set (match_operand:SI 0 "register_operand" "=a")
-	(unspec:SI [(match_operand:SI 1 "register_operand" "b")
-		    (match_operand:SI 2 "tls_symbolic_operand" "")
-		    (match_operand:SI 3 "call_insn_operand" "")]
-		    UNSPEC_TLS_GD))
-   (clobber (match_scratch:SI 4 "=d"))
-   (clobber (match_scratch:SI 5 "=c"))
-   (clobber (reg:CC FLAGS_REG))]
-  "!TARGET_64BIT && TARGET_SUN_TLS"
-  "lea{l}\t{%a2@DTLNDX(%1), %4|%4, %a2@DTLNDX[%1]}
-	push{l}\t%4\;call\t%a2@TLSPLT\;pop{l}\t%4\;nop"
-  [(set_attr "type" "multi")
-   (set_attr "length" "14")])
-
 (define_expand "tls_global_dynamic_32"
   [(parallel [(set (match_operand:SI 0 "register_operand" "")
 		   (unspec:SI
@@ -15972,20 +15958,6 @@ 
   [(set_attr "type" "multi")
    (set_attr "length" "11")])
 
-(define_insn "*tls_local_dynamic_base_32_sun"
-  [(set (match_operand:SI 0 "register_operand" "=a")
-	(unspec:SI [(match_operand:SI 1 "register_operand" "b")
-                    (match_operand:SI 2 "call_insn_operand" "")]
-		   UNSPEC_TLS_LD_BASE))
-   (clobber (match_scratch:SI 3 "=d"))
-   (clobber (match_scratch:SI 4 "=c"))
-   (clobber (reg:CC FLAGS_REG))]
-  "!TARGET_64BIT && TARGET_SUN_TLS"
-  "lea{l}\t{%&@TMDNX(%1), %3|%3, %&@TMDNX[%1]}
-	push{l}\t%3\;call\t%&@TLSPLT\;pop{l}\t%3"
-  [(set_attr "type" "multi")
-   (set_attr "length" "13")])
-
 (define_expand "tls_local_dynamic_base_32"
   [(parallel [(set (match_operand:SI 0 "register_operand" "")
 		   (unspec:SI [(match_dup 1) (match_dup 2)]
@@ -16111,6 +16083,18 @@ 
    (set_attr "memory" "load")
    (set_attr "imm_disp" "false")])
 
+;; The Sun linker took the AMD64 TLS spec literally and can only handle
+;; %rax as destination of the initial executable code sequence.
+(define_insn "tls_initial_exec_64_sun"
+  [(set (match_operand:DI 0 "register_operand" "=a")
+	(unspec:DI
+	 [(match_operand:DI 1 "tls_symbolic_operand" "")]
+	 UNSPEC_TLS_IE_SUN))
+   (clobber (reg:CC FLAGS_REG))]
+  "TARGET_64BIT && TARGET_SUN_TLS"
+  "mov{q}\t{%%fs:0, %0|%0, QWORD PTR fs:0}\n\tadd{q}\t{%a1@gottpoff(%%rip), %0|%0, %a1@gottpoff[rip]}"
+  [(set_attr "type" "multi")])
+
 ;; GNU2 TLS patterns can be split.
 
 (define_expand "tls_dynamic_gnu2_32"
diff -r 6f55ec0912e2 gcc/config/i386/sol2.h
--- a/gcc/config/i386/sol2.h	Thu Jan 06 21:03:28 2011 +0100
+++ b/gcc/config/i386/sol2.h	Fri Jan 07 16:24:27 2011 +0100
@@ -91,6 +91,11 @@ 
       }							\
   } while (0)
 
+/* Follow Sun requirements for TLS code sequences and use Sun assembler TLS
+   syntax.  */
+#undef TARGET_SUN_TLS
+#define TARGET_SUN_TLS 1
+
 /* The Solaris assembler cannot grok .stabd directives.  */
 #undef NO_DBX_BNSYM_ENSYM
 #define NO_DBX_BNSYM_ENSYM 1