diff mbox series

testsuite: go: Require split-stack support for go.test/test/index0.go [PR87589]

Message ID yddv82m892x.fsf@CeBiTec.Uni-Bielefeld.DE
State New
Headers show
Series testsuite: go: Require split-stack support for go.test/test/index0.go [PR87589] | expand

Commit Message

Rainer Orth June 6, 2024, 2 p.m. UTC
The index0-out.go test FAILs on Solaris (SPARC and x86, 32 and 64-bit),
as well as several others:

FAIL: ./index0-out.go execution,  -O0 -g -fno-var-tracking-assignments 

The test SEGVs because it tries a stack acess way beyond the stack
area.  As Ian analyzed in the PR, the testcase currently requires
split-stack support, so this patch requires just that.

Tested on i386-pc-solaris2.11 and sparc-sun-solaris2.11.

Ok for trunk?

	Rainer

Comments

Ian Lance Taylor June 6, 2024, 9:50 p.m. UTC | #1
On Thu, Jun 6, 2024 at 7:00 AM Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>
> The index0-out.go test FAILs on Solaris (SPARC and x86, 32 and 64-bit),
> as well as several others:
>
> FAIL: ./index0-out.go execution,  -O0 -g -fno-var-tracking-assignments
>
> The test SEGVs because it tries a stack acess way beyond the stack
> area.  As Ian analyzed in the PR, the testcase currently requires
> split-stack support, so this patch requires just that.
>
> Tested on i386-pc-solaris2.11 and sparc-sun-solaris2.11.
>
> Ok for trunk?
>
>         Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>
>
> 2024-06-05  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>
>         gcc/testsuite:
>         PR go/87589
>         * go.test/go-test.exp (go-gc-tests): Require split-stack support
>         for index0.go.



This is OK.  Thanks.

Ian
diff mbox series

Patch

# HG changeset patch
# Parent  f29c8ac19b89d7ed6c5d957b99e03c8a387f6c31
testsuite: go: Require split-stack support for go.test/test/index0.go [PR87589]

diff --git a/gcc/testsuite/go.test/go-test.exp b/gcc/testsuite/go.test/go-test.exp
--- a/gcc/testsuite/go.test/go-test.exp
+++ b/gcc/testsuite/go.test/go-test.exp
@@ -477,7 +477,8 @@  proc go-gc-tests { } {
 	if { ( [file tail $test] == "select2.go" \
 		   || [file tail $test] == "stack.go" \
 		   || [file tail $test] == "peano.go" \
-		   || [file tail $test] == "nilptr2.go" ) \
+		   || [file tail $test] == "nilptr2.go" \
+		   || [file tail $test] == "index0.go" ) \
 		 && ! [check_effective_target_split_stack] } {
 	    # These tests fails on targets without split stack.
 	    untested $name