| Message ID | yddsjtfo4vh.fsf@manam.CeBiTec.Uni-Bielefeld.DE |
|---|---|
| State | New |
| Headers | show |
David, >> Thanks Rainer, if you cons up a patch to add the ".align" directive I'll ACK >> that as well. > > here's the patch that I've been testing over the weekend. It caused no > change for HAVE_AS_SPARC_GOTDATA_OP on anything but Solaris 10 with gas > and Sun ld, where HAVE_AS_SPARC_GOTDATA_OP is 1 now, and that > configuration showed no testsuite regressions. > > Ok for mainline? it's been a week since I've submitted this patch. Or should I take it as preapproved? Thanks. Rainer > 2011-04-15 David S. Miller <davem@davemloft.net> > Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> > > * configure.ac (gcc_cv_as_sparc_gotdata_op): Specify alignment. > * configure: Regenerate. > > diff --git a/gcc/configure.ac b/gcc/configure.ac > --- a/gcc/configure.ac > +++ b/gcc/configure.ac > @@ -3270,6 +3270,7 @@ case "$target" in > gcc_cv_as_sparc_gotdata_op,, > [-K PIC], > [.text > +.align 4 > foo: > nop > bar:
On 04/26/2011 05:25 PM, Rainer Orth wrote: > David, > >>> Thanks Rainer, if you cons up a patch to add the ".align" directive I'll ACK >>> that as well. >> >> here's the patch that I've been testing over the weekend. It caused no >> change for HAVE_AS_SPARC_GOTDATA_OP on anything but Solaris 10 with gas >> and Sun ld, where HAVE_AS_SPARC_GOTDATA_OP is 1 now, and that >> configuration showed no testsuite regressions. >> >> Ok for mainline? > > it's been a week since I've submitted this patch. Or should I take it > as preapproved? > > Thanks. > Rainer > > >> 2011-04-15 David S. Miller<davem@davemloft.net> >> Rainer Orth<ro@CeBiTec.Uni-Bielefeld.DE> >> >> * configure.ac (gcc_cv_as_sparc_gotdata_op): Specify alignment. >> * configure: Regenerate. >> >> diff --git a/gcc/configure.ac b/gcc/configure.ac >> --- a/gcc/configure.ac >> +++ b/gcc/configure.ac >> @@ -3270,6 +3270,7 @@ case "$target" in >> gcc_cv_as_sparc_gotdata_op,, >> [-K PIC], >> [.text >> +.align 4 >> foo: >> nop >> bar: > I was waiting for David or Eric to approve it since I know nothing about this stuff. :) Paolo
From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> Date: Tue, 26 Apr 2011 17:25:56 +0200 > David, > >>> Thanks Rainer, if you cons up a patch to add the ".align" directive I'll ACK >>> that as well. >> >> here's the patch that I've been testing over the weekend. It caused no >> change for HAVE_AS_SPARC_GOTDATA_OP on anything but Solaris 10 with gas >> and Sun ld, where HAVE_AS_SPARC_GOTDATA_OP is 1 now, and that >> configuration showed no testsuite regressions. >> >> Ok for mainline? > > it's been a week since I've submitted this patch. Or should I take it > as preapproved? > I'm sorry about this, I must have missed it inadvertantly. ACK to this patch, thanks for your contributions.
diff --git a/gcc/configure.ac b/gcc/configure.ac --- a/gcc/configure.ac +++ b/gcc/configure.ac @@ -3270,6 +3270,7 @@ case "$target" in gcc_cv_as_sparc_gotdata_op,, [-K PIC], [.text +.align 4 foo: nop bar: