From patchwork Wed Oct 8 11:06:50 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 397616 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 27322140082 for ; Wed, 8 Oct 2014 22:07:05 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; q=dns; s=default; b=pEGNg51ebFLckvSe drL0CVvJTlrDnv4gS0vrUnjpr6BCcA06fIwHhob6935PMIFMvfdFZ8Hgd4MsHCtN NapZzgqgdaWQZsMf2JJTzhsfA7Eju30D+G6XWA9ugUEynVzzLt/t462IUhvNdLgG 2N6Zs5/Xl/Tg5+XIbFxUcHx5bbg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; s=default; bh=Tk61nBNFn5hZQiqqWwPpMa kU5P0=; b=XuDrfjegW/D/y3eAkoHR3uwenvAy1+KbYYZKVz8jfBQowYKeqQD3kI AMJ+FyY3qtRFFLqXx2Mxx97XmoeptAKjzdKyDEvPXImHUL/KZVsaczvwmheH8Xlc XGk9/BQIVVBVzV/K3u834nmU2jcalUA2f5KQU0y9UZyKmYTERHm4E= Received: (qmail 12379 invoked by alias); 8 Oct 2014 11:06:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 12369 invoked by uid 89); 8 Oct 2014 11:06:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp-relay.CeBiTec.Uni-Bielefeld.DE Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Oct 2014 11:06:56 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 8FFA9A5B; Wed, 8 Oct 2014 13:06:53 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id F2e-jokuQ8Fb; Wed, 8 Oct 2014 13:06:51 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.110]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 55682A5A; Wed, 8 Oct 2014 13:06:51 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.14.7+Sun/8.14.7/Submit) id s98B6pLi027266; Wed, 8 Oct 2014 13:06:51 +0200 (MEST) From: Rainer Orth To: Marek Polacek Cc: GCC Patches Subject: Re: [PATCH] gcc.dg/torture/ cleanup References: <20141002130946.GH32230@redhat.com> Date: Wed, 08 Oct 2014 13:06:50 +0200 In-Reply-To: <20141002130946.GH32230@redhat.com> (Marek Polacek's message of "Thu, 2 Oct 2014 15:09:46 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Marek Polacek writes: > This patch is a cleanup of tests in gcc.dg/torture directory. > See https://gcc.gnu.org/ml/gcc-patches/2014-09/msg02656.html for more info. > > Tested on x86_64-linux: vanilla results == results with this patch == > results with this patch and gnu11 as a default. > > Ok? > > 2014-10-02 Marek Polacek > > * gcc.dg/torture/pr24626-2.c: Add function declarations. Fix > defaulting to int. [...] > * gcc.dg/torture/stackalign/builtin-apply-4.c: Use -fgnu89-inline. [...] > diff --git gcc/gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-4.c gcc/gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-4.c > index 28dc610..d958293 100644 > --- gcc/gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-4.c > +++ gcc/gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-4.c > @@ -1,5 +1,6 @@ > /* PR tree-optimization/20076 */ > /* { dg-do run } */ > +/* { dg-options "-fgnu89-inline" } */ > > extern void abort (void); > This patch completely broke the builtin-apply-4.c execution tests on Solaris 11/x86 (and undoubtedly on many other platforms). stackalign.exp has this comment: # default_flags are replaced by a dg-options test directive, or appended # to by using dg-additional-options. Use default_flags for options that # are used in all of the torture sets to limit the amount of noise in # test summaries. set default_flags "" and by using dg-options in the testcase, you override everything in default_flags ;-( Switching to dg-additional-options fixes the problem, as tested with the appropriate runtest invocation on i386-pc-solaris2.11. Installed on mainline. Rainer 2014-10-08 Rainer Orth * gcc.dg/torture/stackalign/builtin-apply-4.c: Use dg-additional-options. diff --git a/gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-4.c b/gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-4.c --- a/gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-4.c +++ b/gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-4.c @@ -1,6 +1,6 @@ /* PR tree-optimization/20076 */ /* { dg-do run } */ -/* { dg-options "-fgnu89-inline" } */ +/* { dg-additional-options "-fgnu89-inline" } */ extern void abort (void);