From patchwork Thu Mar 31 20:06:49 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 604283 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qbbCD3sBkz9s5g for ; Fri, 1 Apr 2016 07:07:19 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=Th23a5ar; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; q=dns; s=default; b=Or6ELRu7NrxjnYN/ r8jFyfHU7XphzamnnjFkRYDhBkilCafCCe6rFUhswIobXOWtLk6drLc02NBXZ2CO IPpgIEzcISrg/facyKCDSNJB15iS6/+Y5qr0zL0yu/hx0ivu+iLovQ6bf7aIkUDW CoHTLEgxBmA2bePOs20M+uBrX8k= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; s=default; bh=GcSisQNsc48HqVj9EF6n/T 5Zwog=; b=Th23a5arIcJ2RrqGrQ33Aju7tSbdyThIZYZTVYIQNj40778XZ+81TJ F8ATwxPeU2bmT7Bk1DjObFxFJTBP2l0JINcuWXsQhPPmpzj6tj4rHnhYFiClbsS6 fjlXdM/F8xTL47nLExGTm/Z6UOsV+NpEWoMAlZX0tw1/Sc98RayLA= Received: (qmail 106710 invoked by alias); 31 Mar 2016 20:07:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 106694 invoked by uid 89); 31 Mar 2016 20:07:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Holder X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 Mar 2016 20:07:01 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 49A7CFDE; Thu, 31 Mar 2016 22:06:58 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id y+g7t1+c8hHw; Thu, 31 Mar 2016 22:06:56 +0200 (CEST) Received: from fuego.CeBiTec.Uni-Bielefeld.DE (p5DCE15D1.dip0.t-ipconnect.de [93.206.21.209]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 47EC3FDC; Thu, 31 Mar 2016 22:06:56 +0200 (CEST) From: Rainer Orth To: Jason Merrill Cc: Patrick Palka , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix PR c++/70096 (wrong code for pointer-to-member-function copy) References: <1458599726-11471-1-git-send-email-patrick@parcs.ath.cx> <56F0A177.9000902@redhat.com> Date: Thu, 31 Mar 2016 22:06:49 +0200 In-Reply-To: <56F0A177.9000902@redhat.com> (Jason Merrill's message of "Mon, 21 Mar 2016 21:35:51 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Jason Merrill writes: > OK. The testcase FAILs on Solaris with the native ld: FAIL: g++.dg/template/ptrmem30.C -std=c++11 (test for excess errors) FAIL: g++.dg/template/ptrmem30.C -std=c++14 (test for excess errors) FAIL: g++.dg/template/ptrmem30.C -std=c++98 (test for excess errors) Excess errors: ld: warning: symbol 'read' has differing types: (file /var/tmp//ccXQGwka.o type=OBJT; file /lib/libc.so type=FUNC); /var/tmp//ccXQGwka.o definition taken Fixed as follows. Tested with the appropriate runtest invocation on i386-pc-solaris2.12 and x86_64-pc-linux-gnu, installed on mainline. Rainer 2016-03-31 Rainer Orth * g++.dg/template/ptrmem30.C (read): Rename to data_read. (Holder::foo): Reflect this. # HG changeset patch # Parent fb299874d0c97ca07d2d329ba94ff195243f2499 Fix g++.dg/template/ptrmem30.C with Solaris ld diff --git a/gcc/testsuite/g++.dg/template/ptrmem30.C b/gcc/testsuite/g++.dg/template/ptrmem30.C --- a/gcc/testsuite/g++.dg/template/ptrmem30.C +++ b/gcc/testsuite/g++.dg/template/ptrmem30.C @@ -1,11 +1,11 @@ // PR c++/70096 // { dg-do run } -int read; +int data_read; struct Holder { - void foo () { read = data; } + void foo () { data_read = data; } int data; };