| Message ID | yddk37rk15p.fsf@CeBiTec.Uni-Bielefeld.DE |
|---|---|
| State | New |
| Headers | show |
Sorry, I was going to fix this. Thank you very much!
--
Cheers, Roman Gareev
On 05/07/14 21:20, Rainer Orth wrote: > Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes: > >> Roman Gareev <gareevroman@gmail.com> writes: >> >>>> It seems the patch1/patch2 files you attach have the Content-Type: >>>> application/octet-stream. This makes it impossible to view them inline. >>>> Could you send them as text files? Just calling them patch1.patch or >>>> patch1.txt should make this work. >>> Yes, sure. >> This patch broke bootstrap with --enable-cloog-backend=isl when using >> isl 0.10: >> >> /vol/gcc/src/hg/trunk/local/gcc/graphite-isl-ast-to-gimple.c:27:27: fatal error: isl/ast_build.h: No such file or directory >> compilation terminated. >> make[3]: *** [graphite-isl-ast-to-gimple.o] Error 1 >> >> <isl/ast_build.h> is missing in in isl 0.10. Seems it was introduced in >> 0.11, but no idea if that works. >> >> Toplevel configure.ac accepts 0.10, while install.texi states 0.12.2 is >> required. Configuration and/or docs should be changed to match reality. > I've now commited the following patch as obvious: it requires isl 0.11 > which is the first that includes isl/ast_build.h. I'm seeing the error: gcc/graphite-isl-ast-to-gimple.c:31:25: warning: isl/val_gmp.h: No such file or directory when building for aarch64. isl/val_gmp.h is included in 0.12 AFAICS so perhaps we should demand 0.12 instead of 0.11 ? Kyrill > > Bootstrapped on i386-pc-solaris2.11 with isl 0.12.2. > > Rainer > > > 2014-07-05 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> > > * configure.ac: Don't accept isl 0.10. > * configure: Regenerate.
> I'm seeing the error: > > gcc/graphite-isl-ast-to-gimple.c:31:25: warning: isl/val_gmp.h: No such file > or directory > > when building for aarch64. > > isl/val_gmp.h is included in 0.12 AFAICS so perhaps we should demand 0.12 > instead of 0.11 ? According to isl's ChangeLog, isl_val abstraction was added in version 0.12. Therefore, I think it would be right to demand on 0.12. Tobias, what do you think about this? Is this fine for the backend, which uses CLooG to generate Gimple code? -- Cheers, Roman Gareev
On 15/07/2014 17:02, Roman Gareev wrote: >> I'm seeing the error: >> >> gcc/graphite-isl-ast-to-gimple.c:31:25: warning: isl/val_gmp.h: No such file >> or directory >> >> when building for aarch64. >> >> isl/val_gmp.h is included in 0.12 AFAICS so perhaps we should demand 0.12 >> instead of 0.11 ? > > According to isl's ChangeLog, isl_val abstraction was added in version > 0.12. Therefore, I think it would be right to demand on 0.12. > > Tobias, what do you think about this? Is this fine for the backend, > which uses CLooG to generate Gimple code? I think so. The latest release of CLooG (0.18.1) was released with isl 0.12.1 and is part of ftp://gcc.gnu.org/pub/gcc/infrastructure/. So requiring isl 0.12.1 sounds reasonable. Could you prepare such a patch? Cheers, Tobias
On Tue, Jul 15, 2014 at 5:34 PM, Tobias Grosser <tobias@grosser.es> wrote: > On 15/07/2014 17:02, Roman Gareev wrote: >>> >>> I'm seeing the error: >>> >>> gcc/graphite-isl-ast-to-gimple.c:31:25: warning: isl/val_gmp.h: No such >>> file >>> or directory >>> >>> when building for aarch64. >>> >>> isl/val_gmp.h is included in 0.12 AFAICS so perhaps we should demand 0.12 >>> instead of 0.11 ? >> >> >> According to isl's ChangeLog, isl_val abstraction was added in version >> 0.12. Therefore, I think it would be right to demand on 0.12. >> >> Tobias, what do you think about this? Is this fine for the backend, >> which uses CLooG to generate Gimple code? > > > I think so. The latest release of CLooG (0.18.1) was released with isl > 0.12.1 and is part of ftp://gcc.gnu.org/pub/gcc/infrastructure/. So > requiring isl 0.12.1 sounds reasonable. > > Could you prepare such a patch? Note that we also still accept CLooG 0.17.0. Btw, it's unfortunate that ISL 0.13 cannot be used because it dropped some APIs we use (it's important for testing on branches that a single cloog/isl version can be used to bootstrap and test on active branches and trunk). Richard. > Cheers, > Tobias
On 16/07/2014 11:36, Richard Biener wrote: > On Tue, Jul 15, 2014 at 5:34 PM, Tobias Grosser <tobias@grosser.es> wrote: >> On 15/07/2014 17:02, Roman Gareev wrote: >>>> >>>> I'm seeing the error: >>>> >>>> gcc/graphite-isl-ast-to-gimple.c:31:25: warning: isl/val_gmp.h: No such >>>> file >>>> or directory >>>> >>>> when building for aarch64. >>>> >>>> isl/val_gmp.h is included in 0.12 AFAICS so perhaps we should demand 0.12 >>>> instead of 0.11 ? >>> >>> >>> According to isl's ChangeLog, isl_val abstraction was added in version >>> 0.12. Therefore, I think it would be right to demand on 0.12. >>> >>> Tobias, what do you think about this? Is this fine for the backend, >>> which uses CLooG to generate Gimple code? >> >> >> I think so. The latest release of CLooG (0.18.1) was released with isl >> 0.12.1 and is part of ftp://gcc.gnu.org/pub/gcc/infrastructure/. So >> requiring isl 0.12.1 sounds reasonable. >> >> Could you prepare such a patch? > > Note that we also still accept CLooG 0.17.0. In this case we need to update the minimal required CLooG version to CLooG 0.18.1, right? > Btw, it's unfortunate that > ISL 0.13 cannot be used because it dropped some APIs we use > (it's important for testing on branches that a single cloog/isl version > can be used to bootstrap and test on active branches and trunk). Right. I also believe this is very unfortunate. I copy Sven to let him now that dropping APIs too quickly regularly causes issues. Cheers, Tobias
> Could you prepare such a patch?
Yes, I've started working on it.
I have a question about isl. Can we require that isl is always
compiled with GMP support?
--
Cheers, Roman Gareev
On 16/07/2014 14:03, Roman Gareev wrote: >> Could you prepare such a patch? > > Yes, I've started working on it. > > I have a question about isl. Can we require that isl is always > compiled with GMP support? isl 0.12.2 is always compiled with GMP support. Only for the unreleased isl-0.14 imath was introduced as an alternative. Cheers, Tobias
diff --git a/configure.ac b/configure.ac --- a/configure.ac +++ b/configure.ac @@ -1650,12 +1650,9 @@ if test "x$with_isl" != "xno" && dnl with user input. ISL_INIT_FLAGS dnl The versions of ISL that work for Graphite - ISL_CHECK_VERSION(0,10) + ISL_CHECK_VERSION(0,11) if test "${gcc_cv_isl}" = no ; then - ISL_CHECK_VERSION(0,11) - if test "${gcc_cv_isl}" = no ; then - ISL_CHECK_VERSION(0,12) - fi + ISL_CHECK_VERSION(0,12) fi dnl Only execute fail-action, if ISL has been requested. ISL_IF_FAILED([