diff mbox

AutoFDO patch for trunk

Message ID yddh9ywqgid.fsf@lokon.CeBiTec.Uni-Bielefeld.DE
State New
Headers show

Commit Message

Rainer Orth Oct. 22, 2014, 3:19 p.m. UTC 
Dehao Chen <dehao@google.com> writes:

> The updated patch attached. Will commit the patch in 2~3 hours if no
> objection is received.

Apart from the AIX bootstrap failure your patch introduced, it also
breaks Solaris bootstrap:

In file included from ./config.h:6:0,
                 from /vol/gcc/src/hg/trunk/local/gcc/auto-profile.c:25:
./auto-host.h:1976:0: error: "_FILE_OFFSET_BITS" redefined [-Werror]
 #define _FILE_OFFSET_BITS 64
 ^
In file included from /usr/include/iso/string_iso.h:24:0,
                 from /usr/include/string.h:11,
                 from /vol/gcc/src/hg/trunk/local/gcc/auto-profile.c:21:
/var/gcc/regression/trunk/11-gcc/build/prev-gcc/include-fixed/sys/feature_tests.h:213:0: note: this is the location of the previous definition
 #define _FILE_OFFSET_BITS 32
 ^

As Joseph is repeating over and over again, *nothing* must be included
before config.h, and auto-profile.c violates this.

The following patch at least allows the file to compile without errors;
no idea if this the best order for the headers involved.
Rainer
diff mbox

Patch

diff --git a/gcc/auto-profile.c b/gcc/auto-profile.c
--- a/gcc/auto-profile.c
+++ b/gcc/auto-profile.c
@@ -18,12 +18,13 @@  You should have received a copy of the G
 along with GCC; see the file COPYING3.  If not see
 <http://www.gnu.org/licenses/>.  */
 
+#include "config.h"
+#include "system.h"
+
 #include <string.h>
 #include <map>
 #include <set>
 
-#include "config.h"
-#include "system.h"
 #include "coretypes.h"
 #include "tree.h"
 #include "tree-pass.h"