| Message ID | yddh9wt2syt.fsf@lokon.CeBiTec.Uni-Bielefeld.DE |
|---|---|
| State | New |
| Headers | show |
On 18/12/14 09:43, Rainer Orth wrote: > Andreas Schwab <schwab@linux-m68k.org> writes: > >> dominiq@lps.ens.fr (Dominique Dhumieres) writes: >> >>>> Here it is. Committed as r218662 to get things going again. >>> The same change should be done for libitm and libatomic. >> And boehm-gc. > Right, fixed as follows and installed on mainline after testing on > i386-pc-solaris2.11 and sparc-sun-solaris2.11. > > I must say I'm less than impressed how this patch tested actually. Hi Rainer, Sorry about this. I had grepped for includes of gcc-defs.exp in lib*, which missed boehm-gc. Thanks for fixing this, I was away earlier this week. I'll make sure to check the libraries explicitly if I do any testsuite refactoring work in the future Kyrill > > Rainer > > > 2014-12-17 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> > > * testsuite/lib/boehm-gc.exp: Load target-utils.exp.
Hi Kyrill, > Sorry about this. > I had grepped for includes of gcc-defs.exp in lib*, which missed boehm-gc. > Thanks for fixing this, I was away earlier this week. > > I'll make sure to check the libraries explicitly if I do any testsuite > refactoring work in the future great, thanks. I know all too well that it needs a large amount of this do get away from the current copy-and-paste programming pervasive throughout the testsuite. Rainer
# HG changeset patch # Parent db99d18efa0cce3ad66a0cff02fedf946af2a842 Include target-utils.exp in boehm-gc testing diff --git a/boehm-gc/testsuite/lib/boehm-gc.exp b/boehm-gc/testsuite/lib/boehm-gc.exp --- a/boehm-gc/testsuite/lib/boehm-gc.exp +++ b/boehm-gc/testsuite/lib/boehm-gc.exp @@ -27,6 +27,7 @@ load_gcc_lib wrapper.exp load_gcc_lib target-supports.exp # For dg-skip-if. load_gcc_lib target-supports-dg.exp +load_gcc_lib target-utils.exp # For ${tool}_exit. load_gcc_lib gcc-defs.exp # For prune_gcc_output.