From patchwork Mon Jul 25 15:11:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 652324 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ryl963ycJz9s9W for ; Tue, 26 Jul 2016 01:12:08 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=D3tyj6HX; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; q=dns; s=default; b=aoI8ZbOBR6p5qHUY t1v5GdOnePDIVa761uNMYQzSpEcR6LXZ2/b7wiTAdHVizVS2uUxdAqCSf+MwmDOk h4Euv85HYDnI66NRUHhp2zKunrkUM79g76n43SIDIWO/QZgPFPcZPJJ1Kj2fpcWK dPrX//Q5hX/dGmdoBZBrxgjXThU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; s=default; bh=IF0zlfYcGfuBPea6+tS7KN XEbT8=; b=D3tyj6HXcfMzf43Zk9R1slk8OZOaPb5ckbYXWBDTNjFrXApt5FmWu9 UmaB3LIoOHt71LWOC5ZVeMOJakORDZL02CFfNotTazBGwCorZS6505yfd6pVWp6s o2M6hDJSt0vPpOGDyFF6J8Ev1ZyoCg9YKURbczYfDAdaWYcD0JV8k= Received: (qmail 23630 invoked by alias); 25 Jul 2016 15:12:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 23597 invoked by uid 89); 25 Jul 2016 15:12:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Rainer, rainer, H*Ad:D*googlegroups.com X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Jul 2016 15:11:57 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 01643C4D; Mon, 25 Jul 2016 17:11:55 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 2z+ZCE-2URGD; Mon, 25 Jul 2016 17:11:53 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.110]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 01DB1C4C; Mon, 25 Jul 2016 17:11:53 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id u6PFBqnb003770; Mon, 25 Jul 2016 17:11:52 +0200 (CEST) From: Rainer Orth To: Ian Lance Taylor Cc: gcc-patches , "gofrontend-dev\@googlegroups.com" Subject: Re: libgo patch committed: Update to 1.7rc3 References: Date: Mon, 25 Jul 2016 17:11:52 +0200 In-Reply-To: (Ian Lance Taylor's message of "Fri, 22 Jul 2016 11:15:46 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Hi Ian, > I have committed a patch to update libgo to the 1.7rc3 release > candidate. This is very close to the upcoming 1.7 release. As usual > with libgo updates, the patch is too large to include in this e-mail > message. I've appended the changes to the gccgo-specific directories. this broke Solaris bootstrap: /vol/gcc/src/hg/trunk/local/libgo/go/os/user/decls_solaris.go:24:46: error: reference to undefined identifier 'syscall.group' func libc_getgrgid_r(gid syscall.Gid_t, grp *syscall.group, buf *byte, buflen syscall.Size_t, result **syscall.group) int ^ /vol/gcc/src/hg/trunk/local/libgo/go/os/user/decls_solaris.go:24:104: error: reference to undefined identifier 'syscall.group' func libc_getgrgid_r(gid syscall.Gid_t, grp *syscall.group, buf *byte, buflen syscall.Size_t, result **syscall.group) int ^ make[4]: *** [os/user.lo] Error 1 Easily fixed by the following patch: There are also a couple of testsuite regressions I need to investigate. Rainer diff --git a/libgo/go/os/user/decls_solaris.go b/libgo/go/os/user/decls_solaris.go --- a/libgo/go/os/user/decls_solaris.go +++ b/libgo/go/os/user/decls_solaris.go @@ -21,4 +21,4 @@ func libc_getpwuid_r(uid syscall.Uid_t, func libc_getgrnam_r(name *byte, grp *syscall.Group, buf *byte, buflen syscall.Size_t, result **syscall.Group) int //extern __posix_getgrgid_r -func libc_getgrgid_r(gid syscall.Gid_t, grp *syscall.group, buf *byte, buflen syscall.Size_t, result **syscall.group) int +func libc_getgrgid_r(gid syscall.Gid_t, grp *syscall.Group, buf *byte, buflen syscall.Size_t, result **syscall.Group) int