| Message ID | yddfuf155l0.fsf@CeBiTec.Uni-Bielefeld.DE |
|---|---|
| State | New |
| Headers | show |
On Thu, Jun 15, 2017 at 2:00 PM, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote: > >> I've committed this patch to the top level Makefile.def so that `make >> check-go` will run `make check-gotools`. Bootstrapped and ran Go >> testsuite on x86_64-pc-linux-gnu. Committed to mainline. >> >> This patch may cause new test failures on other systems. Please let >> me know about them. I don't anticipate anything in particular, but, >> who knows. > > the gotools test results came up empty on *-*-solaris2.12 with /bin/ksh. > In the make check-gotools output I found > > (cd check-go-dir/src/cmd/go && /var/gcc/regression/trunk/12-gcc/build/gotools/go test -test.short -test.v) >& cmd_go-testlog || true > /bin/ksh: line 3: cmd_go-testlog: bad file unit number > > If one uses the portable form of I/O redirection here, the test works on > Solaris, too. > > Rainer > > -- > ----------------------------------------------------------------------------- > Rainer Orth, Center for Biotechnology, Bielefeld University > > > 2017-06-15 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> > > * Makefile.am (check-go-tool): Don't use >& for I/O redirection. > * Makefile.in: Regenerate. Whoops. This is OK. You can go ahead and commit--unlike the go/gofrontend and libgo directories, this directory lives entirely in the GCC tree. Thanks. Ian
# HG changeset patch # Parent 88b687cecf78f7c39cd989fc9c4906b2c71a549b Don't use >& for I/O redirection diff --git a/gotools/Makefile.am b/gotools/Makefile.am --- a/gotools/Makefile.am +++ b/gotools/Makefile.am @@ -180,7 +180,7 @@ check-go-tool: go$(EXEEXT) check-head ch $(CHECK_ENV) \ GOPATH=`cd check-go-dir && $(PWD_COMMAND)`; \ export GOPATH; \ - (cd check-go-dir/src/cmd/go && $(abs_builddir)/go$(EXEEXT) test -test.short -test.v) >& cmd_go-testlog || true + (cd check-go-dir/src/cmd/go && $(abs_builddir)/go$(EXEEXT) test -test.short -test.v) > cmd_go-testlog 2>&1 || true grep '^--- ' cmd_go-testlog | sed -e 's/^--- \(.*\) ([^)]*)$$/\1/' # The check targets runs the tests and assembles the output files.