From patchwork Mon May 2 13:33:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 617540 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qz4yW4rDWz9t44 for ; Mon, 2 May 2016 23:33:55 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=WKO7sNwU; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version:content-type; q=dns; s=default; b=vM2iM76ZxKz7/MMMgmHJvLbBkYp3CAhW61MewAsuE+n1sdrAEx Dghm68MS2RnT05AkL/YjNZqPfC3Ut2/LXWT/Wr3DyTCrz40U4N5uCC2CNu3rwktk e+rQbKMhkUq6wRkB3p3WNgnjyX5blEQcTBWsb509T6kqHgfiS6/mVcsOM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version:content-type; s= default; bh=fD/XMrvIHgGlVptdEO+gqlFIERg=; b=WKO7sNwUnjv7Y4Ms/0CC WQIb7rZ7mfnt1v4/T49usYdwMxH3VfKJqoJxw4F2n3eingGJqLS0lT9fxr5VJ76m DwYA0LRGuWLAEx/vEX7hM7D4jvuwd5ApfmL698CshIDGkloqt+esJzx2NslDctAJ GfdsrYEOwNAYROLmUOZd1ro= Received: (qmail 81615 invoked by alias); 2 May 2016 13:33:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 81600 invoked by uid 89); 2 May 2016 13:33:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=3810, Hx-languages-length:2162 X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 May 2016 13:33:37 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id D073179E; Mon, 2 May 2016 15:33:34 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id rVbb8xilYVmL; Mon, 2 May 2016 15:33:32 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.110]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 6E87F79C; Mon, 2 May 2016 15:33:32 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id u42DXWGg005011; Mon, 2 May 2016 15:33:32 +0200 (CEST) From: Rainer Orth To: gcc-patches@gcc.gnu.org Cc: Caroline Tice , Paolo Bonzini Subject: [libvtv, build] Don't install libvtv without --enable-vtable-verify Date: Mon, 02 May 2016 15:33:32 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes When installing gcc 6.1.0 on Solaris 12, installation failed in libvtv: libtool: install: /usr/gnu/bin/install -c .libs/libvtv.lai /var/gcc/gcc-6.1.0/12-gcc-gas/install/vol/gcc-6/lib/amd64/libvtv.la libtool: install: /usr/gnu/bin/install -c .libs/libvtv.a /var/gcc/gcc-6.1.0/12-gcc-gas/install/vol/gcc-6/lib/amd64/libvtv.a /usr/gnu/bin/install: cannot stat '.libs/libvtv.a': No such file or directory make[10]: *** [install-toolexeclibLTLIBRARIES] Error 1 make[10]: Leaving directory `/var/gcc/gcc-6.1.0/12-gcc-gas/i386-pc-solaris2.12/amd64/libvtv' The problem is that libvtv.a is created like this libtool: link: ar rc .libs/libvtv.a libtool: link: ranlib .libs/libvtv.a i.e. with no objects, when --enable-vtable-verify isn't specified, and Solaris ar does nothing in this case, unlike GNU ar which creates an archive containing only the 8-byte archive header. Given that in this situation libvtv is useless anyway (the vtv_*.o files in libgcc aren't built either), I've chosen to avoid the installation completely. Tested on i386-pc-solaris2.11 without and with --enable-vtable-verify. Ok for mainline and gcc-6 branch? Thanks. Rainer 2016-04-29 Rainer Orth * Makefile.am (toolexeclib_LTLIBRARIES): Only set if ENABLE_VTABLE_VERIFY. Simplify. * Makefile.in: Regenerate. # HG changeset patch # Parent 47d2bbf59155ec37a1fa565f8774657b7045ef41 Don't install libvtv without --enable-vtable-verify diff --git a/libvtv/Makefile.am b/libvtv/Makefile.am --- a/libvtv/Makefile.am +++ b/libvtv/Makefile.am @@ -38,10 +38,11 @@ AM_CXXFLAGS = $(XCFLAGS) AM_CXXFLAGS += $(LIBSTDCXX_RAW_CXX_CXXFLAGS) AM_CXXFLAGS += -Wl,-u_vtable_map_vars_start,-u_vtable_map_vars_end +if ENABLE_VTABLE_VERIFY + toolexeclib_LTLIBRARIES = libvtv.la if VTV_CYGMIN - toolexeclib_LTLIBRARIES = libvtv.la libvtv_stubs.la -else - toolexeclib_LTLIBRARIES = libvtv.la + toolexeclib_LTLIBRARIES += libvtv_stubs.la +endif endif vtv_headers = \