From patchwork Fri Nov 11 16:23:12 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 125208 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 756FCB70BC for ; Sat, 12 Nov 2011 03:23:39 +1100 (EST) Received: (qmail 10609 invoked by alias); 11 Nov 2011 16:23:35 -0000 Received: (qmail 10594 invoked by uid 22791); 11 Nov 2011 16:23:31 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Nov 2011 16:23:18 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id ED85C4CF; Fri, 11 Nov 2011 17:23:16 +0100 (CET) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id GaOKL9kHSfTF; Fri, 11 Nov 2011 17:23:14 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 473FA4CC; Fri, 11 Nov 2011 17:23:14 +0100 (CET) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.5+Sun/8.14.5/Submit) id pABGNCMa009618; Fri, 11 Nov 2011 17:23:12 +0100 (MET) From: Rainer Orth To: "Ulrich Weigand" Cc: gcc-patches@gcc.gnu.org, bonzini@gnu.org (Paolo Bonzini), hp@axis.com (Hans-Peter Nilsson) Subject: Re: SPU build broken (Re: CFT: [build] Move libgcc2 to toplevel libgcc) References: <201111051552.pA5Fq8Sd024360@d06av02.portsmouth.uk.ibm.com> Date: Fri, 11 Nov 2011 17:23:12 +0100 In-Reply-To: <201111051552.pA5Fq8Sd024360@d06av02.portsmouth.uk.ibm.com> (Ulrich Weigand's message of "Sat, 5 Nov 2011 16:52:08 +0100 (CET)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org "Ulrich Weigand" writes: > Rainer Orth wrote: > >> diff --git a/gcc/config/spu/t-spu-elf b/gcc/config/spu/t-spu-elf > >> -# We exclude those because the libgcc2.c default versions do not support >> -# the SPU single-precision format (round towards zero). We provide our >> -# own versions below and/or via direct expansion. >> -LIB2FUNCS_EXCLUDE = _floatdisf _floatundisf _floattisf _floatunstisf > >> diff --git a/libgcc/config/spu/t-elf b/libgcc/config/spu/t-elf > >> +# We exclude those because the libgcc2.c default versions do not support >> +# the SPU single-precision format (round towards zero). We provide our >> +# own versions below and/or via direct expansion. >> +LIB2ADD = _floatdisf _floatundisf _floattisf _floatunstisf > > > This seems to have caused: > > make[2]: Entering directory `/home/kwerner/dailybuild/spu-tc-2011-11-05/gcc-build/spu/libgcc' > Makefile:792: *** Unsupported files in LIB2ADD or LIB2ADD_ST.. Stop. Sorry for the delay. Indeed, the test at that line only accepts .c, .S, and .asm files, where the latter should probably be removed now that we've standardized on .S. > Shouldn't the variable still be called LIB2FUNCS_EXCLUDE after the > move to libgcc? LIB2ADD seems to expect full file names ... Of course, the change is bogus. I can only (half) explain this by the change from LIB2FUNCS_STATIC_EXTRA to LIB2ADD_ST extra. The trivial patch allowed a x86_64-unknown-linux-gnu x spu-elf cross to finish the libgcc build, and at least the set of objects built before my patch series is identical to the set built now. Ok for mainline? Rainer 2011-11-11 Rainer Orth * config/spu/t-elf (LIB2ADD): Use LIB2FUNCS_EXCLUDE instead. # HG changeset patch # Parent 4b61b438da8a6a11ab1e06abe67fd26fa715c25e Fix SPU libgcc build diff --git a/libgcc/config/spu/t-elf b/libgcc/config/spu/t-elf --- a/libgcc/config/spu/t-elf +++ b/libgcc/config/spu/t-elf @@ -5,7 +5,7 @@ CRTSTUFF_T_CFLAGS = # We exclude those because the libgcc2.c default versions do not support # the SPU single-precision format (round towards zero). We provide our # own versions below and/or via direct expansion. -LIB2ADD = _floatdisf _floatundisf _floattisf _floatunstisf +LIB2FUNCS_EXCLUDE = _floatdisf _floatundisf _floattisf _floatunstisf LIB2ADD_ST = $(srcdir)/config/spu/float_unssidf.c \ $(srcdir)/config/spu/float_unsdidf.c \