diff mbox

[testsuite,i386] Fix gcc.target/i386/avx-vextractf128-256-5.c with Solaris as (PR testsuite/70356)

Message ID ydda8lfdgyd.fsf@CeBiTec.Uni-Bielefeld.DE
State New
Headers show

Commit Message

Rainer Orth March 30, 2016, 5:16 p.m. UTC 
This patch (provided by Jakub in the PR) fixes a failure of
gcc.target/i386/avx-vextractf128-256-5.c on the gcc-5 branch with the
Solaris assembler:

FAIL: gcc.target/i386/avx-vextractf128-256-5.c (test for excess errors)

The problem is that a target selector to dg-do overrides a previous
dg-require-effective-target, causing (in this case) an attempt to
assemble avx512f insns with the native Solaris assembler that lacks
support for them.

Tested with the appropriate runtest invocations on i386-pc-solaris2.12
with both as and gas, installed on the gcc-5 branch as approved by Uros
in the PR.

As Uros requested, I've also forward-ported the testcase to mainline
where it had been forgotten, tested as before and on x86_64-pc-linux-gnu.

	Rainer


2016-03-29  Jakub Jelinek  <jakub@redhat.com>

	PR testsuite/70356
	* gcc.target/i386/avx-vextractf128-256-5.c: Move
	dg-require-effective-target after dg-do.
diff mbox

Patch

# HG changeset patch
# Parent  e98f530832af6d6305e1369245a5b79bb2d9f5bb
Fix gcc.target/i386/avx-vextractf128-256-5.c with Solaris as (PR testsuite/70356)

diff --git a/gcc/testsuite/gcc.target/i386/avx-vextractf128-256-5.c b/gcc/testsuite/gcc.target/i386/avx-vextractf128-256-5.c
--- a/gcc/testsuite/gcc.target/i386/avx-vextractf128-256-5.c
+++ b/gcc/testsuite/gcc.target/i386/avx-vextractf128-256-5.c
@@ -1,5 +1,5 @@ 
+/* { dg-do assemble { target { ! ia32 } } } */
 /* { dg-require-effective-target avx512f } */
-/* { dg-do assemble { target { ! ia32 } } } */
 /* { dg-options "-O2 -mavx512f" } */
 
 #include <immintrin.h>